mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-13 00:19:03 +02:00
fix: sweep — every sync spawn in the test trees carries a timeout (436 sites, 157 files)
spawnSync/execSync/Bun.spawnSync BLOCK the main thread, so bun's in-process per-test timeout can never fire while one waits — a hung child (stdin read, network probe, dead daemon) wedges the whole shard until the runner's external wall-clock SIGKILL. This exact class reached main: free-tests run 33262077256, test/gstack-memory-ingest.test.ts (normally 2.3s) held shard 2 at the 360s wall while its five siblings finished in ~65s. Mechanical sweep in two waves (12 + 4 fan-out agents, every edit verified against its call site): default timeout: 30_000 (matches the free runner's per-test budget), 120_000 for genuinely slow ops (installs, builds, playwright, provider CLIs), helper wrappers fixed ONCE where call sites route through them. Sites that only LOOK like calls (string fixtures, grep needles, comments) were skipped with reasons — the enforcement commit that follows marks them exempt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
79efe395dc
commit
3e674e4c01
@@ -151,7 +151,7 @@ Write your report to ${qaOnlyDir}/qa-reports/qa-only-report.md`,
|
||||
|
||||
// Verify git working tree is still clean (no source modifications)
|
||||
const gitStatus = spawnSync('git', ['status', '--porcelain'], {
|
||||
cwd: qaOnlyDir, stdio: 'pipe',
|
||||
cwd: qaOnlyDir, stdio: 'pipe', timeout: 30_000,
|
||||
});
|
||||
const statusLines = gitStatus.stdout.toString().trim().split('\n').filter(
|
||||
(l: string) => l.trim() && !l.includes('.prompt-tmp') && !l.includes('.gstack/') && !l.includes('qa-reports/'),
|
||||
@@ -263,7 +263,7 @@ This is a test+fix loop: find bugs, fix them in the source code, commit each fix
|
||||
|
||||
// Verify at least one fix commit was made beyond the initial commit
|
||||
const gitLog = spawnSync('git', ['log', '--oneline'], {
|
||||
cwd: qaFixDir, stdio: 'pipe',
|
||||
cwd: qaFixDir, stdio: 'pipe', timeout: 30_000,
|
||||
});
|
||||
const commits = gitLog.stdout.toString().trim().split('\n');
|
||||
console.log(`/qa fix loop: ${commits.length} commits total (1 initial + ${commits.length - 1} fixes)`);
|
||||
|
||||
Reference in New Issue
Block a user