mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 06:34:43 +01:00
fix(review-risk): a recursive rm or rmSync keeps the security class whatever its arguments hold (GST-942)
The rmSync rule stopped at the first ), so path.join(...) as the first argument or a ) in a comment hid recursive: true, and async fs.rm had no rule. Both now read up to 500 characters of the line, in linear time. Repin lib/review-risk.ts under no-loss replay GST-942 (dispatch superset: 170 of 170 old matches kept, 19 added, no tier change over 100 main commits). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
3d99c22497
commit
3f6708e487
5 files changed
+19
-6
No files matched your search
@@ -228,7 +228,7 @@ line that can run code (a script or `foreignObject` element, an event handler, a
|
||||
rules are coarse on purpose and parse no import clause or call arguments;
|
||||
`test/review-risk-linear.test.ts` holds each of them under 100 ms on
|
||||
200,000-character hostile lines, its anchor followed by a long run of the
|
||||
characters it repeats included. `test/review-risk-redos.test.ts` (GST-898) holds every risk pattern, R51's `rm` and `rmSync` rules included, under 100 ms on 100,000-character hostile lines. An `rmSync(` call with more than 500 characters before the first `)` after it counts as security on its own. **data** is user data: a path naming pii, gdpr, ccpa, privacy,
|
||||
characters it repeats included. `test/review-risk-redos.test.ts` (GST-898) holds every risk pattern, R51's `rm` and `rmSync` rules included, under 100 ms on 100,000-character hostile lines. An `rmSync(` or `.rm(` call counts as security when `recursive: true` follows within 500 characters on the same line, whatever the arguments hold (a `path.join(...)` first argument or a `)` in a comment included, GST-942), and on its own when more than 500 characters come before the first `)` after it. **data** is user data: a path naming pii, gdpr, ccpa, privacy,
|
||||
personal, account, customer, cookie, persistence, storage or database, or a line
|
||||
that drops a table or column, deletes rows or bulk-deletes records. Auth scope,
|
||||
migrations and deleted code paths were already gate class. `RISK_RULES` hashes
|
||||
|
||||
Reference in new issue
Block a user