CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-01 19:25:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove false-positive Exit code 1 pattern, fix NEEDS_SETUP test, update QA tests

Browse Source 
- Remove /Exit code 1/ from BROWSE_ERROR_PATTERNS — too broad, matches any
  bash command exit code in the transcript (e.g., git diff, test commands).
  Remaining patterns (Unknown command, Unknown snapshot flag, binary not found,
  server failed, no such file) are specific to browse errors.

- Fix NEEDS_SETUP E2E test — accepts READY when global binary exists at
  ~/.claude/skills/gstack/browse/dist/browse (which it does on dev machines).
  Test now verifies the setup block handles missing local binary gracefully.

- Update QA skill structure validation tests to match current qa/SKILL.md
  template content (phases renamed, modes replaced tiers, output structure).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-14 04:48:35 -05:00
parent a67dae5f84
commit 4063104126
3 changed files with 31 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/skill-validation.test.ts
+22 -29
View File
@@ -261,41 +261,34 @@ describe('Cross-skill path consistency', () => {
describe('QA skill structure validation', () => {
const qaContent = fs.readFileSync(path.join(ROOT, 'qa', 'SKILL.md'), 'utf-8');
test('qa/SKILL.md has all 7 phases', () => {
test('qa/SKILL.md has all 6 phases', () => {
const phases = [
'Phase 1', 'Initialize',
'Phase 2', 'Authenticate',
'Phase 3', 'Recon',
'Phase 4', 'Test Plan',
'Phase 5', 'Execute',
'Phase 6', 'Document',
'Phase 7', 'Wrap',
'Phase 3', 'Orient',
'Phase 4', 'Explore',
'Phase 5', 'Document',
'Phase 6', 'Wrap Up',
];
for (const phase of phases) {
expect(qaContent).toContain(phase);
}
});
test('risk heuristic table has all required patterns', () => {
const patterns = [
'Form/payment/auth/checkout',
'Controller/route with mutations',
'Config/env/deployment',
'API endpoint handlers',
'View/template/component',
'Model/service with business logic',
'CSS/style-only',
'Docs/readme/comments',
'Test files only',
test('has all four QA modes defined', () => {
const modes = [
'Diff-aware',
'Full',
'Quick',
'Regression',
];
for (const pattern of patterns) {
expect(qaContent).toContain(pattern);
for (const mode of modes) {
expect(qaContent).toContain(mode);
}
// Risk levels
for (const level of ['HIGH', 'MEDIUM', 'LOW', 'SKIP']) {
expect(qaContent).toContain(level);
}
// Mode triggers/flags
expect(qaContent).toContain('--quick');
expect(qaContent).toContain('--regression');
});
test('health score weights sum to 100%', () => {
@@ -321,18 +314,18 @@ describe('QA skill structure validation', () => {
expect(weights.size).toBe(8);
});
test('has three tier definitions (Quick/Standard/Exhaustive)', () => {
expect(qaContent).toContain('Quick Depth');
expect(qaContent).toContain('Standard Depth');
expect(qaContent).toContain('Exhaustive Depth');
test('has four mode definitions (Diff-aware/Full/Quick/Regression)', () => {
expect(qaContent).toContain('### Diff-aware');
expect(qaContent).toContain('### Full');
expect(qaContent).toContain('### Quick');
expect(qaContent).toContain('### Regression');
});
test('output structure references report directory layout', () => {
expect(qaContent).toContain('index.md');
expect(qaContent).toContain('test-plan-');
expect(qaContent).toContain('qa-report-');
expect(qaContent).toContain('baseline.json');
expect(qaContent).toContain('screenshots/');
expect(qaContent).toContain('.gstack/qa-reports/');
});
});