From 40a292e1df91251683b8e16cba1b7bf68da7a81a Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sat, 29 Aug 2026 04:59:48 +0000 Subject: [PATCH] fix(test): trim the seven over-wall 1700s timeouts to the 1500s physical ceiling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1,700,000ms (28.3 min) exceeded every wall these tests run inside: the 25-min CI job timeout and the 1800s sharded-runner wall (which also leaves --retry 1 zero room for a second attempt). Budget above the wall is fiction, not headroom — a test that actually used it produced a job-level kill (no bun summary, no artifact) instead of a clean per-test timeout. No recorded p95 exists for this family (they are being retiered to periodic in the re-platform wave); the trim stops at the physical ceiling rather than guessing lower. Final policy lands in the Wave-2 eval-budgets constants module. Co-Authored-By: Claude Fable 5 --- test/skill-e2e-plan-ceo-finding-count.test.ts | 4 ++-- test/skill-e2e-plan-ceo-split-overflow.test.ts | 2 +- test/skill-e2e-plan-design-finding-count.test.ts | 2 +- test/skill-e2e-plan-devex-finding-count.test.ts | 2 +- test/skill-e2e-plan-eng-finding-count.test.ts | 2 +- test/skill-e2e-plan-eng-multi-finding-batching.test.ts | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/test/skill-e2e-plan-ceo-finding-count.test.ts b/test/skill-e2e-plan-ceo-finding-count.test.ts index 4c624d912..4b8038b02 100644 --- a/test/skill-e2e-plan-ceo-finding-count.test.ts +++ b/test/skill-e2e-plan-ceo-finding-count.test.ts @@ -194,7 +194,7 @@ describeE2E('/plan-ceo-review per-finding AskUserQuestion count (periodic)', () } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); test( @@ -249,6 +249,6 @@ describeE2E('/plan-ceo-review per-finding AskUserQuestion count (periodic)', () } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); }); diff --git a/test/skill-e2e-plan-ceo-split-overflow.test.ts b/test/skill-e2e-plan-ceo-split-overflow.test.ts index 57d39c8f2..9f9060d68 100644 --- a/test/skill-e2e-plan-ceo-split-overflow.test.ts +++ b/test/skill-e2e-plan-ceo-split-overflow.test.ts @@ -113,6 +113,6 @@ describeE2E('/plan-ceo-review split-overflow regression (periodic)', () => { } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); }); diff --git a/test/skill-e2e-plan-design-finding-count.test.ts b/test/skill-e2e-plan-design-finding-count.test.ts index 4f0d8b544..6f2398d99 100644 --- a/test/skill-e2e-plan-design-finding-count.test.ts +++ b/test/skill-e2e-plan-design-finding-count.test.ts @@ -132,6 +132,6 @@ describeE2E('/plan-design-review per-finding AskUserQuestion count (periodic)', } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); }); diff --git a/test/skill-e2e-plan-devex-finding-count.test.ts b/test/skill-e2e-plan-devex-finding-count.test.ts index 3a3098b63..e80bdac5d 100644 --- a/test/skill-e2e-plan-devex-finding-count.test.ts +++ b/test/skill-e2e-plan-devex-finding-count.test.ts @@ -132,6 +132,6 @@ describeE2E('/plan-devex-review per-finding AskUserQuestion count (periodic)', ( } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); }); diff --git a/test/skill-e2e-plan-eng-finding-count.test.ts b/test/skill-e2e-plan-eng-finding-count.test.ts index a0f14fd6d..f51018c77 100644 --- a/test/skill-e2e-plan-eng-finding-count.test.ts +++ b/test/skill-e2e-plan-eng-finding-count.test.ts @@ -131,6 +131,6 @@ describeE2E('/plan-eng-review per-finding AskUserQuestion count (periodic)', () } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); }); diff --git a/test/skill-e2e-plan-eng-multi-finding-batching.test.ts b/test/skill-e2e-plan-eng-multi-finding-batching.test.ts index 73e1179c6..89d2b594d 100644 --- a/test/skill-e2e-plan-eng-multi-finding-batching.test.ts +++ b/test/skill-e2e-plan-eng-multi-finding-batching.test.ts @@ -101,6 +101,6 @@ describeE2E('/plan-eng-review multi-finding batching regression (periodic)', () } } }, - 1_700_000, + 1_500_000 /* physical ceiling: the 25-min CI job + 1800s shard wall cap what can actually execute */, ); });