feat: qa-only skill, qa fix loop, plan-to-QA artifact flow

Add /qa-only (report-only, Edit tool blocked), restructure /qa with
find-fix-verify cycle, add {{QA_METHODOLOGY}} DRY placeholder for
shared methodology. /plan-eng-review now writes test-plan artifacts
to ~/.gstack/projects/<slug>/ for QA consumption.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test/gen-skill-docs.test.ts

@@ -61,6 +61,7 @@ describe('gen-skill-docs', () => {
     { dir: '.', name: 'root gstack' },
     { dir: 'browse', name: 'browse' },
     { dir: 'qa', name: 'qa' },
+    { dir: 'qa-only', name: 'qa-only' },
     { dir: 'review', name: 'review' },
     { dir: 'ship', name: 'ship' },
     { dir: 'plan-ceo-review', name: 'plan-ceo-review' },
@@ -129,6 +130,61 @@ describe('gen-skill-docs', () => {
     expect(browseTmpl).toContain('{{COMMAND_REFERENCE}}');
     expect(browseTmpl).toContain('{{SNAPSHOT_FLAGS}}');
   });
+
+  test('qa and qa-only templates use QA_METHODOLOGY placeholder', () => {
+    const qaTmpl = fs.readFileSync(path.join(ROOT, 'qa', 'SKILL.md.tmpl'), 'utf-8');
+    expect(qaTmpl).toContain('{{QA_METHODOLOGY}}');
+
+    const qaOnlyTmpl = fs.readFileSync(path.join(ROOT, 'qa-only', 'SKILL.md.tmpl'), 'utf-8');
+    expect(qaOnlyTmpl).toContain('{{QA_METHODOLOGY}}');
+  });
+
+  test('QA_METHODOLOGY appears expanded in both qa and qa-only generated files', () => {
+    const qaContent = fs.readFileSync(path.join(ROOT, 'qa', 'SKILL.md'), 'utf-8');
+    const qaOnlyContent = fs.readFileSync(path.join(ROOT, 'qa-only', 'SKILL.md'), 'utf-8');
+
+    // Both should contain the health score rubric
+    expect(qaContent).toContain('Health Score Rubric');
+    expect(qaOnlyContent).toContain('Health Score Rubric');
+
+    // Both should contain framework guidance
+    expect(qaContent).toContain('Framework-Specific Guidance');
+    expect(qaOnlyContent).toContain('Framework-Specific Guidance');
+
+    // Both should contain the important rules
+    expect(qaContent).toContain('Important Rules');
+    expect(qaOnlyContent).toContain('Important Rules');
+
+    // Both should contain the 6 phases
+    expect(qaContent).toContain('Phase 1');
+    expect(qaOnlyContent).toContain('Phase 1');
+    expect(qaContent).toContain('Phase 6');
+    expect(qaOnlyContent).toContain('Phase 6');
+  });
+
+  test('qa-only has no-fix guardrails', () => {
+    const qaOnlyContent = fs.readFileSync(path.join(ROOT, 'qa-only', 'SKILL.md'), 'utf-8');
+    expect(qaOnlyContent).toContain('Never fix bugs');
+    expect(qaOnlyContent).toContain('NEVER fix anything');
+    // Should not have Edit, Glob, or Grep in allowed-tools
+    expect(qaOnlyContent).not.toMatch(/allowed-tools:[\s\S]*?Edit/);
+    expect(qaOnlyContent).not.toMatch(/allowed-tools:[\s\S]*?Glob/);
+    expect(qaOnlyContent).not.toMatch(/allowed-tools:[\s\S]*?Grep/);
+  });
+
+  test('qa has fix-loop tools and phases', () => {
+    const qaContent = fs.readFileSync(path.join(ROOT, 'qa', 'SKILL.md'), 'utf-8');
+    // Should have Edit, Glob, Grep in allowed-tools
+    expect(qaContent).toContain('Edit');
+    expect(qaContent).toContain('Glob');
+    expect(qaContent).toContain('Grep');
+    // Should have fix-loop phases
+    expect(qaContent).toContain('Phase 7');
+    expect(qaContent).toContain('Phase 8');
+    expect(qaContent).toContain('Fix Loop');
+    expect(qaContent).toContain('Triage');
+    expect(qaContent).toContain('WTF');
+  });
 });
 
 /**

test/skill-validation.test.ts

@@ -43,6 +43,20 @@ describe('SKILL.md command validation', () => {
     const result = validateSkill(qaSkill);
     expect(result.snapshotFlagErrors).toHaveLength(0);
   });
+
+  test('all $B commands in qa-only/SKILL.md are valid browse commands', () => {
+    const qaOnlySkill = path.join(ROOT, 'qa-only', 'SKILL.md');
+    if (!fs.existsSync(qaOnlySkill)) return;
+    const result = validateSkill(qaOnlySkill);
+    expect(result.invalid).toHaveLength(0);
+  });
+
+  test('all snapshot flags in qa-only/SKILL.md are valid', () => {
+    const qaOnlySkill = path.join(ROOT, 'qa-only', 'SKILL.md');
+    if (!fs.existsSync(qaOnlySkill)) return;
+    const result = validateSkill(qaOnlySkill);
+    expect(result.snapshotFlagErrors).toHaveLength(0);
+  });
 });
 
 describe('Command registry consistency', () => {
@@ -157,6 +171,7 @@ describe('Generated SKILL.md freshness', () => {
 describe('Update check preamble', () => {
   const skillsWithUpdateCheck = [
     'SKILL.md', 'browse/SKILL.md', 'qa/SKILL.md',
+    'qa-only/SKILL.md',
     'setup-browser-cookies/SKILL.md',
     'ship/SKILL.md', 'review/SKILL.md',
     'plan-ceo-review/SKILL.md', 'plan-eng-review/SKILL.md',
@@ -261,7 +276,7 @@ describe('Cross-skill path consistency', () => {
 describe('QA skill structure validation', () => {
   const qaContent = fs.readFileSync(path.join(ROOT, 'qa', 'SKILL.md'), 'utf-8');
 
-  test('qa/SKILL.md has all 6 phases', () => {
+  test('qa/SKILL.md has all 11 phases', () => {
     const phases = [
       'Phase 1', 'Initialize',
       'Phase 2', 'Authenticate',
@@ -269,6 +284,11 @@ describe('QA skill structure validation', () => {
       'Phase 4', 'Explore',
       'Phase 5', 'Document',
       'Phase 6', 'Wrap Up',
+      'Phase 7', 'Triage',
+      'Phase 8', 'Fix Loop',
+      'Phase 9', 'Final QA',
+      'Phase 10', 'Report',
+      'Phase 11', 'TODOS',
     ];
     for (const phase of phases) {
       expect(qaContent).toContain(phase);
@@ -291,6 +311,13 @@ describe('QA skill structure validation', () => {
     expect(qaContent).toContain('--regression');
   });
 
+  test('has all three tiers defined', () => {
+    const tiers = ['Quick', 'Standard', 'Exhaustive'];
+    for (const tier of tiers) {
+      expect(qaContent).toContain(tier);
+    }
+  });
+
   test('health score weights sum to 100%', () => {
     const weights = extractWeightsFromTable(qaContent);
     expect(weights.size).toBeGreaterThan(0);