CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-10 06:58:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(upgrade): v1.27 migration no longer auto-proceeds without a TTY or records a failed rename as done (#1383)

Browse Source 
Two silent-failure shapes in one script. Non-interactive runs (Claude Code
Bash tool, CI) blanket-auto-proceeded into a REMOTE repo rename — now they
skip-for-now by default and ask again next upgrade; unattended runs opt in
with GSTACK_MIGRATE_ASSUME_YES=1. And a failed gh rename was journaled as
done and the done-touchfile written, permanently stranding a half-renamed
install — the failed step now stays PENDING with the manual command printed,
finalize refuses the done-marker while any step is unjournaled, and the
migration exits 1 with a re-run pointer while completed steps still skip on
retry.

Harness updated to opt in explicitly; new tests pin the default-skip and
failure-stays-pending-then-retry-succeeds contracts (13/13).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-14 12:02:29 -07:00
co-authored by Claude Fable 5
parent cd5433add1
commit 449f59549b
2 changed files with 82 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gstack-upgrade/migrations/v1.27.0.0.sh
+28 -5
View File
@@ -130,8 +130,19 @@ EOF
;;
esac
else
# Non-interactive (CI, scripted upgrade): proceed automatically.
echo " (non-interactive: proceeding automatically)" >&2
# Non-interactive (CI, Claude Code Bash tool, scripted upgrade). Step 1
# renames a REMOTE repo — consent-shaped, and blanket auto-proceed once
# left an install half-migrated when that step failed mid-run (#1383).
# Skip for now by default (asked again next upgrade); explicit opt-in
# proceeds unattended.
if [ "${GSTACK_MIGRATE_ASSUME_YES:-0}" = "1" ]; then
echo " (non-interactive: proceeding — GSTACK_MIGRATE_ASSUME_YES=1)" >&2
else
echo " Non-interactive session: skipping for now (will ask again next upgrade)." >&2
echo " To proceed unattended: GSTACK_MIGRATE_ASSUME_YES=1 ./setup" >&2
echo " To run interactively: /setup-gbrain --rerun-migration" >&2
exit 0
fi
fi
fi
@@ -195,8 +206,8 @@ if ! journal_done "gh_repo_renamed"; then
mark_done "gh_repo_renamed"
else
echo " WARNING: gh rename failed (repo may not exist or permission denied)" >&2
echo " skipping step 1; subsequent steps still run" >&2
mark_done "gh_repo_renamed"
echo " step 1 stays PENDING and will retry on re-run; later steps still run (#1383)" >&2
echo " manual: gh repo rename $NEW_REPO_NAME --repo $OLD_REPO_NAME --yes" >&2
fi
fi
else
@@ -335,8 +346,20 @@ EOF
fi
# ---------------------------------------------------------------------------
# Step 6: finalize (touchfile + clear journal)
# Step 6: finalize (touchfile + clear journal) — only when EVERY step is
# journaled. A failed step must leave the migration visibly incomplete and
# retryable, never silently recorded as done (#1383).
# ---------------------------------------------------------------------------
INCOMPLETE=""
for _step in gh_repo_renamed remote_txt_renamed config_key_renamed claude_md_block_rewritten sources_swapped; do
journal_done "$_step" || INCOMPLETE="$INCOMPLETE $_step"
done
if [ -n "$INCOMPLETE" ]; then
echo " [v1.27.0.0] migration INCOMPLETE — pending step(s):$INCOMPLETE" >&2
echo " Completed steps are journaled and will be skipped on re-run." >&2
echo " Re-run via: /setup-gbrain --rerun-migration" >&2
exit 1
fi
touch "$DONE"
rm -f "$JOURNAL"