diff --git a/.github/workflows/evals-periodic.yml b/.github/workflows/evals-periodic.yml index 98c68988e..9c168f01d 100644 --- a/.github/workflows/evals-periodic.yml +++ b/.github/workflows/evals-periodic.yml @@ -135,6 +135,12 @@ jobs: steps: - uses: actions/checkout@v7 with: + # Full history: files with SELF-derived selection (the LLM-judge + # map, routing) walk git at module load, and selection is + # fail-closed on git errors — a shallow checkout crashed those + # shards on the lane's first live run ("ambiguous argument + # 'main...HEAD'"). The manifest still governs WHICH shards run. + fetch-depth: 0 persist-credentials: false - name: Fix bun temp @@ -257,6 +263,12 @@ jobs: steps: - uses: actions/checkout@v7 with: + # Full history: files with SELF-derived selection (the LLM-judge + # map, routing) walk git at module load, and selection is + # fail-closed on git errors — a shallow checkout crashed those + # shards on the lane's first live run ("ambiguous argument + # 'main...HEAD'"). The manifest still governs WHICH shards run. + fetch-depth: 0 persist-credentials: false - name: Fix bun temp diff --git a/.github/workflows/evals.yml b/.github/workflows/evals.yml index d481e8f5f..f79612631 100644 --- a/.github/workflows/evals.yml +++ b/.github/workflows/evals.yml @@ -568,6 +568,12 @@ jobs: steps: - uses: actions/checkout@v7 with: + # Full history: files with SELF-derived selection (the LLM-judge + # map, routing) walk git at module load, and selection is + # fail-closed on git errors — a shallow checkout crashed those + # shards on the lane's first live run ("ambiguous argument + # 'main...HEAD'"). The manifest still governs WHICH shards run. + fetch-depth: 0 persist-credentials: false - name: Fix bun temp diff --git a/make-pdf/test/e2e/landscape-gate.test.ts b/make-pdf/test/e2e/landscape-gate.test.ts index 91c4f645d..a583fe65a 100644 --- a/make-pdf/test/e2e/landscape-gate.test.ts +++ b/make-pdf/test/e2e/landscape-gate.test.ts @@ -111,10 +111,19 @@ describe("landscape promotion gate", () => { if (!avail.ok) return; const workDir = fs.mkdtempSync("/tmp/make-pdf-landscape-toc-"); const outputPdf = path.join(workDir, "out.pdf"); + const baselinePdf = path.join(workDir, "baseline.pdf"); try { + // Comparative invariant, not an exact count: whether a wide table + // spills onto an extra landscape page depends on font metrics (the + // fixed `toBe(3)` passed on Amazon Linux and failed on ubuntu CI with + // 2 — the same disease the page-index comment above warns about). + // What --toc must not do is CHANGE the landscape promotion outcome. + generate([], baselinePdf); + const baselineLandscape = pageBoxes(baselinePdf).filter(isLandscape).length; + expect(baselineLandscape).toBeGreaterThanOrEqual(1); generate(["--toc"], outputPdf); const boxes = pageBoxes(outputPdf); - expect(boxes.filter(isLandscape).length).toBe(3); + expect(boxes.filter(isLandscape).length).toBe(baselineLandscape); const pdftotext = resolvePopplerTool("pdftotext")!; const text = execFileSync(pdftotext, [outputPdf, "-"], { encoding: "utf8", timeout: CHILD_TIMEOUT_MS }); diff --git a/test/paid-run-manifest.test.ts b/test/paid-run-manifest.test.ts index 402f63e24..0c2ffb196 100644 --- a/test/paid-run-manifest.test.ts +++ b/test/paid-run-manifest.test.ts @@ -68,7 +68,11 @@ describe('run manifest (planner)', () => { }); test('parse round-trips and rejects malformed manifests', () => { - const manifest = buildRunManifest({ tier: 'gate', sliceCount: 2, evalsAll: false, env: {} }); + // EVALS_ALL short-circuits diff selection BEFORE any git walk: selection + // is deliberately fail-closed on git errors, and CI's shallow free-tests + // checkout has no base ref (first CI run failed here with + // "ambiguous argument 'main...HEAD'"). + const manifest = buildRunManifest({ tier: 'gate', sliceCount: 2, evalsAll: false, env: { EVALS_ALL: '1' } }); expect(parseRunManifest(JSON.stringify(manifest))).toEqual(manifest); expect(() => parseRunManifest('{}')).toThrow(/version/); expect(() => parseRunManifest(JSON.stringify({ ...manifest, tier: 'e2e' }))).toThrow(/tier/);