test: move the full office-hours workflow to marathon; add a periodic design-draft checkpoint

The full startup workflow runs 1–3 real spec-review rounds (~280s each) and
hit its 1200s capture in run 36385945043 at finalize. Review depth is the
product's loop, so the case cannot fit a blocking lane without cutting
rounds. It is now marathon tier with every assertion unchanged.

skill-e2e-office-hours-design-draft.test.ts (periodic) runs the same fixed
interview only through the Write that creates the design (269s in that run)
and applies the full validator's design-draft checks, the required section
reads and the launch/foreign-skill-read guards. validateOfficeHoursDesignDraft
is extracted from validateOfficeHoursCompletion, which still applies it.

Selection: office-hours-design-draft is registered periodic; the marathon-only
file is already excluded from the gate and periodic plans by the B5 planner
rule. Tier-alignment regexes and the valid-tier check accept 'marathon'.
A type-only cast in plan-scope-selection.test.ts removes a diagnostic whose
union print order made the ratchet identity unstable; baseline tightened.
This commit is contained in:
garrytan committed 2026-09-29 15:29:46 +00:00
1 parent a41cdb7d7d
commit 4973f96d98
12 files changed
+180 -57

No files matched your search

-2
View File
@@ -213,7 +213,6 @@
"test/helpers/ceo-hold-posture-review.ts\tTS2339\tProperty 'toolUseId' does not exist on type 'AskUserQuestionFingerprint'.": 2,
"test/helpers/ceo-mode-option.ts\tTS2345\tArgument of type 'string' is not assignable to parameter of type '\"defer\" | \"include\" | \"pause\" | \"skip\" | null'.": 1,
"test/helpers/ceo-split-question-policy.ts\tTS2345\tArgument of type 'NativePlanQuestion' is not assignable to parameter of type 'NativeQuestion'. Types of property 'multiSelect' are incompatible. Type 'boolean | undefined' is not assignable to type 'boolean'. Type 'undefined' is not assignable to type 'boolean'.": 3,
"test/helpers/ceo-split-question-policy.ts\tTS2345\tArgument of type 'string' is not assignable to parameter of type '\"cut\" | \"defer\" | \"hold\" | \"include\" | null'.": 1,
"test/helpers/claude-pty-runner.unit.test.ts\tTS2322\tType '{ [x: string]: string; }' is not assignable to type '{ \"D1 \\u2014 Add gstack skill routing rules to CLAUDE.md? <gstack-qid:routing-injection>\": string; \"D2 \\u2014 Should gstack search learnings from your other projects on this machine? <gstack-qid:cross-project-learnings>\"?: undefined; ... 7 more ...; \"D10 \\u2014 TODO: Add p99 latency metric for IDP calls before/after...'. Property '\"D10 — TODO: Add p99 latency metric for IDP calls before/after Promise.all parallelization. Add to TODOS.md? <gstack-qid:plan-eng-todo-idp-metrics>\"' is missing in type '{ [x: string]: string; }' but required in type '{ \"D1 \\u2014 Add gstack skill routing rules to CLAUDE.md? <gstack-qid:routing-injection>\"?: undefined; \"D2 \\u2014 Should gstack search learnings from your other projects on this machine? <gstack-qid:cross-project-learnings>\"?: undefined; ... 7 more ...; \"D10 \\u2014 TODO: Add p99 latency metric for IDP calls before/a...'.": 3,
"test/helpers/claude-pty-runner.unit.test.ts\tTS2322\tType '{ [x: string]: string; }' is not assignable to type '{ \"D1 \\u2014 The plan's scope (12 files, 4 new classes) triggers the complexity smell check. Proceed as-is or reduce scope first? <gstack-qid:plan-eng-complexity-check>\": string; ... 7 more ...; \"D9 \\u2014 TODOS: the plan has no mention of IDP circuit breaker or timeout per call. With 5 calls now running in parallel...'. Property '\"D9 — TODOS: the plan has no mention of IDP circuit breaker or timeout per call. With 5 calls now running in parallel (D8 decision), an IDP outage generates 5 concurrent timeouts per request. <gstack-qid:plan-eng-todo-idp-circuit-breaker>\"' is missing in type '{ [x: string]: string; }' but required in type '{ \"D1 \\u2014 The plan's scope (12 files, 4 new classes) triggers the complexity smell check. Proceed as-is or reduce scope first? <gstack-qid:plan-eng-complexity-check>\"?: undefined; ... 7 more ...; \"D9 \\u2014 TODOS: the plan has no mention of IDP circuit breaker or timeout per call. With 5 calls now running in para...'.": 1,
"test/helpers/claude-pty-runner.unit.test.ts\tTS2322\tType '{}' is not assignable to type '{ \"D1 \\u2014 Add gstack skill routing rules to CLAUDE.md? <gstack-qid:routing-injection>\": string; \"D2 \\u2014 Should gstack search learnings from your other projects on this machine? <gstack-qid:cross-project-learnings>\"?: undefined; ... 7 more ...; \"D10 \\u2014 TODO: Add p99 latency metric for IDP calls before/after...'.": 1,
@@ -416,7 +415,6 @@
"test/plan-review-decisions.test.ts\tTS7006\tParameter 'row' implicitly has an 'any' type.": 1,
"test/plan-scope-selection.test.ts\tTS2339\tProperty 'args' does not exist on type '{ skill: string; args: string; } | { skill: string; }'. Property 'args' does not exist on type '{ skill: string; }'.": 3,
"test/plan-scope-selection.test.ts\tTS2339\tProperty 'args' does not exist on type '{ skill: string; } | { skill: string; args: string; }'. Property 'args' does not exist on type '{ skill: string; }'.": 4,
"test/plan-scope-selection.test.ts\tTS2345\tArgument of type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; }; } | { name?: undefined; input?: undefined; kind: string; sessionId: string; timestamp: string; toolUseId: string; isError: boolean; } | { ...; } | { ...; } | { ...; } | { ...; }' is not assignable to parameter of type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; args: string; }; } | { name?: undefined; input?: undefined; kind: string; sessionId: string; timestamp: string; toolUseId: string; isError: boolean; } | { ...; }'. Type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; }; }' is not assignable to type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; args: string; }; } | { name?: undefined; input?: undefined; kind: string; sessionId: string; timestamp: string; toolUseId: string; isError: boolean; } | { ...; }'. Type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; }; }' is not assignable to type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; args: string; }; } | { isError?: undefined; input?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; }'. Type '{ isError?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; input: { skill: string; }; }' is not assignable to type '{ isError?: undefined; input?: undefined; kind: string; sessionId: string; timestamp: string; name: string; toolUseId: string; }'. Types of property '\"input\"' are incompatible. Type '{ skill: string; }' is not assignable to type 'undefined'.": 1,
"test/plan-seed-submission.test.ts\tTS2322\tType '{ GSTACK_PLAN_MODE?: undefined; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; } | { GSTACK_PLAN_MODE: string; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; } | { GSTACK_PLAN_MODE?: undefined; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; } | { ...; }' is not assignable to type 'Record<string, string> | undefined'. Type '{ GSTACK_PLAN_MODE?: undefined; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; }' is not assignable to type 'Record<string, string>'. Property 'GSTACK_PLAN_MODE' is incompatible with index signature. Type 'undefined' is not assignable to type 'string'.": 1,
"test/plan-seed-submission.test.ts\tTS2322\tType '{ TERM: string; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; } | { CI: string; TERM?: undefined; COLORTERM?: undefined; FORCE_COLOR?: undefined; NO_COLOR?: undefined; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; } | { ...; } | { ...; } | { ...; }' is not assignable to type 'Record<string, string> | undefined'. Type '{ CI: string; TERM?: undefined; COLORTERM?: undefined; FORCE_COLOR?: undefined; NO_COLOR?: undefined; CLAUDE_CONFIG_DIR: string; SEED_CASE: string; }' is not assignable to type 'Record<string, string>'. Property 'TERM' is incompatible with index signature. Type 'undefined' is not assignable to type 'string'.": 1,
"test/plan-seed-submission.test.ts\tTS2345\tArgument of type '(text: string, reviver?: ((this: any, key: string, value: any) => any) | undefined) => any' is not assignable to parameter of type '(value: string, index: number, array: string[]) => any'. Types of parameters 'reviver' and 'index' are incompatible. Type 'number' is not assignable to type '(this: any, key: string, value: any) => any'.": 4,