mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-22 04:40:44 +02:00
fix(server): delete ServerConfig.idleTimeoutMs + chromiumProfile — documented, never read
Both fields carried JSDoc asserting embedder behavior that did not exist: the idle check reads the module-level IDLE_TIMEOUT_MS env constant, and both resolveChromiumProfile() call sites pass no argument. Worse than absent — an embedder passing idleTimeoutMs: 5000 silently got 30 minutes. Wiring them honestly is impossible today: the idle timer, activity state, and shutdown target are module-global, so a per-factory value would lie for any process running more than one handler. Deleted instead, with a ServerConfig note pointing at the deferred singleton/route-table refactor where real support belongs. BROWSE_IDLE_TIMEOUT and CHROMIUM_PROFILE env remain the honest knobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
fc4cb6aaa9
commit
5099637f95
@@ -49,7 +49,6 @@ function makeMinimalConfig(overrides: Partial<ServerConfig> = {}): ServerConfig
|
||||
return {
|
||||
authToken: token,
|
||||
browsePort: 34568,
|
||||
idleTimeoutMs: 1_800_000,
|
||||
config: resolveConfig(),
|
||||
browserManager: new BrowserManager(),
|
||||
startTime: Date.now(),
|
||||
|
||||
@@ -120,22 +120,11 @@ describe('server.ts factory API surface', () => {
|
||||
}
|
||||
});
|
||||
|
||||
test('reads BROWSE_IDLE_TIMEOUT from env, defaults to 30 min (1800000ms)', () => {
|
||||
const orig = process.env.BROWSE_IDLE_TIMEOUT;
|
||||
delete process.env.BROWSE_IDLE_TIMEOUT;
|
||||
try {
|
||||
expect(resolveConfigFromEnv().idleTimeoutMs).toBe(1800000);
|
||||
} finally {
|
||||
if (orig !== undefined) process.env.BROWSE_IDLE_TIMEOUT = orig;
|
||||
}
|
||||
});
|
||||
|
||||
test('returns a populated config object with the expected shape', () => {
|
||||
const cfg = resolveConfigFromEnv();
|
||||
expect(cfg).toMatchObject({
|
||||
authToken: expect.any(String),
|
||||
browsePort: expect.any(Number),
|
||||
idleTimeoutMs: expect.any(Number),
|
||||
config: expect.objectContaining({
|
||||
stateDir: expect.any(String),
|
||||
stateFile: expect.any(String),
|
||||
@@ -178,7 +167,6 @@ describe('server.ts factory API surface', () => {
|
||||
const minimalConfigShape = {
|
||||
authToken: 'tok',
|
||||
browsePort: 0,
|
||||
idleTimeoutMs: 1800000,
|
||||
config: { stateDir: '', stateFile: '', consoleLog: '', networkLog: '', dialogLog: '', auditLog: '', projectDir: '' },
|
||||
browserManager: {} as any,
|
||||
startTime: Date.now(),
|
||||
@@ -217,7 +205,6 @@ function makeMinimalConfig(overrides: Partial<ServerConfig> = {}): ServerConfig
|
||||
return {
|
||||
authToken: token,
|
||||
browsePort: 34567,
|
||||
idleTimeoutMs: 1_800_000,
|
||||
config: resolveConfig(),
|
||||
browserManager: new BrowserManager(),
|
||||
startTime: Date.now(),
|
||||
|
||||
Reference in New Issue
Block a user