CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-09 22:48:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(session-kind): explicit GSTACK_SESSION_KIND override; skill-start spawned gates keyed on kind (#2733)

Browse Source 
Claude Code subagents inherit the parent env byte-for-byte, so ambient
markers classify them as the parent's kind and the spawned classification
was unreachable outside OpenClaw. GSTACK_SESSION_KIND=spawned (step 0,
spawned-only by design) lets a dispatching skill mark its subagent per
command. skill-start now keys SPAWNED_SESSION and the spawned-session
instruction block on the resolved kind (was raw OPENCLAW_SESSION),
suppresses CONDUCTOR_SESSION for spawned sessions, gates all 11
interactive-onboarding blocks plus their ack-at-emit marker writes on
kind != spawned, and adds a destructive-gate carve-out to the spawned
block (conservative-continue, never prose-STOP).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-30 23:33:40 +00:00
co-authored by Claude Fable 5
parent 07b59e396c
commit 5486cd6620
5 changed files with 136 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/gstack-skill-start.test.ts
+55
View File
@@ -197,6 +197,61 @@ describe('gstack-skill-start behavior', () => {
}
});
test('spawned override suppresses CONDUCTOR_SESSION, emits SPAWNED_SESSION + block, gates onboarding (#2733)', () => {
const freshGh = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-ss-spawned-'));
fs.writeFileSync(path.join(freshGh, 'config.yaml'), 'update_check: false\n');
try {
const out = runStart([], {
GSTACK_SESSION_KIND: 'spawned',
CONDUCTOR_WORKSPACE_PATH: '/x',
GSTACK_HOME: freshGh,
});
expect(out).toMatch(/^SESSION_KIND: spawned$/m);
// spawned outranks Conductor: prose-to-nobody is always wrong.
expect(out).not.toContain('CONDUCTOR_SESSION: true');
expect(out).toMatch(/^SPAWNED_SESSION: true$/m);
// The ONLY instruction block a spawned session gets is spawned-session —
// none of the 11 interactive-onboarding blocks may emit (no human is
// watching; auto-answered prompts would write config nobody approved).
const ids = (out.match(/^GSTACK_INSTRUCTION_BEGIN: (\S+)/gm) ?? []).map(
(h) => h.replace(/^GSTACK_INSTRUCTION_BEGIN: /, ''),
);
expect(ids).toEqual(['spawned-session']);
// Script-side ack-at-emit markers stay UNWRITTEN, so the one-time
// prompts fire intact on the next human session.
expect(fs.existsSync(path.join(freshGh, '.activated'))).toBe(false);
expect(fs.existsSync(path.join(freshGh, '.first-loop-tip-shown'))).toBe(false);
expect(fs.existsSync(path.join(freshGh, '.completeness-intro-seen'))).toBe(false);
expect(fs.existsSync(path.join(freshGh, '.telemetry-prompted'))).toBe(false);
} finally {
fs.rmSync(freshGh, { recursive: true, force: true });
}
});
test('legacy OPENCLAW_SESSION still gets full spawned behavior through the kind-keyed gates', () => {
// Regression pin for the raw-marker → $_SESSION_KIND migration (#2733):
// OpenClaw sessions must behave exactly as before the re-keying.
const freshGh = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-ss-openclaw-'));
fs.writeFileSync(path.join(freshGh, 'config.yaml'), 'update_check: false\n');
try {
const out = runStart([], {
OPENCLAW_SESSION: '1',
CONDUCTOR_WORKSPACE_PATH: '/x',
GSTACK_HOME: freshGh,
});
expect(out).toMatch(/^SESSION_KIND: spawned$/m);
expect(out).not.toContain('CONDUCTOR_SESSION: true');
expect(out).toMatch(/^SPAWNED_SESSION: true$/m);
const ids = (out.match(/^GSTACK_INSTRUCTION_BEGIN: (\S+)/gm) ?? []).map(
(h) => h.replace(/^GSTACK_INSTRUCTION_BEGIN: /, ''),
);
expect(ids).toEqual(['spawned-session']);
expect(fs.existsSync(path.join(freshGh, '.activated'))).toBe(false);
} finally {
fs.rmSync(freshGh, { recursive: true, force: true });
}
});
test('display-only tips ack at emit and never re-fire (OV6)', () => {
const freshGh = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-ss-refire-'));
fs.writeFileSync(path.join(freshGh, 'config.yaml'), 'update_check: false\n');