diff --git a/review/SKILL.md.tmpl b/review/SKILL.md.tmpl index b748483a..7fb881d6 100644 --- a/review/SKILL.md.tmpl +++ b/review/SKILL.md.tmpl @@ -37,43 +37,10 @@ You are running the `/review` workflow. Analyze the current branch's diff agains --- -## Step 1.5: Scope Drift Detection - -Before reviewing code quality, check: **did they build what was requested — nothing more, nothing less?** - -1. Read `TODOS.md` (if it exists). Read PR description (`gh pr view --json body --jq .body 2>/dev/null || true`). - Read commit messages (`git log origin/..HEAD --oneline`). - **If no PR exists:** rely on commit messages and TODOS.md for stated intent — this is the common case since /review runs before /ship creates the PR. -2. Identify the **stated intent** — what was this branch supposed to accomplish? -3. Run `git diff origin/...HEAD --stat` and compare the files changed against the stated intent. +{{SCOPE_DRIFT}} {{PLAN_COMPLETION_AUDIT_REVIEW}} -4. Evaluate with skepticism (incorporating plan completion results if available): - - **SCOPE CREEP detection:** - - Files changed that are unrelated to the stated intent - - New features or refactors not mentioned in the plan - - "While I was in there..." changes that expand blast radius - - **MISSING REQUIREMENTS detection:** - - Requirements from TODOS.md/PR description not addressed in the diff - - Test coverage gaps for stated requirements - - Partial implementations (started but not finished) - -5. Output (before the main review begins): - ``` - Scope Check: [CLEAN / DRIFT DETECTED / REQUIREMENTS MISSING] - Intent: <1-line summary of what was requested> - Delivered: <1-line summary of what the diff actually does> - [If drift: list each out-of-scope change] - [If missing: list each unaddressed requirement] - ``` - -6. This is **INFORMATIONAL** — does not block the review. Proceed to Step 2. - ---- - ## Step 2: Read the checklist Read `.claude/skills/review/checklist.md`. diff --git a/ship/SKILL.md.tmpl b/ship/SKILL.md.tmpl index 993a67a5..a20e614a 100644 --- a/ship/SKILL.md.tmpl +++ b/ship/SKILL.md.tmpl @@ -232,6 +232,8 @@ If multiple suites need to run, run them sequentially (each needs a test lane). {{LEARNINGS_SEARCH}} +{{SCOPE_DRIFT}} + --- ## Step 3.5: Pre-Landing Review @@ -509,6 +511,10 @@ you missed it.> +## Scope Drift + + + ## Plan Completion