mirror of
https://github.com/garrytan/gstack.git
synced 2026-08-08 15:28:36 +02:00
test: cover gstack-gbrain-detect --is-ok + dev-skill render refresh
Fills the two automated-coverage gaps from the eng review: --is-ok exit-code gate (no-cli -> nonzero, healthy -> 0, plus an agrees-with-JSON no-skew check reusing the deterministic fake-gbrain harness) and a static tripwire that dev-skill re-renders the :user variant into the workspace render dir only when it already exists. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
1d2716e3b8
commit
551c972294
@@ -75,3 +75,17 @@ describe('.gitignore: render dir is declared untracked', () => {
|
|||||||
expect(read('.gitignore')).toContain('.claude/gstack-rendered/');
|
expect(read('.gitignore')).toContain('.claude/gstack-rendered/');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('dev-skill: refreshes the render on template change', () => {
|
||||||
|
const devSkill = read('scripts/dev-skill.ts');
|
||||||
|
|
||||||
|
test('re-renders the :user variant into the workspace render dir', () => {
|
||||||
|
expect(devSkill).toContain('gstack-rendered');
|
||||||
|
expect(devSkill).toContain('--out-dir');
|
||||||
|
expect(devSkill).toContain('--respect-detection');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('only refreshes when the render dir already exists (never creates it during plain dev)', () => {
|
||||||
|
expect(devSkill).toContain('fs.existsSync(RENDER_DIR)');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -16,7 +16,7 @@
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
import { describe, it, expect } from "bun:test";
|
import { describe, it, expect } from "bun:test";
|
||||||
import { execFileSync } from "child_process";
|
import { execFileSync, spawnSync } from "child_process";
|
||||||
import {
|
import {
|
||||||
mkdtempSync,
|
mkdtempSync,
|
||||||
mkdirSync,
|
mkdirSync,
|
||||||
@@ -47,6 +47,16 @@ function runDetect(env: Partial<NodeJS.ProcessEnv>): string {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Run detect with --is-ok and return its exit code (never throws). */
|
||||||
|
function runIsOk(env: Partial<NodeJS.ProcessEnv>): number {
|
||||||
|
const r = spawnSync(BUN_BIN, ["run", DETECT_BIN, "--is-ok"], {
|
||||||
|
timeout: 15_000,
|
||||||
|
stdio: ["ignore", "pipe", "pipe"],
|
||||||
|
env: { ...process.env, ...env },
|
||||||
|
});
|
||||||
|
return r.status ?? 1;
|
||||||
|
}
|
||||||
|
|
||||||
interface DetectShape {
|
interface DetectShape {
|
||||||
gbrain_on_path: boolean;
|
gbrain_on_path: boolean;
|
||||||
gbrain_version: string | null;
|
gbrain_version: string | null;
|
||||||
@@ -244,3 +254,66 @@ exit 0
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("bin/gstack-gbrain-detect --is-ok — live gate", () => {
|
||||||
|
it("exits non-zero when gbrain is not on PATH (no-cli)", () => {
|
||||||
|
const tmp = mkdtempSync(join(tmpdir(), "detect-isok-"));
|
||||||
|
try {
|
||||||
|
const code = runIsOk({
|
||||||
|
HOME: tmp,
|
||||||
|
PATH: "/usr/bin:/bin", // no gbrain
|
||||||
|
GSTACK_HOME: tmp,
|
||||||
|
GSTACK_DETECT_NO_CACHE: "1",
|
||||||
|
});
|
||||||
|
expect(code).not.toBe(0);
|
||||||
|
} finally {
|
||||||
|
rmSync(tmp, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it("exits 0 when a fake gbrain reports a healthy engine (ok)", () => {
|
||||||
|
const tmp = mkdtempSync(join(tmpdir(), "detect-isok-"));
|
||||||
|
const bindir = join(tmp, "bin");
|
||||||
|
const home = join(tmp, "home");
|
||||||
|
const configDir = join(home, ".gbrain");
|
||||||
|
try {
|
||||||
|
mkdirSync(bindir, { recursive: true });
|
||||||
|
mkdirSync(configDir, { recursive: true });
|
||||||
|
writeFileSync(join(configDir, "config.json"), JSON.stringify({ engine: "pglite" }));
|
||||||
|
const fake = `#!/bin/sh
|
||||||
|
case "$1 $2" in
|
||||||
|
"--version ") echo "gbrain 0.33.1.0"; exit 0 ;;
|
||||||
|
"sources list") echo '{"sources":[]}'; exit 0 ;;
|
||||||
|
"doctor "*) echo '{"status":"ok","checks":[]}'; exit 0 ;;
|
||||||
|
esac
|
||||||
|
exit 0
|
||||||
|
`;
|
||||||
|
const gbrainPath = join(bindir, "gbrain");
|
||||||
|
writeFileSync(gbrainPath, fake);
|
||||||
|
chmodSync(gbrainPath, 0o755);
|
||||||
|
|
||||||
|
const code = runIsOk({
|
||||||
|
HOME: home,
|
||||||
|
PATH: `${bindir}:/usr/bin:/bin`,
|
||||||
|
GSTACK_HOME: tmp,
|
||||||
|
GSTACK_DETECT_NO_CACHE: "1",
|
||||||
|
});
|
||||||
|
expect(code).toBe(0);
|
||||||
|
} finally {
|
||||||
|
rmSync(tmp, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it("exit code agrees with the JSON gbrain_local_status (no skew)", () => {
|
||||||
|
// Run both surfaces against the same env and assert they never disagree.
|
||||||
|
const tmp = mkdtempSync(join(tmpdir(), "detect-isok-"));
|
||||||
|
try {
|
||||||
|
const env = { HOME: tmp, PATH: "/usr/bin:/bin", GSTACK_HOME: tmp, GSTACK_DETECT_NO_CACHE: "1" };
|
||||||
|
const status = (JSON.parse(runDetect(env)) as DetectShape).gbrain_local_status;
|
||||||
|
const code = runIsOk(env);
|
||||||
|
expect(code === 0).toBe(status === "ok");
|
||||||
|
} finally {
|
||||||
|
rmSync(tmp, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user