CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-09 14:38:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: point ship design-checklist at installed gstack/review path

Browse Source 
The /ship Design Review step skipped the checklist because the generated path omitted the gstack/ install segment. Sync the generated skill doc and pin a regression assertion.

Co-authored-by: Cursor <cursoragent@cursor.com>
Wave-amended: goldens regenerated against the wave tree (author's golden commit 8e7a03ca superseded)
This commit is contained in:
Lockyer
2026-08-31 20:50:27 +00:00
committed by Garry Tan
co-authored by Cursor
parent 31f4d1b387
commit 567f06217a
5 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/fixtures/golden/codex-ship-SKILL.md
Vendored
+1 -1
View File
@@ -1718,7 +1718,7 @@ source <($GSTACK_BIN/gstack-diff-scope <base> 2>/dev/null)
1. **Check for DESIGN.md.** If `DESIGN.md` or `design-system.md` exists in the repo root, read it. All design findings are calibrated against it — patterns blessed in DESIGN.md are not flagged. If not found, use universal design principles.
2. **Read `.agents/skills/gstack/review/design-checklist.md`.** If the file cannot be read, skip design review with a note: "Design checklist not found — skipping design review."
2. **Read `$GSTACK_ROOT/review/design-checklist.md`.** If the file cannot be read, skip design review with a note: "Design checklist not found — skipping design review."
3. **Read each changed frontend file** (full file, not just diff hunks). Frontend files are identified by the patterns listed in the checklist.
test/fixtures/golden/factory-ship-SKILL.md
Vendored
+1 -1
View File
@@ -1725,7 +1725,7 @@ source <($GSTACK_BIN/gstack-diff-scope <base> 2>/dev/null)
1. **Check for DESIGN.md.** If `DESIGN.md` or `design-system.md` exists in the repo root, read it. All design findings are calibrated against it — patterns blessed in DESIGN.md are not flagged. If not found, use universal design principles.
2. **Read `.factory/skills/gstack/review/design-checklist.md`.** If the file cannot be read, skip design review with a note: "Design checklist not found — skipping design review."
2. **Read `$GSTACK_ROOT/review/design-checklist.md`.** If the file cannot be read, skip design review with a note: "Design checklist not found — skipping design review."
3. **Read each changed frontend file** (full file, not just diff hunks). Frontend files are identified by the patterns listed in the checklist.
test/gen-skill-docs.test.ts
+10
View File
@@ -1834,6 +1834,16 @@ describe('DESIGN_REVIEW_LITE extended with Codex', () => {
expect(content).toContain('SCOPE_FRONTEND');
});
test('design-checklist path uses installed gstack/review root (#2694)', () => {
// #2694: generateDesignReviewLite used to emit
// `.claude/skills/review/design-checklist.md` (missing the gstack/ segment).
// After install the file lives at ~/.claude/skills/gstack/review/design-checklist.md.
// The bad relative form must not appear — the good path does not contain it
// as a substring because `gstack/` sits between `skills/` and `review/`.
expect(content).toContain('~/.claude/skills/gstack/review/design-checklist.md');
expect(content).not.toContain('.claude/skills/review/design-checklist.md');
});
});
// ─── Codex Generation Tests ─────────────────────────────────