mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-07 17:28:23 +01:00
feat(diff-scope): template UI in .ts/.js counts as frontend; receipt records the static design pass (GST-1718) (#4112)
* feat(diff-scope): template UI in .ts/.js counts as frontend; receipt records the static design pass (GST-1718) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: regenerate ship goldens for the static design-review line (GST-1718) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes Review-Finding: p1/specialist-batched#1 reader=specialist Review-Finding: p1/red-team#1 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: count edits inside tagged templates and spaced template tags as frontend Review-Finding: v1/outside-voice#1 reader=outside-voice Review-Finding: v1/adversarial-native#1 reader=adversarial-native Review-Finding: v1/outside-voice#2 reader=outside-voice Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: one set comparison per template file instead of a grep per changed line Review-Finding: p2/red-team#2 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(changelog): GST-1718 fragment covers edits inside tagged templates Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(ship-policy): design record wording matches the in-template rule Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
40071a4237
commit
5862765a20
20 files changed
+273
-14
No files matched your search
+12
-2
@@ -1264,8 +1264,8 @@ written by the pr-body section of `/ship` after the body is composed.
|
||||
The ```` ```gstack-ship-receipt ```` block is the handoff record: identifiers
|
||||
first (`pr`, `head`, `version`, `base`), then the evidence (`gate`, `ci`,
|
||||
`head_tree`, `product_patch_id`, `gstack_version`, `review_depth`, `pregate`,
|
||||
`issues`, `approval`, `docs`, `review_loop`, `review_loop_exception`, `carry`,
|
||||
`no_stop`), validated
|
||||
`issues`, `approval`, `docs`, `review_loop`, `review_loop_exception`, `design`,
|
||||
`carry`, `no_stop`), validated
|
||||
against the `ship-receipt` schema (`gstack-artifact schema ship-receipt`) and
|
||||
read back by `gstack-ship-receipt read`, `result`, `carry` and the queue.
|
||||
|
||||
@@ -1281,6 +1281,16 @@ and `read`, `result`, `gstack-ship-queue ready`, `train build` and `verify
|
||||
but no version source records no `version` at all (the audit still says what
|
||||
it looked for); pass `--version` to name one.
|
||||
|
||||
**`design`.** On a rendered-UI diff (`gstack-diff-scope` reports
|
||||
`SCOPE_FRONTEND=true` for the committed range, which counts CSS, views,
|
||||
components and, since GST-1718, Lit or htm tagged templates in .ts/.js files
|
||||
whose changed lines sit inside a tagged template or carry markup), write records
|
||||
`{ "mode": "static", "reason": "no preview declared" }`: /ship ran only the
|
||||
static design-lite check, and the PR body's `## Design Review` line says the
|
||||
same. It is advisory and nothing refuses on it. Other diffs record no
|
||||
`design` field, and receipts written before it stay valid. A carry copies it
|
||||
unchanged.
|
||||
|
||||
**`docs`.** Step 14.5's outcome, from `gstack-ship-receipt write --docs
|
||||
<json|@file>`: `{ status: updated | current | blocked, scope, exception? }`,
|
||||
where `scope` names the docs roots the audit covered and `exception` is
|
||||
|
||||
Reference in new issue
Block a user