From 5dcd76b4eae6bb06f73460d3ab29cef8e33e8537 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 16 Nov 2026 22:40:56 +0800 Subject: [PATCH] Update hono to fix five security advisories (#4408) * Update hono to fix five security advisories (#4406) The weekly OSV scan flagged hono 4.13.13 with five advisories fixed in 4.13.16. hono comes in only through the dev toolchain (claude-agent-sdk, then the MCP SDK), so none was reachable. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * List hono among the dependency floors in the contributor guide The dependency security test now checks hono >= 4.13.16; the contributor guide's description of that test names it too. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- bun.lock | 4 ++-- changelog.d/update-hono-security-advisories.md | 7 +++++++ package.json | 2 +- test/dependency-security.test.ts | 2 +- 5 files changed, 12 insertions(+), 5 deletions(-) create mode 100644 changelog.d/update-hono-security-advisories.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4a189b6e9..2c60d858f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -432,7 +432,7 @@ eval files, and misses the strict classifier. No API keys needed. - **Catalog budget** (`test/catalog-budget.test.ts`) — Caps the aggregate discovery surface: the sum of every skill's frontmatter `name` + `description` (what every host loads at discovery, every session) must stay under 1,452 token-equivalents, with a 260-byte per-skill cap. Counting goes through the shared census in `test/helpers/skill-census.ts` (physical files vs authored skills vs registry entries — three deliberately different counts). Adding a skill? The failure message carries the re-measure + ratchet protocol. - **Context-budget ratchet** (`test/context-budget-ratchet.test.ts`) — CI ceilings on the two token ledgers the catalog budget doesn't cover: the always-on full-frontmatter aggregate and each skill's per-invocation eager tokens (SKILL.md + forced-read references), graded against `test/fixtures/context-budget.json` via `lib/context-bill.ts`. New skills fail until they have a ceiling; ceilings for removed skills must be pruned. Legitimate growth or a landed reduction: re-run `bun test/helpers/capture-context-budget.ts` and commit the refreshed fixture in the same commit, so the change is a visible decision in the diff. - **Skill-to-bin drift ratchet** (`test/skill-bin-drift.test.ts`) — `scripts/skill-bin-drift.ts` statically reads every gstack bin call in skill templates, carved sections, references and the Claude-host renders (it never executes a bin) and fails with `DRIFT_UNKNOWN_BIN` or `DRIFT_UNKNOWN_FLAG` at file:line when a skill names a bin missing from `bin/` or a flag that bin's parser does not accept. Known misses live in `test/fixtures/skill-bin-drift-allowlist.json`, which only shrinks: a new finding fails, and so does an entry that no longer reproduces. Check one skill with `bun run scripts/skill-bin-drift.ts --skill `; bins with permissive parsers or no usage text are reported, never failed. -- **Dependency security regressions** (`test/dependency-security.test.ts`) — Run `bun test test/dependency-security.test.ts` to check the resolved `sharp`, `adm-zip`, `qs` and `@hono/node-server` version floors, load Sharp, verify ordinary ZIP extraction, and reject extraction through destination-file and destination-directory symlinks. The symlink cases skip Windows. These checks complement the OSV scan; they do not change its existing exceptions. +- **Dependency security regressions** (`test/dependency-security.test.ts`) — Run `bun test test/dependency-security.test.ts` to check the resolved `sharp`, `adm-zip`, `qs`, `@hono/node-server` and `hono` version floors, load Sharp, verify ordinary ZIP extraction, and reject extraction through destination-file and destination-directory symlinks. The symlink cases skip Windows. These checks complement the OSV scan; they do not change its existing exceptions. ### Tier 2: E2E via `claude -p` diff --git a/bun.lock b/bun.lock index ceae42b77..bc276b4e8 100644 --- a/bun.lock +++ b/bun.lock @@ -35,7 +35,7 @@ "@modelcontextprotocol/sdk": "1.32.0", "adm-zip": "^0.6.1", "fast-uri": "3.1.9", - "hono": "4.13.13", + "hono": "4.13.16", "image-size": "2.0.4", "ip-address": "10.7.4", "proxy-addr": "2.0.8", @@ -359,7 +359,7 @@ "hasown": ["hasown@2.0.4", "", { "dependencies": { "function-bind": "^1.1.2" } }, "sha512-T2UbfbBEF32wiepXIsMlTW9+dDYC6wMh/t/vYA4tuOMKqWz/n3vr1NFSxQiyP+zk2mXsoMA/i/7qV6LKut1t1A=="], - "hono": ["hono@4.13.13", "", {}, "sha512-CQ46U0ZkAGmbT/4UxdzzGJpacP2IeKgY4a5/tOI9AABbpOMfK739wfDXmv1usCk+3RkKj1hQy4/fjhiwa2xlrA=="], + "hono": ["hono@4.13.16", "", {}, "sha512-AOLOEhvrV+iH92xXCnFr/5+3KjPKcI3xP63XJtX5spAnkznPdHijlIsUTpi7/9EhWqrTCekw5c5zh1K+YsVw7A=="], "html-entities": ["html-entities@2.6.0", "", {}, "sha512-kig+rMn/QOVRvr7c86gQ8lWXq+Hkv6CbAH1hLu+RG338StTpE8Z0b44SDVaqVu7HGKf27frdmUYEs9hTUX/cLQ=="], diff --git a/changelog.d/update-hono-security-advisories.md b/changelog.d/update-hono-security-advisories.md new file mode 100644 index 000000000..a360fb109 --- /dev/null +++ b/changelog.d/update-hono-security-advisories.md @@ -0,0 +1,7 @@ +--- +important: security +--- +**hono is pinned to 4.13.16, which fixes five advisories the weekly OSV scan found in 4.13.13 (gstack#4406).** The 2026-11-16 scan (run 43825448246) flagged GHSA-3gg2-335m-rxc6 (CVSS 3.4, the `css` helper) and GHSA-46wx-v44x-9hh2, GHSA-4h7h-rv7c-7m2v, GHSA-4m76-xfj5-7975 and GHSA-h7mg-cq63-vhpq (CVSS 5.3 each: `csrf()`, `validator('form')`, `mount()` and RegExpRouter wildcard middleware). hono reaches gstack only through the dev and test toolchain (`@anthropic-ai/claude-agent-sdk` pulls in `@modelcontextprotocol/sdk`), gstack's own code never imports it or starts a hono server, and none of the affected helpers is used, so no advisory was reachable. Contributor checkouts get the patched version on their next `bun install`. + +- **`package.json` overrides**: `hono` moves from 4.13.13 to 4.13.16, the release that fixes all five. `bun.lock` holds the one copy. +- `test/dependency-security.test.ts`: the lockfile floor check now covers `hono >= 4.13.16`. It fails on main. diff --git a/package.json b/package.json index 9056bddea..306cd7dda 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "@modelcontextprotocol/sdk": "1.32.0", "adm-zip": "^0.6.1", "fast-uri": "3.1.9", - "hono": "4.13.13", + "hono": "4.13.16", "image-size": "2.0.4", "ip-address": "10.7.4", "proxy-addr": "2.0.8", diff --git a/test/dependency-security.test.ts b/test/dependency-security.test.ts index d6a5e16dd..4b7a5d0f0 100644 --- a/test/dependency-security.test.ts +++ b/test/dependency-security.test.ts @@ -6,7 +6,7 @@ import AdmZip from "adm-zip"; import sharp from "sharp"; describe("security dependency overrides", () => { - for (const [name, minimum] of [["sharp", "0.35.4"], ["adm-zip", "0.6.1"], ["qs", "6.16.1"], ["@hono/node-server", "2.1.3"]]) { + for (const [name, minimum] of [["sharp", "0.35.4"], ["adm-zip", "0.6.1"], ["qs", "6.16.1"], ["@hono/node-server", "2.1.3"], ["hono", "4.13.16"]]) { test(`${name} resolves only versions at or above ${minimum}`, async () => { const lock = await Bun.file(join(import.meta.dir, "../bun.lock")).text(); const versions = [...lock.matchAll(new RegExp(`"${name}@([^"]+)"`, "g"))];