From 5ddd0efacbd381b5aa3d56a20f3335ef01456d9d Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 31 Oct 2026 12:33:17 +0000 Subject: [PATCH] fix: pre-landing review fixes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- lib/review-pass.ts | 4 ++-- test/ship-driver.test.ts | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/review-pass.ts b/lib/review-pass.ts index 421f2be1e..c11e87745 100644 --- a/lib/review-pass.ts +++ b/lib/review-pass.ts @@ -3,7 +3,7 @@ * * gstack-review-dispatch pass turns gstack-review-plan's dispatches into a manifest: stage `first` * (audit readers that may write tests, so they settle before any reviewer reads the tree), stage - * `specialists` (the specialists, plus the other audit and QA readers), stage `red-team` and stage + * `specialists` (the specialists, plus the other audit readers), stage `red-team` and stage * `voices` (Step 11). Each reviewer keeps its plan entry (role, effort, exclusions) and is rendered * once, when its inputs exist, by lib/review-brief.ts; the Red Team's findings file is the * specialists' merged.jsonl lines, byte for byte. Briefs travel to the dispatch program in bounded @@ -28,7 +28,7 @@ export interface PassReader { role?: BriefRole; name?: string; effort?: string; exclude?: string; checklists?: string[]; /** The targeted reader: the plan's TARGETED classes and the merge base it reads on every pass. */ classes?: string[]; diff_base?: string; - /** An audit or QA reader: its prompt is a file the parent wrote from its section; its output is returned, never collected. */ + /** An audit reader: its prompt is a file the parent wrote from its section; its output is returned, never collected. */ prompt_file?: string; model?: PassModel; file?: string; sha256?: string; bytes?: number; chunks?: number; findings_sha256?: string; path?: string; output?: string; error?: string; state_at?: string; diff --git a/test/ship-driver.test.ts b/test/ship-driver.test.ts index ae172bbd2..e24818297 100644 --- a/test/ship-driver.test.ts +++ b/test/ship-driver.test.ts @@ -227,7 +227,9 @@ describe('variant G: the call plan, observe budget, waits and audit readers (GST expect(phase(3)).not.toMatch(/QA reader/); expect(phase(3)).toContain("9.2.1's Reads only"); expect(phase(4)).toContain("9.2.1's probes, Steps 8.1 and 8.2"); - expect(phase(4).indexOf('9.2.1 probes')).toBeLessThan(phase(4).indexOf('Steps 9.3, 9.4 and the repeat decision')); + const probes = phase(4).indexOf("9.2.1's probes"); + expect(probes).toBeGreaterThanOrEqual(0); + expect(phase(4).indexOf('Steps 9.3, 9.4 and the repeat decision')).toBeGreaterThan(probes); expect(phase(4)).toContain('one program'); expect(f).toContain('the plan checks, `Exploratory QA:`, `Scope Check:`), **Decisions**'); const capy = flat(read('capy/skill/gstack/SKILL.md'));