mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-02 08:11:37 +02:00
v1.52.2.0 fix(make-pdf): render emoji instead of tofu (▯) on Linux (#1787)
* fix(make-pdf): emoji font fallback in print CSS Emoji code points rendered as .notdef tofu (▯) because the body and @top-center font stacks had no emoji family for Chromium to fall back to. Add SANS_STACK / CJK_STACK / EMOJI_FAMILIES constants (one source of truth per family list) and append the emoji families before the generic sans-serif in the two stacks that can hold emoji. The @bottom-* boxes hold counters / a fixed CONFIDENTIAL string, so they share SANS_STACK without emoji. Non-emoji output is byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(setup): auto-install color-emoji font on Linux macOS and Windows ship a color-emoji font; most Linux distros/containers ship none, so make-pdf emits tofu there. ensure_emoji_font() best-effort installs fonts-noto-color-emoji (apt, with dnf/pacman/apk fallbacks) and refreshes the fontconfig cache. Hardened: Linux-only guard, GSTACK_SKIP_FONTS escape hatch, fc-match color=True detection (the broad fc-list query false-matched LastResort), sudo -n so a password prompt fails fast instead of hanging, DEBIAN_FRONTEND=noninteractive, timeout 30 on apt update, and fc-cache under sudo. Warns instead of failing. After a fresh install, refresh_browse_daemon_for_fonts() runs 'browse stop' so the next render spawns a Chromium that sees the new font (font fallback is process-cached). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(make-pdf): emoji render gate (pdffonts + pixel proof) pdftotext is a false oracle for emoji: Skia preserves the Unicode in the text cluster even when the glyph drew as .notdef tofu, so extraction passes on a broken render. The gate instead asserts (1) pdffonts shows an emoji family embedded and (2) pdftoppm rasterizes the page to color (measured ~1650 saturated pixels vs ~0 for tofu). pdfimages is not used: macOS embeds color emoji as Type 3 fonts, so it lists nothing even on a correct render. Adds resolvePopplerTool() (DRY resolver, returns null for clean skips) and a fixture exercising FE0F variation-selector emoji. Skips cleanly when poppler tools or a color-emoji font are unavailable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci(make-pdf): install emoji font + run emoji gate on Ubuntu Install fonts-noto-color-emoji before Chromium launches on the Ubuntu leg (macOS already ships Apple Color Emoji), refresh fontconfig, and log the fc-match result. Run the whole make-pdf/test/e2e/ dir so the emoji gate runs alongside the combined-features copy-paste gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * harden(make-pdf): emoji gate + font install per adversarial review Codex adversarial pass on the implementation diff flagged five robustness gaps, all fixed here: - emoji-gate skipped green in CI when poppler/font prerequisites were absent, which could let the tofu regression ship behind a green build. Missing prerequisites are now a HARD FAILURE when process.env.CI is set; local dev still skips cleanly. - execFileSync children (make-pdf, pdffonts, pdftoppm, fc-match) had no timeout; a wedged binary or hostile GSTACK_*_BIN override could hang the job past Bun's test timeout. Each child now has a 25s ceiling. - PPM parser trusted header tokens blindly; malformed/variant output gave a silently-wrong count. Now validates magic/dimensions/maxval and pixel-buffer length, handles header comments, throws a hard diagnostic on mismatch. - predictable /tmp paths were collision/symlink-prone; now mkdtempSync under /tmp (kept under /tmp for browse's validateOutputPath allowlist). - only apt-get update was timeout-wrapped; dnf/pacman/apk installs and apt install can hang on locks/mirrors. All package installs now timeout-bound. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v1.52.2.0) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(make-pdf): document color-emoji font requirement + GSTACK_SKIP_FONTS Extend the Linux font note to cover the color-emoji font that make-pdf emoji rendering needs: setup auto-installs fonts-noto-color-emoji, the print CSS falls back through Apple/Segoe/Noto emoji families, and GSTACK_SKIP_FONTS=1 opts out. Edit the .tmpl and regenerate SKILL.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
@@ -261,6 +261,84 @@ ensure_playwright_browser() {
|
||||
fi
|
||||
}
|
||||
|
||||
# Ensure a color-emoji font is installed (Linux only).
|
||||
#
|
||||
# Chromium renders emoji code points as .notdef "tofu" (▯) when no color-emoji
|
||||
# font is installed. macOS ships "Apple Color Emoji" and Windows ships "Segoe UI
|
||||
# Emoji", so they're fine out of the box. Most Linux distros and containers ship
|
||||
# NO color-emoji font, which is why make-pdf output shows tofu in headers/tables
|
||||
# that contain emoji. Install Noto Color Emoji to fix it.
|
||||
#
|
||||
# Best-effort: warn (don't fail) if we can't install — PDFs still generate, they
|
||||
# just fall back to tofu for emoji as before. Skip entirely with
|
||||
# GSTACK_SKIP_FONTS=1 (CI without sudo, managed machines, offline envs).
|
||||
#
|
||||
# Returns 0 and sets EMOJI_FONT_INSTALLED=1 when it actually installs a font.
|
||||
EMOJI_FONT_INSTALLED=0
|
||||
ensure_emoji_font() {
|
||||
# macOS/Windows ship a color-emoji font; nothing to do.
|
||||
[ "$(uname -s)" = "Linux" ] || return 0
|
||||
[ "${GSTACK_SKIP_FONTS:-0}" = "1" ] && return 0
|
||||
|
||||
# Idempotency: a real COLOR emoji font that resolves for an actual emoji code
|
||||
# point (U+1F600). `fc-list :lang=und-zsye` is too broad — it matches symbol
|
||||
# and last-resort fallback fonts — so we use fc-match and require color=True.
|
||||
if command -v fc-match >/dev/null 2>&1; then
|
||||
if fc-match -f '%{family[0]}\t%{color}\n' ':lang=und-zsye:charset=1F600' 2>/dev/null | grep -qi 'True'; then
|
||||
return 0
|
||||
fi
|
||||
fi
|
||||
|
||||
local sudo=""
|
||||
if [ "$(id -u)" -ne 0 ] && command -v sudo >/dev/null 2>&1; then
|
||||
# -n: never prompt. If a password is required we fail fast into the
|
||||
# warn-not-fail path below instead of hanging a non-interactive setup.
|
||||
sudo="sudo -n"
|
||||
fi
|
||||
|
||||
# Every package-manager call is wrapped in `timeout` so a stuck dpkg/rpm lock
|
||||
# or a wedged mirror fails fast into the warn path instead of hanging setup.
|
||||
if command -v apt-get >/dev/null 2>&1; then
|
||||
echo "Installing color-emoji font (fonts-noto-color-emoji) so make-pdf emoji render (set GSTACK_SKIP_FONTS=1 to skip)..."
|
||||
DEBIAN_FRONTEND=noninteractive timeout 30 $sudo apt-get update -qq >/dev/null 2>&1 || true
|
||||
DEBIAN_FRONTEND=noninteractive timeout 120 $sudo apt-get install -y -qq fonts-noto-color-emoji >/dev/null 2>&1 || return 1
|
||||
elif command -v dnf >/dev/null 2>&1; then
|
||||
echo "Installing color-emoji font (google-noto-color-emoji-fonts)..."
|
||||
timeout 120 $sudo dnf install -y google-noto-color-emoji-fonts >/dev/null 2>&1 || return 1
|
||||
elif command -v pacman >/dev/null 2>&1; then
|
||||
echo "Installing color-emoji font (noto-fonts-emoji)..."
|
||||
timeout 120 $sudo pacman -Sy --noconfirm noto-fonts-emoji >/dev/null 2>&1 || return 1
|
||||
elif command -v apk >/dev/null 2>&1; then
|
||||
echo "Installing color-emoji font (font-noto-emoji)..."
|
||||
timeout 120 $sudo apk add --no-cache font-noto-emoji >/dev/null 2>&1 || return 1
|
||||
else
|
||||
return 1
|
||||
fi
|
||||
|
||||
# Refresh fontconfig cache so Chromium picks up the new font. Run under sudo
|
||||
# for the system cache dirs (unprivileged fc-cache fails on unwritable dirs).
|
||||
if command -v fc-cache >/dev/null 2>&1; then
|
||||
$sudo fc-cache -f >/dev/null 2>&1 || fc-cache -f >/dev/null 2>&1 || true
|
||||
fi
|
||||
EMOJI_FONT_INSTALLED=1
|
||||
return 0
|
||||
}
|
||||
|
||||
# After a fresh font install, stop any running browse render daemon so the next
|
||||
# make-pdf render spawns a fresh Chromium that sees the new font. Chromium
|
||||
# caches its font list at process start, so a daemon that was alive before the
|
||||
# install would keep emitting tofu. `browse stop` is the graceful API; the
|
||||
# daemon auto-respawns on the next render. Best-effort and per-project-root, so
|
||||
# we also print a note for daemons in other roots.
|
||||
refresh_browse_daemon_for_fonts() {
|
||||
[ "$EMOJI_FONT_INSTALLED" -eq 1 ] || return 0
|
||||
if [ -x "$BROWSE_BIN" ]; then
|
||||
"$BROWSE_BIN" stop >/dev/null 2>&1 || true
|
||||
fi
|
||||
echo " Installed a color-emoji font. The next make-pdf render will show emoji."
|
||||
echo " If a gstack browser is running in another project, restart it to pick up the font."
|
||||
}
|
||||
|
||||
prepare_bun_for_windows_compile() {
|
||||
BUN_CMD="bun"
|
||||
BUN_CMD_WAS_COPIED=0
|
||||
@@ -433,6 +511,19 @@ if ! ensure_playwright_browser; then
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# 2b. Ensure a color-emoji font is installed so make-pdf emoji render (Linux).
|
||||
# Best-effort: warn instead of failing if it can't install.
|
||||
if ! ensure_emoji_font; then
|
||||
echo " Note: could not auto-install a color-emoji font. Emoji in make-pdf" >&2
|
||||
echo " output may render as boxes (▯). Install one manually, e.g.:" >&2
|
||||
echo " Debian/Ubuntu: sudo apt-get install fonts-noto-color-emoji" >&2
|
||||
echo " Fedora: sudo dnf install google-noto-color-emoji-fonts" >&2
|
||||
echo " Arch: sudo pacman -S noto-fonts-emoji" >&2
|
||||
echo " Alpine: sudo apk add font-noto-emoji" >&2
|
||||
else
|
||||
refresh_browse_daemon_for_fonts
|
||||
fi
|
||||
|
||||
# 3. Ensure ~/.gstack global state directory exists
|
||||
mkdir -p "$HOME/.gstack/projects"
|
||||
|
||||
|
||||
Reference in New Issue
Block a user