mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-26 22:51:47 +02:00
v1.87.6.0 fix: make checks reliable and everyday validation faster (#2898)
* fix: acknowledge seeded plans before invoking review skills * fix: distinguish current plan input from conversation history * fix: keep hermetic plan reviews on manual permissions * fix: distinguish tool discovery from file permission ownership * fix: preserve initial plan mode in observation tests * fix: wait for scope decisions before writing review findings * fix: carry autoplan decisions consistently into review artifacts * test: retain native failure context in periodic assertions * fix: advance active file permissions before queued questions * fix: finish red-team attempts before retry and cleanup * fix: finalize plan format captures and judges before retry * fix: cancel setup-gbrain SDK attempts before fixture cleanup * test: select periodic consumers of the bounded attempt helper * fix native Bash permission cards and queued questions * fix: preserve independent decisions and review scope Keep CEO approach, engineering scope and outside-review choices from approving independent remedies together. Carry declared contracts through DX polish and resolve new gaps before editing the plan. Regenerate every host and retain existing stop boundaries. Validation: 654 focused tests passed across nine files; all-host generation passed. Full free and periodic validation pending. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: require approval before design plan amendments Align the Design review philosophy and rating recipe with its section protocol: resolve one proposed fix, then apply only that approved decision and retain honest scores for declined fixes. Validation: 469 focused tests passed across four files; all-host generation passed. Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: observe native question completion before transcript persistence Match owned completion hooks to submitted choices, reject conflicting or late answers, and retain bounded failure evidence. * test: recognize review posture in acknowledged native questions Require the selected mode acknowledgement, a completed follow-up question, and its current decoded display while preserving existing posture assertions. * fix: preserve settled CEO choices and isolate pending remedies Resolve established approach gates with cited authority and keep independent fixes out of unrelated option commitments and plan amendments. * fix: carry approved DX choices through later review steps Choose documentation approaches within the accepted scope and map resolved confusion points without reopening them through a bulk menu. * test: handle native settings-file edit prompts Keep one-time owned-file approvals and retain the actual sampled Autoplan permission frame with its matching barrier state. * test: accept standard CEO reply directives with tuning footers Recognize the exact trailing preference footer and letter-list directive while preserving current-display and exact acknowledgement checks. * test: scope split reviewers to their generated plan artifacts * test: observe native Bash permissions and invocation results * test: handle owned Bash prompts during mode preference checks * test: preserve synchronous subprocess rejection in Codex fixture * Fix periodic review handoff navigation Recognize review-first and explicit manual-next-step labels while preserving exact action families, manual preference, and ambiguous-menu rejection. Co-authored-by: OpenAI Codex <noreply@openai.com> * Bind pending file permissions to distinct current targets Allow one captured file request to own the complete current dialog while unrelated file work is pending. Preserve same-path ambiguity, exact input ownership, and one-time grant checks. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make paired CEO verification choices genuinely unresolved Start the positive control with proposed manual checks so its unchanged oracle measures two new coverage decisions. Preserve runtime contracts, targets, count bounds, and all assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO review options and verification within approved scope Audit every offered option for independent add-ons and keep new verification depth pending until accepted. Preserve already requested coverage and trace plan changes to the actual decision. Co-authored-by: OpenAI Codex <noreply@openai.com> * Assemble DX review artifacts before appending the final report Keep early DX evidence above decisions, update artifact sections in place, and append the report using the actual current file suffix. Re-read after deleting an existing report before choosing the append anchor. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep outside plan reviews exclusive and invocation-owned Follow one preflight-selected backend, terminate failed Codex work before fallback, and allocate extra prompt/output files uniquely. Consume only the current invocation’s completed output. Co-authored-by: OpenAI Codex <noreply@openai.com> * Select periodic completion evaluations for report writer changes Register the shared review resolver for eight missing consumers and regress selection for all nine completion cases without changing their IDs or tiers. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep permission ambiguity fixtures on the same normalized target Use distinct raw spellings of one target in the four negative fixtures so they exercise the normalized duplicate-owner guard after exact current-file disambiguation. Preserve the existing exception, no-input, diagnostic and cleanup assertions. Co-authored-by: OpenAI Codex <noreply@openai.com> * Clarify preserved contracts in engineering review fixture Co-authored-by: OpenAI Codex <noreply@openai.com> * Recognize the offered DX follow-up handoff Co-authored-by: OpenAI Codex <noreply@openai.com> * Check independent commitments before presenting review options Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep Codex review output and status in one shell invocation Co-authored-by: OpenAI Codex <noreply@openai.com> * Distinguish seeded plans from reports written by a test attempt Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Autoplan file approvals with bounded viewport resizing Co-authored-by: OpenAI Codex <noreply@openai.com> * Recover clipped Bash approvals before binding the complete command Co-authored-by: OpenAI Codex <noreply@openai.com> * Isolate setup message tests from the shared checkout Run the real installer in a temporary payload with private config, require successful completion, and guard source and binary contents and mtimes. Co-authored-by: OpenAI Codex <noreply@openai.com> * Fix periodic native permission and report completion handling Match the pinned CLI's soft wraps and clipped headings without granting from incomplete frames. Retire completed file requests, retain mode annotations, and ask section captures for a short final acknowledgement after their full report is saved. Co-authored-by: OpenAI Codex <noreply@openai.com> * Preserve review approvals and validate DX comparison artifacts Keep independent remedies and approved amendments explicit. Give the synthetic DX review its existing documentation and validate peer comparison as required analysis alongside four native decisions. Add positive and negative semantic calibrations while preserving review counts, model budgets and prompt size limits. Co-authored-by: OpenAI Codex <noreply@openai.com> * Make the five-finding CEO fixture's application boundary explicit Materialize the request adapter and service composition used by the synthetic payment application. Explicitly declare the revised unregistered-event and mail-telemetry assumptions while preserving uncaught handler errors, the original invoice path and all five unresolved findings. Co-authored-by: OpenAI Codex <noreply@openai.com> * Keep CEO state-path checks scoped to directory preparation Co-authored-by: OpenAI Codex <noreply@openai.com> * Use checked ports and bounded cleanup in pair-agent tests Discover the daemon port from its owned state file, retain startup diagnostics, and await failed-start cleanup. Add occupied-port, early-exit, deadline, and foreign-state regressions while preserving the existing HTTP assertions and hook budgets. Co-authored-by: Codex <noreply@openai.com> * Preserve queued edit identity and recover clipped Bash permissions Distinguish separately queued unfinished edits from mutation of one native tool ID. Keep grants bound to an exact owned request and reject reused IDs, ambiguous inputs, and competing owners. Support the pinned renderer's literal em dash and request a repaint when only the Bash card's top rule is clipped. Grants still require the complete fresh card and an exact native acknowledgment. Validation: 413 integrated parser/event tests passed; private repaint controls and joint source review passed. Full canonical suite and native periodic rerun remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep periodic reviews within their approved contracts and deliverables Carry exact approvals through engineering review, preserve declared contracts when amending CEO plans, and keep prioritization at the requested decision level. Materialize the revised synthetic SDK reference contract while retaining the five original documentation gaps. Accept the observed semicolon in the finite DX handoff menu and register the direct source dependencies used by the engineering cases. Regenerate canonical review documents without changing model budgets, retries, count bands, or native completion assertions. Validation: all-host generation and 275 review, fixture, selection and parity tests passed. Full free-suite and native periodic validation remain pending. Co-authored-by: Codex <noreply@openai.com> * Keep Eng approval cadence and independence guards explicit * Accept ordinary punctuation in manual review handoffs * Recover file permissions alongside queued Bash calls * Carry approved DX work through later review findings * Clarify the synthetic auth internal failure decision * Bound the periodic DX fixture to onboarding changes * Recognize native Design review handoff labels * Hold scope in the integration-choice review fixture * Carry approved Design decisions through review evidence * Capture listener state when feedback reload fails * Exclude workspace caches before checking deprecated flags * Verify Design UI scope against a seeded review plan * Clarify plan review decisions and outside-voice approval flow * Reject setup menus in the Design UI gate * docs: require focused repair validation before final acceptance * fix: separate review commitments within existing prompt budgets * docs: align generation and contributor validation guidance * fix: advance native review prompts and count acknowledged findings * chore: bump version and changelog (v1.87.1.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * chore: enforce cheap checks and side-effect-free validation previews * fix: handle owned Fetch permissions and oversized native cards * test: ground review fixtures in independent executable contracts * fix: preserve review decisions and verify reports before completion * test: construct the synthetic credential URL without a scanner false positive * test: materialize DX examples and verify their actual local behavior * fix: clarify CEO review decisions and execution order * fix: clarify review workflow ordering and select Design quality checks * Fix review decision gates and incomplete evaluation fixtures Persist CEO and engineering commitment ledgers before menus, preserve exact approvals, and distinguish implementation structure from feature scope. Route Autoplan through the canonical CEO Step 0 ordering. Classify DX findings before requesting approval and ground runtime claims in actual evidence. Complete neutral non-target fixture contracts and accept the captured Design handoff purpose without relaxing its ownership or acknowledgment checks. Record runtime-capability verification in AGENTS.md validation discipline. Validation: 1,335 focused tests passed across 21 files; build, all-host freshness, skill validation (647 artifacts / 107 tracked), and credential checks passed. Prior paid failures are preserved; behavioral acceptance remains pending. * Fix review decision boundaries and owned Read prompts Preserve exact approvals across review options, compare consistent DX milestones, and keep proposed implementation separate from review evidence. Bind modern Read prompts to one immutable native request and wait for its result. Retain captured regression verdicts, correct fixture error names, improve import probe diagnostics, and record focused-first validation discipline in AGENTS.md. * Clarify CEO and engineering review decisions Use explicit decision steps, one engineering ledger, and clear scope/write transitions. Preserve exact approvals and distinguish pending test requirements. Keep unrelated generated content unchanged. * Fix review decision ordering and native evaluation interactions * Clarify engineering decisions and test artifact order * Clarify pending choices and approvals in CEO reviews * Make CEO review phases sequential and clarify completion * Fix Design board submission intent matching * Seed an existing browser test baseline for Autoplan * Document decision-log payloads before state initialization * Preserve exact review scope and decide one change before drafting options * Require input identity before repeating passing model judges * Honor permitted storage throughout CEO review completion * Match complete native permission text within the pinned renderer contract * Align review approvals, independent choices, and bounded validation * fix: preserve reopened approvals and declare fixture interfaces * fix: isolate review artifacts and audit complete questions * fix: match detector artifact permissions to configured storage * fix: complete native permissions and review fixture workflows * fix: order CEO review work and separate engineering guarantees * fix: preserve native validation and separate review choices * fix: clarify review decisions and judge complete report context * fix: constrain review judgments and retain parse failures * fix: compare each affected value before review decisions * fix: make engineering review decisions and completion order explicit * fix: give the complete Autoplan evaluation a bounded chain budget * fix(cso): diagnose forbidden Docker endpoints before tool lookup * fix(reviews): reconcile workflow contracts and generated artifacts after main integration * fix(evals): migrate retained regressions to the native review harness * fix(tests): close native harness and workflow integration regressions * fix(evals): preserve complete permission context and native menu contracts * fix(tests): capture synchronous command output without pipe drain stalls * fix(reviews): clarify decision and completion ordering * fix(reviews): separate decision readiness from final completion checks * refactor(reviews): consolidate decision rules and completion branches * fix(plan-eng-review): order preparation and clarify decision routing * fix(plan-eng-review): restore size and question-format guard parity * fix(plan-eng-review): clarify scope phases and blocked completion * fix(plan-eng-review): unify review flow and report destination * fix(plan-eng-review): define bootstrap and question stage ownership * fix(plan-eng-review): clarify review structure and design lookup * fix(plan-eng-review): render report examples and show saved decisions * fix: consolidate Eng review decisions and select their evaluations * test: cover overlapping terminal attachments and clean merged runner type * fix: preserve Office Hours relationship closings during review updates * fix: retain pasted review targets across slash invocations * docs: preserve validation traces and correct release scope * test: cover pasted targets in both review skills * fix: validate report artifacts before recording success * fix: redact source roots at CSO report boundaries * fix: bind native Design questions before answering * test: select report privacy and native recovery regressions * test: bind rejection predicate in extracted observers * fix: bind complete boxed native questions * test: keep the Design UI fixture on native review * fix: preserve review decisions and evaluation completion outcomes * fix: clarify CEO approval and report completion order * fix: align native review evaluation ownership and completion * fix: bind review evaluators to native decisions and owned artifacts * fix: validate review decisions against native outcomes * fix: preserve review evidence and Autoplan phase handoffs * test: bind review evidence to owned decisions and completion * fix: retain owned native history across compaction * fix(evals): validate current review decisions and setup choices * fix: bind Autoplan reviews and phase completion to current amended input * fix: reconcile native review evidence and close Autoplan phases * test: recognize owned whole-candidate complexity decisions * test: preserve report freshness for approved investigation handoffs * fix: recognize scoped review findings and isolate dual voice fixtures * fix: make review handoffs and question dispatch self-contained * test: recognize complete CEO decisions and procedural pauses * fix: bind current CEO comparison options and risk intervals * test: bind engineering decisions and completion to owned evidence * fix: publish Autoplan phase reports before continuing tools * test: verify actual Autoplan dual-review dispatch evidence * test: select dual review when shared evidence fixtures change * fix: clarify plan review decisions and completion gates * fix: make CEO review decisions and return paths explicit * test: keep Autoplan prompt files inside attempt state * test: preserve source whitespace across permission dialog wraps * fix: publish Autoplan phase reports before continuing * test: recognize current CEO comparisons and reject inactive records * fix: reconcile engineering decision states before completion * test: recognize complete Design decisions and reports * test: verify current engineering decisions before navigation * Recognize source-owned component reduction choices * fix: recognize current CEO ledger and commitment grids * test: supply RequestPolicy context to Eng count fixture * fix: save complete engineering decisions before asking * fix: bind Autoplan publication to the complete phase readback * chore: prepare 1.87.5.0 reliability release * fix: clarify engineering review completion and preserve log failures * fix: bind CEO saved choices and current section ancestry * fix(evals): bind review execution and completion evidence * fix(plan-ceo-review): verify complete decisions before asking * fix(evals): preserve complete engineering choice records * fix(evals): preserve complete review outcomes and bounded fixtures * fix(autoplan): publish phase reports before advancing * fix(plan-ceo-review): validate option fields before asking * fix(plan-eng-review): verify current decisions after answers * fix(evals): bind review decisions and bound fixture scope * fix(plan-ceo-review): verify decision rows and edit saved checkpoints * fix(evals): bind review evidence and scope document lookup * fix(plan-eng-review): update resolution state with its answer * fix(reviews): preserve complete questions through dispatch * fix(evals): recognize completed mode declarations * fix(evals): define cache consistency at wrapper completion * fix(evals): validate owned initial scope and completed review handoffs * fix: assemble complete CEO decision fields before saving * fix: authenticate automatic mode decisions without guessing selectors * fix: bind engineering coverage to approved regression contracts * fix(evals): supply review helpers to native Eng capture * fix(plan-eng-review): preserve the full selected option scope * fix(evals): recognize owned engineering seed and regression evidence * fix(evals): bind engineering retry reports to native approvals * docs: clarify release guarantees (v1.87.5.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix(evals): recognize owned engineering decisions and handoffs * fix(evals): bind engineering decisions and completion evidence * fix(tests): align review contracts and selection fixtures * fix(skills): restore review prompt size limits * fix(plan-eng-review): clarify review execution and completion * fix(evals): preserve configured retries through all supervision layers * Clarify Engineering decisions and report completion * Keep native decision assertions within their source boundary * fix: recognize owned engineering decisions and completed navigation * fix: bind completed auto decisions to their current review * fix: recognize explicit CEO source attribution * fix: dispatch verified CEO decisions without recomposing fields * test: expose existing execution deadlines to review actors * fix: distinguish CEO decision records from incidental headings * test: bind split-scope choices to the registered native actor * test: connect reviewed regressions to required evaluation coverage * Clarify CEO decision routing and completion stages * test: expose existing section review deadlines to fixture actors * test: recognize complete native CEO pacing inventories * test: exclude answered history from current CEO payloads * test: detect phase entry through owned skill HOME aliases * test: validate native review completion and owned report permissions * fix: make Autoplan close packets carry the parent handoff steps * test: assess source-bound HOLD decisions within the existing deadline * fix: keep CEO native decision fields under one formatting authority * test: register integrated review and permission dependencies * test: align native review adapters and finding coverage Preserve explicit AUTO decisions, apply native single-select defaults, and bind complete cropped questions and report permissions to their owned requests. Require seeded review findings instead of crediting setup menus. Keep captured failure controls and additive selection dependencies. The integrated candidate passed 3,099 focused tests across 65 files; affected paid validation remains required before publication. * fix(autoplan): require phase reports before advancing * fix(evals): bind setup and evidence to complete attempts * fix(evals): bind native answers and pending writes to fixture scope Preserve complete option rows when native descriptions wrap, retain current owned Write arguments before journal publication, and keep engineering and DX answers within their declared fixture interfaces. Add captured free regressions without increasing model budgets or relaxing completion checks. * fix(autoplan): verify phase reports across native tool paths Guard owned methodology reads and reviewer dispatches, detect complete driver loads through Bash, and distinguish report-only edits from implementation changes. Follow authenticated native UUID ancestry when journal writes arrive out of order and verify earlier native content for cached phase reads. Keep current close acknowledgment and parent publication in order, require CEO entry before later phases, and register captured failure regressions. * fix(evals): honor native input and collection lifecycles Match complete native Edit panes and truncated question borders, reject stderr close before EOF, and stop the CEO split fixture once its acknowledged scope decisions are collected. Keep semantic validation, process failures, report requirements, and absolute deadlines authoritative. Add captured-event and real-process regressions with selection dependencies. Focused checks pass; final integrated paid and full-suite acceptance remain pending. * fix(autoplan): retain native session ownership across directory changes Recover missed native UUID ancestry through the existing strict graph while preserving ordinary event order and legacy scoping. Bind publication hooks to Claude's original project directory while retaining current cwd for requested file paths. Captured public-event regressions, existing caller checks, and a pinned native CLI loopback verify both fixes. Preserve failed attempts and require fresh paid and final full-suite acceptance. * docs: align evaluation limits and completion version * fix(autoplan): allow authenticated phase reads during journal streaming * fix(evals): bind clipped native questions and owned edit dialogs * fix: preserve overlay retries and bounded cleanup * fix: recognize owned planning preludes in native questions * docs: explain overlay scheduling and cleanup guarantees * fix: require fresh publication after Autoplan phase reruns * Release gstack 1.87.6 * fix: preserve CI paths, process identity, and test deadlines * fix: keep informational setup commands independent of install probes * fix: clarify plan review decisions and bound source audit reports * Fix remaining Windows identity and native path CI failures * Clarify CEO review decision and reviewer-result routing * test: accept no-install planner in retry supervision * fix(ceo-review): make review decisions and report completion explicit * perf(test): add fast PR gates, input-keyed judge reuse and isolated free shards * fix(test): start isolated CEO smoke from its existing project plan * fix(test): repair CI fixture races and preserve retry evidence * fix(ceo-review): clarify approvals, depth and saved completion --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This commit is contained in:
Garry Tan
co-authored by
OpenAI Codex
OpenAI Codex
parent
35dd014c58
commit
636175d349
@@ -1,3 +1,4 @@
|
||||
import lifetimeFixture from './fixtures/ceo-fill-lifetime.json';
|
||||
import { describe, expect, test } from 'bun:test';
|
||||
import {
|
||||
CACHE_READ_WRITE_SKETCH,
|
||||
@@ -118,6 +119,192 @@ describe('pre-write snapshot vocabulary in the actual U finding', () => {
|
||||
});
|
||||
|
||||
describe('CEO section-loading cache fixture', () => {
|
||||
test.each([
|
||||
{ retires: false, rejects: false },
|
||||
{ retires: true, rejects: false },
|
||||
{ retires: true, rejects: true },
|
||||
])('cohort admission is distinct from the actual wrapper fill: %j', async ({ retires, rejects }) => {
|
||||
const pending: Array<{ value: string; finish: () => void }> = [];
|
||||
const flights = new Map<string, Promise<string>>();
|
||||
let stored = 'old';
|
||||
const failure = new Error('rolled back');
|
||||
const repository = {
|
||||
read(key: string) {
|
||||
if (flights.has(key)) return flights.get(key)!;
|
||||
const value = stored;
|
||||
let finish!: () => void;
|
||||
const flight = new Promise<string>(resolve => { finish = () => resolve(value); })
|
||||
.finally(() => { if (flights.get(key) === flight) flights.delete(key); });
|
||||
pending.push({ value, finish }); flights.set(key, flight);
|
||||
return flight;
|
||||
},
|
||||
async write(key: string, value: string) {
|
||||
if (rejects) throw failure;
|
||||
stored = value;
|
||||
if (retires) flights.delete(key);
|
||||
return value;
|
||||
},
|
||||
};
|
||||
const cache = new Map<string, string>();
|
||||
const { readProfile, writeProfile } = new Function('cache', 'repository',
|
||||
CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(cache, repository);
|
||||
const earlier = readProfile('tenant:profile');
|
||||
if (rejects) await expect(writeProfile('tenant:profile', 'new')).rejects.toBe(failure);
|
||||
else await writeProfile('tenant:profile', 'new');
|
||||
const later = readProfile('tenant:profile');
|
||||
expect(pending).toHaveLength(retires && !rejects ? 2 : 1);
|
||||
if (retires && !rejects) {
|
||||
pending[1]!.finish();
|
||||
expect(await later).toBe('new');
|
||||
}
|
||||
pending[0]!.finish();
|
||||
expect(await earlier).toBe('old');
|
||||
if (!retires || rejects) expect(await later).toBe('old');
|
||||
// Even correct repository admission cannot stop this exact new sketch
|
||||
// from caching its older result after the committed write. Keep that gap.
|
||||
expect(await readProfile('tenant:profile')).toBe('old');
|
||||
expect(stored).toBe(rejects ? 'old' : 'new');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('single-flight wrapper sits inside\n repository.read');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('A committed repository.write retires');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('This admission rule does not inspect cache fills');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain(CACHE_READ_WRITE_SKETCH);
|
||||
expect(hasStaleFillRaceFinding(CEO_SECTION_CACHE_PLAN)).toBe(false);
|
||||
});
|
||||
|
||||
test('author bounds implementation depth without preapproving the wrapper or weakening required proof', () => {
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('wrapper itself remains unapproved');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('actual\ncontradiction or missing proof must be reported and resolved');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('exact data\nstructures, full function bodies and executable test code belong to subsequent\nengineering planning');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('not tests already\nimplemented or passing');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('Preserve all 11 review outcomes');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('full GSTACK REVIEW REPORT');
|
||||
});
|
||||
|
||||
test('declared absence decoding and atomic write failure do not add independent wrapper defects', async () => {
|
||||
const missing = Object.freeze({ found: false });
|
||||
const absent = Symbol('adapter-private absence');
|
||||
const stored = new Map<string, unknown>();
|
||||
const cache = {
|
||||
get: (key: string) => stored.get(key) === absent ? missing : stored.get(key),
|
||||
set: (key: string, value: unknown) => stored.set(key, value === missing ? absent : value),
|
||||
delete: (key: string) => stored.delete(key),
|
||||
};
|
||||
const rejected = new Error('atomic write rejected before commit');
|
||||
let reads = 0;
|
||||
const repository = {
|
||||
read: async () => { reads++; return missing; },
|
||||
write: async () => { throw rejected; },
|
||||
};
|
||||
const { readProfile, writeProfile } = new Function('cache', 'repository',
|
||||
CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(cache, repository);
|
||||
expect(await readProfile('tenant:missing')).toBe(missing);
|
||||
expect(stored.get('tenant:missing')).toBe(absent);
|
||||
expect(await readProfile('tenant:missing')).toBe(missing);
|
||||
expect(reads).toBe(1);
|
||||
await expect(writeProfile('tenant:missing', { found: true })).rejects.toBe(rejected);
|
||||
expect(await readProfile('tenant:missing')).toBe(missing);
|
||||
expect(reads).toBe(1);
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('every\n rejected promise guarantees no commit');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('cache.get decodes it back to the same absent-result DTO');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('cannot fill the new one');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('does not coordinate\nan ordinary DB write');
|
||||
});
|
||||
|
||||
test.each([false, true])('rollout publication fences admitted old writes: %s', async (fenceWrites) => {
|
||||
let stored = 'old';
|
||||
let releaseWrite!: () => void;
|
||||
const gate = new Promise<void>(resolve => { releaseWrite = resolve; });
|
||||
const repository = {
|
||||
read: async () => stored,
|
||||
write: async (_key: string, value: string) => { await gate; stored = value; return value; },
|
||||
};
|
||||
const instance = () => new Function('cache', 'repository',
|
||||
CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(new Map(), repository);
|
||||
const old = instance();
|
||||
const writing = old.writeProfile('tenant:profile', 'new');
|
||||
let published = false;
|
||||
const publish = async () => {
|
||||
if (fenceWrites) await writing;
|
||||
published = true;
|
||||
return instance();
|
||||
};
|
||||
const publishing = publish();
|
||||
await Promise.resolve();
|
||||
expect(published).toBe(!fenceWrites);
|
||||
if (!fenceWrites) {
|
||||
const next = await publishing;
|
||||
expect(await next.readProfile('tenant:profile')).toBe('old');
|
||||
releaseWrite(); await writing;
|
||||
// The initial isolation-only contract still permits a stale new cache.
|
||||
expect(await next.readProfile('tenant:profile')).toBe('old');
|
||||
} else {
|
||||
releaseWrite(); await writing;
|
||||
const next = await publishing;
|
||||
expect(await next.readProfile('tenant:profile')).toBe('new');
|
||||
}
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('awaits every admitted old-instance write');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('fresh single-flight cohort before admitting new work');
|
||||
});
|
||||
|
||||
test('an internal store commit still overlaps the unfinished public wrapper write', async () => {
|
||||
let stored = 'old';
|
||||
let commitWrite!: () => void;
|
||||
let wrapperReturned = false;
|
||||
const cache = new Map([['tenant:profile', 'old']]);
|
||||
const repository = {
|
||||
read: async () => stored,
|
||||
write: () => new Promise<string>(resolve => {
|
||||
commitWrite = () => { stored = 'new'; resolve('new'); };
|
||||
}),
|
||||
};
|
||||
const { readProfile, writeProfile } = new Function('cache', 'repository',
|
||||
CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(cache, repository);
|
||||
const writing = writeProfile('tenant:profile', 'new').then((value: string) => {
|
||||
wrapperReturned = true;
|
||||
return value;
|
||||
});
|
||||
commitWrite();
|
||||
expect(stored).toBe('new');
|
||||
expect(wrapperReturned).toBe(false);
|
||||
// Invocation precedes the wrapper's invalidation/return continuation.
|
||||
// Its old cache hit is permitted; a later caller is still protected.
|
||||
const overlappingRead = readProfile('tenant:profile');
|
||||
await writing;
|
||||
expect(wrapperReturned).toBe(true);
|
||||
expect(cache.has('tenant:profile')).toBe(false);
|
||||
expect(await overlappingRead).toBe('old');
|
||||
expect(await readProfile('tenant:profile')).toBe('new');
|
||||
const contract = CEO_SECTION_CACHE_PLAN.replace(/\s+/g, ' ');
|
||||
expect(contract).toContain("when writeProfile's promise fulfills after cache.delete, not when repository.write commits or resolves");
|
||||
expect(contract).toContain('Reads that overlap an unfinished writeProfile may return an earlier snapshot');
|
||||
});
|
||||
|
||||
test('an old miss filled before the completed write is correctly invalidated', async () => {
|
||||
let stored = 'old';
|
||||
let releaseRead!: () => void;
|
||||
let first = true;
|
||||
const cache = new Map<string, string>();
|
||||
const repository = {
|
||||
read: () => {
|
||||
if (!first) return Promise.resolve(stored);
|
||||
first = false;
|
||||
const snapshot = stored;
|
||||
return new Promise<string>(resolve => { releaseRead = () => resolve(snapshot); });
|
||||
},
|
||||
write: async (_key: string, value: string) => { stored = value; return value; },
|
||||
};
|
||||
const { readProfile, writeProfile } = new Function('cache', 'repository',
|
||||
CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(cache, repository);
|
||||
const earlierRead = readProfile('tenant:profile');
|
||||
releaseRead();
|
||||
expect(await earlierRead).toBe('old');
|
||||
expect(cache.get('tenant:profile')).toBe('old');
|
||||
await writeProfile('tenant:profile', 'new');
|
||||
expect(stored).toBe('new');
|
||||
expect(cache.has('tenant:profile')).toBe(false);
|
||||
expect(await readProfile('tenant:profile')).toBe('new');
|
||||
});
|
||||
|
||||
test('the exact proposed wrapper retains a reproducible stale-fill race', async () => {
|
||||
let releaseRead!: (value: string) => void;
|
||||
let stored = 'old';
|
||||
@@ -476,3 +663,365 @@ describe('reported original coordination violation with an owned finding citatio
|
||||
['accepted stale consequence', finding + '\n\nA subsequent stale read is permitted by the amended contract.'],
|
||||
])('rejects %s', (_name, text) => expect(hasStaleFillRaceFinding(text)).toBe(false));
|
||||
});
|
||||
|
||||
// Exact public Write at d30620e8, session 59f999d1-de6b-4c67-ae6c-210efa05f0cc,
|
||||
// toolu_01CWeW6wi4V6YEMNtd5dVdz2 acknowledged at native line 3343.
|
||||
// PLAN.md SHA-256 577b669134977a17c779765c4a979a5fc1e9bc672cd77948d04d6bf066bfd7ff:
|
||||
// retained requirement lines 38-40, current amendment 45-50, earlier-caller allowance 229.
|
||||
// The recorded paid failure remains a failure; these are free detector regressions.
|
||||
describe('attributed original coordination premise with a current freshness finding', () => {
|
||||
const evidence = "- A read already in progress when a write commits may return its earlier DB\n snapshot to that caller. Every read begun after that write completes must\n observe the committed version. TTL expiry is not a substitute for this rule.\n\n## Proposed wrapper integration\nKeep the current read-through repository interface and shared adapters.\n**[Amended: D1]** The original sketch stated \"no additional version checks or\ncoordination between a cache fill and a write\". That is withdrawn: the review\nshowed it violates the freshness invariant above (schedule in Section 4). The\naccepted ordering rules are:";
|
||||
const allowance = "Waiters coalesced on R1 receive V1 \u2014 permitted by PLAN.md:27-28 (they began before W completed)";
|
||||
const withAllowance = (claim = allowance) => evidence + '\n\n## Assessment of D1\n' + claim + '.';
|
||||
test('accepts the captured current assertion against its retained requirement', () => {
|
||||
expect(hasStaleFillRaceFinding(evidence)).toBe(true);
|
||||
expect(hasStaleFillRaceFinding(withAllowance())).toBe(true);
|
||||
});
|
||||
test('preserves premise ownership through equivalent labels, quotes and rule wording', () => {
|
||||
for (const text of [
|
||||
evidence.replaceAll('D1', 'F7'),
|
||||
evidence.replace('original sketch', 'original wrapper'),
|
||||
evidence.replace('original sketch', 'original implementation'),
|
||||
evidence.replace('"no additional', '“no additional').replace('a write"', 'a write”'),
|
||||
evidence.replace('no additional version checks or\ncoordination', 'no coordination'),
|
||||
evidence.replace('That is withdrawn: the review\nshowed it violates', 'This is withdrawn: the review shows it breaks'),
|
||||
evidence.replace('freshness invariant above', 'retained read-after-write contract above'),
|
||||
evidence.replace('Every read begun', 'Every read started').replace('that write completes', 'the write returns').replace('committed version', 'committed value'),
|
||||
evidence.replace(' (schedule in Section 4)', ''),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(true);
|
||||
});
|
||||
test('requires the original missing coordination and the reviewer current assertion together', () => {
|
||||
for (const text of [
|
||||
evidence.replace('no additional version checks or\ncoordination', 'coordination'),
|
||||
evidence.replace('cache fill and a write', 'cache hit and a read'),
|
||||
evidence.replace('original sketch stated', 'original sketch may have stated'),
|
||||
evidence.replace('That is withdrawn:', 'That is retained:'),
|
||||
evidence.replace('showed it violates', 'did not show it violates'),
|
||||
evidence.replace('showed it violates', 'showed another wrapper violates'),
|
||||
evidence.replace('showed it violates', 'showed it might violate'),
|
||||
evidence.replace('freshness invariant', 'formatting invariant'),
|
||||
evidence.replace('Section 4).', 'Section 4)?'),
|
||||
evidence.replace('That is withdrawn:', '\n\n## Other finding\nThat is withdrawn:'),
|
||||
evidence.replace('That is withdrawn:', '| That is withdrawn:'),
|
||||
evidence.replace('**[Amended: D1]**', 'If approved: **[Amended: D1]**'),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
});
|
||||
test('requires a retained current requirement from this plan', () => {
|
||||
const finding = evidence.slice(evidence.indexOf('## Proposed wrapper integration'));
|
||||
for (const text of [
|
||||
finding,
|
||||
evidence.replace('Every read begun after that write completes must\n observe the committed version.', 'Later reads may observe an earlier value.'),
|
||||
evidence.replace('must\n observe', 'might\n observe'),
|
||||
evidence.replace('Every read begun', 'Not every read begun'),
|
||||
evidence.replace('## Proposed wrapper integration', 'This rule is withdrawn.\n\n## Proposed wrapper integration'),
|
||||
'## Finding F9: unrelated cache\n' + evidence,
|
||||
'## Historical source\n' + evidence.slice(0, evidence.indexOf('## Proposed wrapper integration')) + '\n## Current review\n' + finding,
|
||||
'> Every read begun after that write completes must observe the committed version.\n\n' + finding,
|
||||
'"Every read begun after that write completes must observe the committed version."\n\n' + finding,
|
||||
'For another cache. Every read begun after that write completes must observe the committed version.\n\n' + finding,
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
});
|
||||
test('does not promote copied, fenced or quoted review assertions', () => {
|
||||
for (const text of [
|
||||
'Source:\n\n' + evidence,
|
||||
'Earlier review:\n\n' + evidence,
|
||||
'## Hypothetical example\n' + evidence,
|
||||
'The following is a quoted source excerpt.\n\n' + evidence,
|
||||
evidence.split('\n').map(line => '> ' + line).join('\n'),
|
||||
evidence.split('\n').map(line => ' ' + line).join('\n'),
|
||||
'````text\n' + evidence + '\n````',
|
||||
'~~~text\n' + evidence + '\n~~~',
|
||||
evidence.replace('**[Amended: D1]**', '"Copied sentence. **[Amended: D1]**') + '"',
|
||||
evidence.replace('**[Amended: D1]**', 'Example of report format:\n\n**[Amended: D1]**'),
|
||||
evidence.replace('That is withdrawn:', '"That is withdrawn:').replace('Section 4).', 'Section 4)."'),
|
||||
evidence.replace('The original sketch', '`The original sketch').replace('Section 4).', 'Section 4).`'),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
});
|
||||
test('same-finding rejection and stale-result permission remain failures', () => {
|
||||
for (const tail of [
|
||||
'D1 is rejected.', 'D1 is "withdrawn".', 'This finding is dismissed.',
|
||||
'| D1 | Withdrawn |', '| D1 | "rejected" |',
|
||||
'A subsequent stale read is permitted by the amended contract.',
|
||||
'This stale-fill behavior is accepted.', 'No coordination is required.',
|
||||
]) expect(hasStaleFillRaceFinding(withAllowance() + '\n\n## Assessment of D1\n' + tail)).toBe(false);
|
||||
});
|
||||
test('foreign or copied rejections do not override the current finding', () => {
|
||||
for (const tail of [
|
||||
'## Assessment of D2\nD2 is rejected.',
|
||||
'## Assessment of D2\n| D2 | Withdrawn |',
|
||||
'## Historical assessment\nD1 is withdrawn.',
|
||||
'## Assessment of D1\n> D1 is rejected.',
|
||||
]) expect(hasStaleFillRaceFinding(evidence + '\n\n' + tail)).toBe(true);
|
||||
});
|
||||
test('coalesced earlier callers may use different symbolic writer and snapshot names', () => {
|
||||
for (const text of [
|
||||
allowance.replaceAll('R1', 'R17').replaceAll('V1', 'snapshot-A').replaceAll('W ', 'W9 '),
|
||||
allowance.replace('Waiters', 'Readers').replace('began', 'started').replace('W completed', 'the write returned'),
|
||||
allowance.replace('Waiters coalesced on R1', 'Callers').replace('receive', 'observe').replace('permitted by PLAN.md:27-28', 'allowed'),
|
||||
]) expect(hasStaleFillRaceFinding(withAllowance(text))).toBe(true);
|
||||
});
|
||||
test('earlier-call allowance cannot credit a later reader, uncertain ordering or a fill', () => {
|
||||
for (const text of [
|
||||
allowance.replace('before W', 'after W'),
|
||||
allowance.replace('they began', 'they never began'),
|
||||
allowance.replace('they began', 'they may have begun'),
|
||||
allowance.replace('they began', 'another reader began'),
|
||||
allowance.replace('before W completed', 'before R2 completed'),
|
||||
allowance.replace('Waiters', 'Later readers'),
|
||||
allowance.replace('receive V1', 'fill the cache with V1'),
|
||||
allowance.replace('receive V1', 'return V1 to later callers'),
|
||||
allowance.replace('W completed)', 'W completed only if the write failed)'),
|
||||
allowance + ' and later readers may reuse V1',
|
||||
allowance + '. A subsequent stale read is permitted',
|
||||
allowance + '. The stale cache fill is acceptable',
|
||||
]) expect(hasStaleFillRaceFinding(withAllowance(text))).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe('attributed coordination phrase classes and ownership', () => {
|
||||
// Independently written forms: no captured sentence, schedule schema or fixed parenthetical.
|
||||
const reports = [
|
||||
`## Retained contract
|
||||
Any request started after the write returns shall receive the committed value.
|
||||
|
||||
## Wrapper review
|
||||
[Amended: F8] Our original wrapper assumed “cache population proceeds without synchronization with writes”.
|
||||
We reject that assumption. Our review established that this approach contradicts the existing freshness guarantee.`,
|
||||
`## Existing contract
|
||||
All reads that begin after write completion must return the newly committed version.
|
||||
|
||||
## Implementation review
|
||||
[Amended: D4] The proposed implementation specifies "no coordination for writes and cache fills".
|
||||
This proposal was rejected. Review found it fails to preserve the read-after-write requirement.`,
|
||||
`## Contract retained
|
||||
Once a write has completed, new reads must see the value it committed.
|
||||
|
||||
## Current review
|
||||
[Amended: F3] The current sketch states "cache fills and writes run without coordination".
|
||||
That sketch breaks the current freshness rule.`,
|
||||
`## Required behavior
|
||||
The retained requirement: all requests that start after that write finishes are required to receive the committed snapshot.
|
||||
|
||||
## Current review
|
||||
[Amended: D17] Our original implementation assumed "cache repopulation and writes lacked ordering guards".
|
||||
That assumption has been retracted. The implementation does not preserve the existing freshness contract.`,
|
||||
];
|
||||
|
||||
for (const [index, report] of reports.entries()) {
|
||||
test(`phrase classes recognize independent current review form ${index + 1}`, () => expect(hasStaleFillRaceFinding(report)).toBe(true));
|
||||
}
|
||||
|
||||
test('the attributed premise and direct violation need no fixed rejection sentence or above reference', () => {
|
||||
expect(hasStaleFillRaceFinding(reports[0]!.replace('We reject that assumption. ', ''))).toBe(true);
|
||||
expect(hasStaleFillRaceFinding(reports[1]!.replace('This proposal was rejected. ', ''))).toBe(true);
|
||||
expect(hasStaleFillRaceFinding(reports[2]!.replace('That sketch breaks', 'We found that this sketch violates'))).toBe(true);
|
||||
});
|
||||
|
||||
test('different finding and artifact subjects cannot borrow the attributed premise', () => {
|
||||
for (const text of [
|
||||
reports[0]!.replace('We reject that assumption.', 'Another unrelated finding concerns replica lag.'),
|
||||
reports[0]!.replace('this approach contradicts', 'another approach contradicts'),
|
||||
reports[0]!.replace('this approach contradicts', 'the implementation contradicts'),
|
||||
reports[1]!.replace('Review found it fails', 'Review found another issue fails'),
|
||||
reports[2]!.replace('That sketch breaks', 'It is unclear whether that sketch breaks'),
|
||||
reports[2]!.replace('That sketch breaks', 'It is false that that sketch breaks'),
|
||||
reports[2]!.replace('That sketch breaks', 'That sketch does not break'),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
});
|
||||
|
||||
test('normative freshness rules cannot be replaced by conditional or permissive statements', () => {
|
||||
for (const report of reports) {
|
||||
for (const text of [
|
||||
report.replace(/shall receive|must return|must see|are required to receive/, 'may receive'),
|
||||
report.startsWith('## Contract retained') ? report.replace('Once a write has completed', 'Before a write has completed') : report.replace('after', 'before'),
|
||||
report.replace('committed value', 'earlier value').replace('newly committed version', 'old version').replace('the value it committed', 'an older snapshot').replace('committed snapshot', 'stale snapshot'),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
}
|
||||
});
|
||||
|
||||
test('quoted current assertions, source owners and split findings remain closed across phrase forms', () => {
|
||||
for (const report of reports) {
|
||||
const assertion = report.slice(report.lastIndexOf('\n') + 1);
|
||||
for (const text of [
|
||||
'> ' + report.replaceAll('\n', '\n> '),
|
||||
'````text\n' + report + '\n````',
|
||||
'## Historical source\n' + report.replaceAll('## ', '### '),
|
||||
report.replace(assertion, '"' + assertion + '"'),
|
||||
report.replace(assertion, '### Unrelated finding F99\n' + assertion),
|
||||
]) expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
}
|
||||
});
|
||||
|
||||
const finding = reports[0]!;
|
||||
const withAllowance = (claim: string) => finding + '\n\n## Assessment of F8\n' + claim;
|
||||
const earlierAllowances = [
|
||||
'The coalesced readers receive their earlier snapshot; that return is permitted because they started before the write completed.',
|
||||
'Readers coalesced on R8 return SNAPSHOT_X (allowed, because each call began before W9 returned).',
|
||||
'Waiters that began before write completion are permitted to receive V7.',
|
||||
];
|
||||
|
||||
test('earlier-group permission depends on ownership and chronology rather than exact punctuation', () => {
|
||||
for (const claim of earlierAllowances) expect(hasStaleFillRaceFinding(withAllowance(claim))).toBe(true);
|
||||
});
|
||||
|
||||
test('earlier-group phrases cannot permit a fill, another caller or uncertain start', () => {
|
||||
for (const claim of [
|
||||
earlierAllowances[0]!.replace('before the write completed', 'after the write completed'),
|
||||
earlierAllowances[0]!.replace('they started', 'another reader started'),
|
||||
earlierAllowances[0]!.replace('they started', 'they might have started'),
|
||||
earlierAllowances[0]!.replace('receive their earlier snapshot', 'store their earlier snapshot in the cache'),
|
||||
earlierAllowances[1]!.replace('each call began', 'some other call began'),
|
||||
earlierAllowances[1]!.replace('W9 returned', 'R3 returned'),
|
||||
earlierAllowances[2]!.replace('before write completion', 'before another write completed'),
|
||||
earlierAllowances[2]!.replace('receive V7', 'return V7 to future callers'),
|
||||
earlierAllowances[0]!.replace(/\.$/, ' and future consumers may reuse that snapshot.'),
|
||||
]) expect(hasStaleFillRaceFinding(withAllowance(claim))).toBe(false);
|
||||
});
|
||||
|
||||
test('a legitimate earlier group never overrides a same-finding rejection or accepted stale fill', () => {
|
||||
for (const allowance of earlierAllowances) {
|
||||
expect(hasStaleFillRaceFinding(withAllowance(allowance) + '\nF8 is rejected.')).toBe(false);
|
||||
expect(hasStaleFillRaceFinding(withAllowance(allowance) + '\nA later stale read is permitted.')).toBe(false);
|
||||
expect(hasStaleFillRaceFinding(withAllowance(allowance) + '\nThis stale-fill behavior is accepted.')).toBe(false);
|
||||
expect(hasStaleFillRaceFinding(withAllowance(allowance) + '\n\n## Assessment of F9\nF9 is rejected.')).toBe(true);
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
test('current assertions cannot attribute the retained-rule violation to a different finding', () => {
|
||||
const report = reports[2]!;
|
||||
expect(hasStaleFillRaceFinding(report.replace('freshness rule.', 'freshness rule (see F3).'))).toBe(true);
|
||||
expect(hasStaleFillRaceFinding(report.replace('freshness rule.', 'freshness rule (see F9).'))).toBe(false);
|
||||
expect(hasStaleFillRaceFinding(report.replace('freshness rule.', 'freshness rule (see D3).'))).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('current fill-lifetime overlap', () => {
|
||||
const lifetime = 'a fill that started before a write and stored after it caches the pre-write snapshot';
|
||||
const current = (text: string, suffix = '') => `### Current findings\n\nWithout coordination, ${text}, violating the retained read-after-write rule. ${suffix}`;
|
||||
|
||||
test('captured current lifetime claim is independent of the ambiguous inline schedule', () => {
|
||||
expect(hasStaleFillRaceFinding(lifetimeFixture.claim)).toBe(true);
|
||||
expect(hasStaleFillRaceFinding(lifetimeFixture.ambiguousFinding)).toBe(false);
|
||||
});
|
||||
|
||||
test.each([
|
||||
lifetime,
|
||||
'the cache fill which began before the write and completed after that write, storing the old value',
|
||||
'a fill that begins before a write and finishes after the same write stores the stale data',
|
||||
'the original fill starts before this write and completes after that same write caches the pre-write snapshot',
|
||||
'the fill began before the write completes and stored after it settles caches the pre-write value',
|
||||
])('recognizes an explicit same-fill lifetime: %s', text => {
|
||||
expect(hasStaleFillRaceFinding(current(text))).toBe(true);
|
||||
});
|
||||
|
||||
test.each(['F1', 'R7', 'BUG-cache', '17'])('current ownership does not depend on row-ID spelling: %s', id => {
|
||||
expect(hasStaleFillRaceFinding(`### Current findings\n\n| ${id} | CRITICAL GAP | ${current(lifetime).split('\n\n')[1]} |`)).toBe(true);
|
||||
});
|
||||
|
||||
test.each([
|
||||
['starts after the write', lifetime.replace('started before', 'started after')],
|
||||
['stores before the write', lifetime.replace('stored after', 'stored before')],
|
||||
['different writer', lifetime.replace('after it', 'after another write')],
|
||||
['different filling actor', lifetime.replace('and stored', 'and another fill stored')],
|
||||
['foreign key', lifetime.replace('a fill', 'a fill for another key')],
|
||||
['return to original caller only', lifetime.replace('stored after it caches', 'returned after it with')],
|
||||
['fresh value', lifetime.replace('pre-write snapshot', 'committed snapshot')],
|
||||
['missing start', lifetime.replace('that started before a write and ', '')],
|
||||
['missing late storage', lifetime.replace('and stored after it ', '')],
|
||||
['missing cache storage', lifetime.replace('caches the pre-write snapshot', 'returns the pre-write snapshot')],
|
||||
['explicit conditional', 'if ' + lifetime],
|
||||
['explicit hypothesis', 'hypothetical execution: ' + lifetime],
|
||||
['possible execution only', 'it might be that ' + lifetime],
|
||||
['negated execution', 'it is not true that ' + lifetime],
|
||||
['prevented execution', 'the guard prevents ' + lifetime],
|
||||
['impossible execution', 'it is impossible that ' + lifetime],
|
||||
['quoted execution', '"' + lifetime + '"'],
|
||||
['code literal execution', '`' + lifetime + '`'],
|
||||
['quote cannot join phase fragments', lifetime.replace('and stored after it', 'and "stored after it"')],
|
||||
['second subject cannot inherit write', lifetime.replace('after it', 'after a separate write')],
|
||||
])('rejects incomplete or unasserted overlap: %s', (_name, text) => {
|
||||
expect(hasStaleFillRaceFinding(current(text))).toBe(false);
|
||||
});
|
||||
|
||||
test.each([
|
||||
['quoted block', current(lifetime).split('\n').map(line => '> ' + line).join('\n')],
|
||||
['fenced block', '```text\n' + current(lifetime) + '\n```'],
|
||||
['unclosed fence', '~~~text\n' + current(lifetime)],
|
||||
['source heading', current(lifetime).replace('Current findings', 'Quoted source')],
|
||||
['historical owner', current(lifetime).replace('Current findings', 'Historical review')],
|
||||
['source introduction', 'Source:\n' + current(lifetime).replace('Current findings', 'Findings')],
|
||||
['accepted staleness', current(lifetime, 'This staleness is the accepted consistency model.')],
|
||||
['later stale read permitted', current(lifetime, 'Later stale reads are permitted by the contract.')],
|
||||
['current prevention', current(lifetime, 'The current wrapper cannot refill old data after invalidation.')],
|
||||
['finding withdrawn', current(lifetime, 'This finding is withdrawn.')],
|
||||
['finding rejected', current(lifetime, 'This finding is rejected.')],
|
||||
['no repair required', current(lifetime, 'No guard is required.')],
|
||||
])('preserves current ownership and dismissal: %s', (_name, text) => {
|
||||
expect(hasStaleFillRaceFinding(text)).toBe(false);
|
||||
});
|
||||
|
||||
const seeded = () => {
|
||||
const events: string[] = [];
|
||||
let cached: string | undefined;
|
||||
let releaseRead!: () => void;
|
||||
const pendingRead = new Promise<string>(resolve => { releaseRead = () => { events.push('DB read v1 completes'); resolve('v1'); }; });
|
||||
const cache = {
|
||||
get: () => cached,
|
||||
set: (_key: string, value: string) => { events.push('cache set ' + value); cached = value; },
|
||||
delete: () => { events.push('cache delete'); cached = undefined; },
|
||||
};
|
||||
const repository = {
|
||||
read: () => pendingRead,
|
||||
write: async () => { events.push('DB write commits v2'); return 'v2'; },
|
||||
};
|
||||
const functions = new Function('cache', 'repository', CACHE_READ_WRITE_SKETCH + '\nreturn { readProfile, writeProfile };')(cache, repository);
|
||||
return { events, releaseRead, ...functions } as { events: string[]; releaseRead: () => void; readProfile: (key: string) => Promise<string>; writeProfile: (key: string, update: unknown) => Promise<string> };
|
||||
};
|
||||
|
||||
test('the actual seeded wrapper can fill a pre-write snapshot when its pending read completes after the writer', async () => {
|
||||
const fixture = seeded();
|
||||
const original = fixture.readProfile('profile');
|
||||
await fixture.writeProfile('profile', {});
|
||||
fixture.releaseRead();
|
||||
expect(await original).toBe('v1');
|
||||
expect(await fixture.readProfile('profile')).toBe('v1');
|
||||
expect(fixture.events).toEqual(['DB write commits v2', 'cache delete', 'DB read v1 completes', 'cache set v1']);
|
||||
});
|
||||
|
||||
test('the seeded await continuation stores synchronously before a later writer invalidates it', async () => {
|
||||
const fixture = seeded();
|
||||
const original = fixture.readProfile('profile');
|
||||
fixture.releaseRead();
|
||||
expect(await original).toBe('v1');
|
||||
await fixture.writeProfile('profile', {});
|
||||
expect(fixture.events).toEqual(['DB read v1 completes', 'cache set v1', 'DB write commits v2', 'cache delete']);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe('section fixture rollout metrics retain final acceptance without an impossible early-stage gate',()=>{
|
||||
test('early-stage hit rate counts admitted requests while aggregate metrics use baseline limits',()=>{
|
||||
const requests=9000, admitted=requests*0.1, hits=admitted*0.6;
|
||||
const cohortHitRate=hits/admitted, aggregateHitRate=hits/requests;
|
||||
expect(cohortHitRate).toBe(0.6); expect(aggregateHitRate).toBe(0.06);
|
||||
expect(70*(1-aggregateHitRate)).toBeCloseTo(65.8); // uniform traffic, linear read CPU: above final 50%, below baseline 70%
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('among requests admitted to the cache path');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('tracked separately, not as misses');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('DB CPU and read p95 are service-wide metrics, including bypassed requests');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('At the 10% and 50% stages');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('no worse than their 70%/120 ms pre-rollout baselines');
|
||||
expect(CEO_SECTION_CACHE_PLAN).not.toContain('A healthy hour means the stated hit-rate, CPU, latency and error targets hold');
|
||||
});
|
||||
test('full rollout keeps all original absolute targets and the seeded race still needs repair',()=>{
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('At 100%, the original');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('absolute acceptance targets (DB CPU below 50%, read p95 below 60 ms, hits at');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('least 60%) must all hold with unchanged correctness/error SLOs and no alerts');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('Every read begun after that write completes must');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('TTL expiry is not a substitute for this rule');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('no additional version checks or');
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain(CACHE_READ_WRITE_SKETCH);
|
||||
expect(CEO_SECTION_CACHE_PLAN).toContain('repository.read returns\n an immutable absent-result DTO for a missing record, never undefined');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user