mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-05 10:57:15 +02:00
test: retire the finding-count cluster and trim its helpers (C)
- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
budget, never on skill behavior; delete them, their touchfile/tier ids,
AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
(11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
closure, and delete the free replay tests whose assertions exercised only
that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
only as input for a live subject keep their assertions: the multiSelect
default moved to plan-review-decisions, runner PTY tests use inline caller
policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
(its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
and per-finding cadence coverage with their re-entry tests.
This commit is contained in:
garrytan committed
1 parent
53e7f3212f
commit
6415690a18
317 files changed
+315
-54111
No files matched your search
@@ -3,11 +3,9 @@ import * as fs from 'node:fs';
|
||||
import * as os from 'node:os';
|
||||
import * as path from 'node:path';
|
||||
import fixture from './fixtures/design-count-native-8525.json';
|
||||
import { isDesignCountFirstReview, isDesignCountSetup, isDesignCompletionHandoff, pickDesignCountQuestion } from './helpers/design-count-review';
|
||||
import { nativePlanCallFingerprint, planCountQuestionPhase, designStep0Boundary, hasNativePlanTerminal } from './helpers/claude-pty-runner';
|
||||
import type { NativePlanQuestionCall, PlanCountTranscript } from './helpers/plan-count-transcript';
|
||||
const calls = () => structuredClone(fixture.transcript.calls) as NativePlanQuestionCall[];
|
||||
const fp = (c: NativePlanQuestionCall) => nativePlanCallFingerprint(c, 0, true);
|
||||
import { hasNativePlanTerminal } from './helpers/claude-pty-runner';
|
||||
import type { PlanCountTranscript } from './helpers/plan-count-transcript';
|
||||
|
||||
function completion() {
|
||||
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'design-8525-replay-'));
|
||||
const file = path.join(dir, path.basename(fixture.provenance.planPath));
|
||||
@@ -22,65 +20,10 @@ function completion() {
|
||||
const check = () => hasNativePlanTerminal(transcript, file, startedAt, 'completion_summary');
|
||||
return { dir, file, transcript, final, write, check, cleanup: () => fs.rmSync(dir, {recursive:true, force:true}) };
|
||||
}
|
||||
test('full exact native attempt starts review at Issue 1 and counts six independently acknowledged decisions', () => {
|
||||
const input = calls(); let started = false; const counts = {step0:0,review:0,administrative:0};
|
||||
expect(isDesignCountFirstReview(fp(input[0]!))).toBe(false);
|
||||
expect(isDesignCountFirstReview(fp(input[1]!))).toBe(true);
|
||||
for (const call of input) {
|
||||
const p = planCountQuestionPhase(fp(call), started, designStep0Boundary, isDesignCountFirstReview, isDesignCountSetup, isDesignCompletionHandoff);
|
||||
counts[p.administrative ? 'administrative' : p.preReview ? 'step0' : 'review']++;
|
||||
started = p.reviewStarted;
|
||||
}
|
||||
expect(counts).toEqual({step0:1,review:6,administrative:0});
|
||||
expect(counts.review).toBeGreaterThanOrEqual(4); expect(counts.review).toBeLessThanOrEqual(7);
|
||||
});
|
||||
|
||||
test('exact native final text and reconstructed read-back-verified report supply completion', () => {
|
||||
const f = completion(); try { expect(f.check()).toBe(true); } finally { f.cleanup(); }
|
||||
});
|
||||
const changedQuestion = (change: (c: NativePlanQuestionCall) => void) => {
|
||||
const c = calls()[1]!; change(c); const q = c.questions[0]!;
|
||||
c.answers = {[q.question]:q.options[0]!.label}; return c;
|
||||
};
|
||||
for (const [name, change] of Object.entries({
|
||||
'unrelated setup header': (c: NativePlanQuestionCall) => { c.questions[0]!.header = 'Routing'; },
|
||||
'wrong native Issue header': (c: NativePlanQuestionCall) => { c.questions[0]!.header = 'Issue 2'; },
|
||||
'wrong offered Issue ids': (c: NativePlanQuestionCall) => { c.questions[0]!.options[0]!.label = '2A: Filled primary Save'; },
|
||||
'multiselect': (c: NativePlanQuestionCall) => { c.questions[0]!.multiSelect = true; },
|
||||
'another bundled question': (c: NativePlanQuestionCall) => { c.questions.push(structuredClone(c.questions[0]!)); },
|
||||
'missing current source': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace('PLAN.md','other.md'); },
|
||||
'quoted current source': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace('PLAN.md','"PLAN.md"'); },
|
||||
'multiple source gaps': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace('gap G1','gap G1 and gap G2'); },
|
||||
'unowned gap in alternative': (c: NativePlanQuestionCall) => { c.questions[0]!.options[2]!.description = 'Leave G2 open; the gap stays open.'; },
|
||||
'no current defect': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace('all four header buttons look identical','the header buttons have distinct approved styles'); },
|
||||
'quoted only defect': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace(/ELI10: ([\s\S]*?)\nStakes/, 'ELI10: "$1"\nStakes'); },
|
||||
'historical assessment': (c: NativePlanQuestionCall) => { c.questions[0]!.question = c.questions[0]!.question.replace('ELI10:','ELI10: Historical example:'); },
|
||||
'withdrawn current issue': (c: NativePlanQuestionCall) => { c.questions[0]!.question += '\nThis issue is withdrawn.'; },
|
||||
'quoted withdrawn state': (c: NativePlanQuestionCall) => { c.questions[0]!.question += '\nThis issue is "withdrawn".'; },
|
||||
'no concrete offered remedy': (c: NativePlanQuestionCall) => { c.questions[0]!.options[0]!.description = '✅ Follow the design system.'; },
|
||||
'quoted only remedy': (c: NativePlanQuestionCall) => { c.questions[0]!.options[0]!.description = '"' + c.questions[0]!.options[0]!.description + '"'; },
|
||||
'no opposed open gap': (c: NativePlanQuestionCall) => { c.questions[0]!.options[2]!.description = 'The question remains available for discussion.'; },
|
||||
'quoted question': (c: NativePlanQuestionCall) => { c.questions[0]!.question = '> ' + c.questions[0]!.question.replaceAll('\n','\n> '); },
|
||||
'code example': (c: NativePlanQuestionCall) => { c.questions[0]!.question = '```text\n' + c.questions[0]!.question + '\n```'; },
|
||||
})) test(`named current issue rejects ${name}`, () => expect(isDesignCountFirstReview(fp(changedQuestion(change)))).toBe(false));
|
||||
test('native ownership and actual answer remain required', () => {
|
||||
for (const mutate of [
|
||||
(c: NativePlanQuestionCall) => { c.answered=false; },
|
||||
(c: NativePlanQuestionCall) => { c.failed=true; },
|
||||
(c: NativePlanQuestionCall) => { c.unansweredQuestionIndices=[0]; },
|
||||
(c: NativePlanQuestionCall) => { delete c.answeredAt; },
|
||||
(c: NativePlanQuestionCall) => { c.answers={[c.questions[0]!.question]:'an unoffered recommendation'}; },
|
||||
]) { const c=calls()[1]!; mutate(c); expect(isDesignCountFirstReview(fp(c))).toBe(false); }
|
||||
const c=calls()[1]!; expect(isDesignCountFirstReview({...fp(c),signature:'foreign:question'})).toBe(false);
|
||||
});
|
||||
test('the source gap and design-defect class are independent of seeded spelling or G-number', () => {
|
||||
const c=changedQuestion(c => { c.questions[0]!.question=c.questions[0]!.question.replaceAll('G1','G22').replaceAll('Save','Submit');
|
||||
c.questions[0]!.options.forEach(o=>{o.label=o.label.replaceAll('Save','Submit');o.description=o.description?.replaceAll('Save','Submit');}); });
|
||||
for (const o of c.questions[0]!.options) { c.answers={[c.questions[0]!.question]:o.label};expect(isDesignCountFirstReview(fp(c))).toBe(true); }
|
||||
const coded=changedQuestion(c=>{c.questions[0]!.question=c.questions[0]!.question.replace('PLAN.md','`PLAN.md`');});
|
||||
expect(isDesignCountFirstReview(fp(coded))).toBe(true);
|
||||
c.answered=false;delete c.answers;delete c.unansweredQuestionIndices;
|
||||
expect(pickDesignCountQuestion(fp(c),fp(c))).toBeNull(); // Existing actor/default answer ownership is unchanged.
|
||||
});
|
||||
test('current typed status accepts presentation, field order and current report prose independently', () => {
|
||||
const f=completion();try {
|
||||
for (const heading of ['## Completion','### Completion summary','## Review complete','## Design review complete','**Review completion:**']) {
|
||||
@@ -139,144 +82,8 @@ test('typed delivery retains source session, answer chronology, fresh file and c
|
||||
const alternate=path.join(f.dir,'alternate.md');fs.writeFileSync(alternate,fixture.report);fs.symlinkSync(alternate,f.file);expect(f.check()).toBe(false);
|
||||
}finally{f.cleanup();}
|
||||
});
|
||||
test('cancelled retry current native Issue is still classified without supplying terminal coverage', () => {
|
||||
const input=structuredClone(fixture.cancelledRetry.calls) as NativePlanQuestionCall[];
|
||||
expect(fixture.cancelledRetry.coverageCredit).toBe(0);
|
||||
expect(input).toHaveLength(2);expect(isDesignCountFirstReview(fp(input[0]!))).toBe(false);
|
||||
expect(isDesignCountFirstReview(fp(input[1]!))).toBe(true);
|
||||
const review=planCountQuestionPhase(fp(input[1]!),false,designStep0Boundary,isDesignCountFirstReview,isDesignCountSetup,isDesignCompletionHandoff);
|
||||
expect(review.preReview).toBe(false);
|
||||
});
|
||||
test('an unlabelled source gap still needs a current defect, concrete offered repair and its own retained violation', () => {
|
||||
const original=fixture.cancelledRetry.calls[1]! as NativePlanQuestionCall;
|
||||
for (const mutate of [
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('currently look identical','already have distinct correct styles');},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('Pass 1 Information Architecture','planning setup');},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('PLAN.md','other.md');},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('ELI10:','ELI10: Historical example:');},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description='Use the Button component as appropriate.';},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description='This resolves the hierarchy gap completely.';},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description='The plan keeps a documented DESIGN.md violation for G9.';},
|
||||
(q:NativePlanQuestionCall['questions'][number])=>{q.header='Setup';},
|
||||
]) {const c=structuredClone(original);mutate(c.questions[0]!);c.answers={[c.questions[0]!.question]:c.questions[0]!.options[0]!.label};expect(isDesignCountFirstReview(fp(c))).toBe(false);}
|
||||
});
|
||||
|
||||
|
||||
import phaseEntry77 from './fixtures/design-phase-entry-77.json';
|
||||
function phaseCalls77() { return structuredClone(phaseEntry77.calls) as NativePlanQuestionCall[]; }
|
||||
function phaseSequence77(calls = phaseCalls77()) {
|
||||
let started = false;
|
||||
return calls.map(call => {
|
||||
const f = nativePlanCallFingerprint(call, 0, !started);
|
||||
const phase = planCountQuestionPhase(f, started, designStep0Boundary,
|
||||
isDesignCountFirstReview, isDesignCountSetup, isDesignCompletionHandoff);
|
||||
started = phase.reviewStarted;
|
||||
return { id: call.toolUseId, ...phase };
|
||||
});
|
||||
}
|
||||
function phaseMutation77(index: number, mutate: (call: NativePlanQuestionCall) => void) {
|
||||
const call = phaseCalls77()[index]!; const before = call.questions[0]!.question;
|
||||
const answer = call.answers![before]!; mutate(call);
|
||||
if (call.questions[0]!.question !== before) call.answers = {[call.questions[0]!.question]: answer};
|
||||
return nativePlanCallFingerprint(call, 0, true);
|
||||
}
|
||||
|
||||
test('actual77 focus ACK opens review, later learnings stays setup, all six real findings count', () => {
|
||||
const phases = phaseSequence77();
|
||||
expect(phases.slice(0, 3).map(p => p.preReview)).toEqual([true, true, true]);
|
||||
expect(phases[1]!.reviewStarted).toBe(true);
|
||||
expect(phases.slice(3).map(p => p.preReview)).toEqual([false, false, false, false, false, false]);
|
||||
expect(phases.filter(p => !p.preReview)).toHaveLength(6);
|
||||
const calls = phaseCalls77();
|
||||
// These remain setup decisions, never substituted for a substantive finding.
|
||||
expect(isDesignCountFirstReview(nativePlanCallFingerprint(calls[1]!, 0, true))).toBe(false);
|
||||
expect(isDesignCountSetup(nativePlanCallFingerprint(calls[2]!, 0, false))).toBe(true);
|
||||
});
|
||||
|
||||
test('native focus and learnings classification follows scope actions, not recommendation or order', () => {
|
||||
for (const index of [1,2]) for (const reversed of [false,true]) for (const picked of [0,1]) {
|
||||
const call = phaseCalls77()[index]!; const q=call.questions[0]!;
|
||||
q.options.forEach(o => { o.label=o.label.replace(/\s*\(recommended\)/i,''); });
|
||||
q.options[picked]!.label += ' (recommended)';
|
||||
if(reversed)q.options.reverse();
|
||||
call.answers = {[q.question]:q.options[picked]!.label};
|
||||
const f=nativePlanCallFingerprint(call,0,true);
|
||||
expect(designStep0Boundary(f)).toBe(true);
|
||||
expect(isDesignCountSetup(f)).toBe(true);
|
||||
}
|
||||
});
|
||||
|
||||
test('equivalent all-seven versus subset focus wording stays a plan-wide setup choice', () => {
|
||||
for(const title of ['Review all 7 design dimensions, or focus on specific areas?', 'Review all 7 dimensions or focus on a subset?', 'Review all 7 design passes, or focus?']) {
|
||||
const f=phaseMutation77(1,c=>{c.questions[0]!.question=c.questions[0]!.question.replace(/^D2[^\n]+/,'D21: '+title);});
|
||||
expect(designStep0Boundary(f)).toBe(true); expect(isDesignCountSetup(f)).toBe(true);
|
||||
}
|
||||
});
|
||||
|
||||
for (const [name, mutate] of Object.entries({
|
||||
'pending': (c: NativePlanQuestionCall) => { c.answered=false; },
|
||||
'failed': (c: NativePlanQuestionCall) => { c.failed=true; },
|
||||
'missing answer time': (c: NativePlanQuestionCall) => { delete c.answeredAt; },
|
||||
'missing session': (c: NativePlanQuestionCall) => { c.sessionId=''; },
|
||||
'missing call ID': (c: NativePlanQuestionCall) => { c.toolUseId=''; },
|
||||
'partial': (c: NativePlanQuestionCall) => { c.unansweredQuestionIndices=[0]; },
|
||||
'unoffered answer': (c: NativePlanQuestionCall) => { c.answers={[c.questions[0]!.question]:'Unrelated answer'}; },
|
||||
'checkbox': (c: NativePlanQuestionCall) => { c.questions[0]!.multiSelect=true; },
|
||||
'mixed packet': (c: NativePlanQuestionCall) => { c.questions.push({header:'Issue',question:'Approve a new layout?',options:[{label:'Approve'},{label:'Defer'}],multiSelect:false}); },
|
||||
'foreign source': (c: NativePlanQuestionCall) => { c.questions[0]!.question=c.questions[0]!.question.replace('of PLAN.md','of OTHER.md'); },
|
||||
'historical source': (c: NativePlanQuestionCall) => { c.questions[0]!.question=c.questions[0]!.question.replace('Project/branch/task:','Project/branch/task: Historical source:'); },
|
||||
'quoted question': (c: NativePlanQuestionCall) => { c.questions[0]!.question='> '+c.questions[0]!.question; },
|
||||
'additional approval': (c: NativePlanQuestionCall) => { c.questions[0]!.question+='\nApprove all findings?'; },
|
||||
'extra option': (c: NativePlanQuestionCall) => { c.questions[0]!.options.push({label:'Approve deployment'}); },
|
||||
'extra option action': (c: NativePlanQuestionCall) => { c.questions[0]!.options[0]!.label+=' and approve the plan'; c.answers={[c.questions[0]!.question]:c.questions[0]!.options[0]!.label}; },
|
||||
})) for(const index of [1,2])test(`native ${index===1?'focus':'learnings'} does not classify ${name} as setup`,()=>{
|
||||
const f=phaseMutation77(index,mutate);
|
||||
expect(designStep0Boundary(f)).toBe(false); expect(isDesignCountSetup(f)).toBe(false);
|
||||
});
|
||||
|
||||
test('narrow-only, duplicated scope, quoted rating and component rating do not open review',()=>{
|
||||
for(const mutate of [
|
||||
(c:NativePlanQuestionCall)=>{c.questions[0]!.options[0]!.label='Only the 2 listed gaps';},
|
||||
(c:NativePlanQuestionCall)=>{c.questions[0]!.options[1]!.label='All 7 dimensions';},
|
||||
(c:NativePlanQuestionCall)=>{c.questions[0]!.question=c.questions[0]!.question.replace("ELI10: I've rated this plan", "ELI10: Earlier: I've rated this plan");},
|
||||
(c:NativePlanQuestionCall)=>{c.questions[0]!.question=c.questions[0]!.question.replace("rated this plan", "rated this error message");},
|
||||
]) { const f=phaseMutation77(1,mutate);expect(designStep0Boundary(f)).toBe(false);expect(isDesignCountSetup(f)).toBe(false); }
|
||||
const f=nativePlanCallFingerprint(phaseCalls77()[1]!,0,true);
|
||||
for(const changed of [{...f,signature:'foreign:tool'},{...f,nativeQuestionIndex:1},{...f,options:[...f.options].reverse()}]) {
|
||||
expect(designStep0Boundary(changed)).toBe(false);expect(isDesignCountSetup(changed)).toBe(false);
|
||||
}
|
||||
});
|
||||
|
||||
for (const suffix of ['Also approve deployment.', 'Approve all findings.', 'Continue the review and deploy to production.', 'Review while deleting the API.'])
|
||||
for (const location of ['question', 'option'] as const) for (const index of [1, 2])
|
||||
test(`native setup rejects mixed current action in ${location}: ${suffix} (${index})`, () => {
|
||||
const f = phaseMutation77(index, c => {
|
||||
if (location === 'question') c.questions[0]!.question += '\n' + suffix;
|
||||
else c.questions[0]!.options[0]!.description += ' ' + suffix;
|
||||
});
|
||||
expect(designStep0Boundary(f)).toBe(false); expect(isDesignCountSetup(f)).toBe(false);
|
||||
});
|
||||
for (const index of [1, 2]) test(`native setup rejects contradictory duplicate source (${index})`, () => {
|
||||
const f = phaseMutation77(index, c => { c.questions[0]!.question += '\nProject/branch/task: plan-design-review of OTHER.md.'; });
|
||||
expect(designStep0Boundary(f)).toBe(false); expect(isDesignCountSetup(f)).toBe(false);
|
||||
});
|
||||
for (const index of [1, 2]) test(`native setup allows quoted examples and negative consequences without approving them (${index})`, () => {
|
||||
const f = phaseMutation77(index, c => {
|
||||
c.questions[0]!.question += '\nExample of a later finding: "Approve deployment." This scope choice does not approve that action.';
|
||||
c.questions[0]!.options[0]!.description += ' ❌ This does not approve deployment. Example: “Approve all findings.”';
|
||||
});
|
||||
expect(designStep0Boundary(f)).toBe(true); expect(isDesignCountSetup(f)).toBe(true);
|
||||
});
|
||||
|
||||
for (const index of [1, 2]) for (const suffix of ['Also approve the design system.', 'Implement the first dimension.'])
|
||||
test(`native setup rejection cannot fall through to a legacy boundary (${index}): ${suffix}`, () => {
|
||||
const f = phaseMutation77(index, c => { c.questions[0]!.question += '\n' + suffix; });
|
||||
expect(designStep0Boundary(f)).toBe(false); expect(isDesignCountSetup(f)).toBe(false);
|
||||
});
|
||||
|
||||
|
||||
const cf74 = fixture.cf74Retry;
|
||||
function cf74Calls() { return structuredClone(cf74.transcript.calls) as NativePlanQuestionCall[]; }
|
||||
|
||||
function cf74Completion() {
|
||||
const dir=fs.mkdtempSync(path.join(os.tmpdir(),'design-cf74-completion-'));
|
||||
const file=path.join(dir,path.basename(cf74.provenance.planPath));
|
||||
@@ -288,75 +95,10 @@ function cf74Completion() {
|
||||
write();
|
||||
return {dir,file,transcript,final,startedAt,write,check:()=>hasNativePlanTerminal(transcript,file,startedAt,'completion_summary'),cleanup:()=>fs.rmSync(dir,{recursive:true,force:true})};
|
||||
}
|
||||
test('cf74 complete current styling decision starts the seven acknowledged review choices',()=>{
|
||||
const input=cf74Calls();let started=false;const counts={step0:0,review:0,administrative:0};
|
||||
expect(isDesignCountFirstReview(fp(input[0]!))).toBe(true);
|
||||
for(const call of input){const p=planCountQuestionPhase(fp(call),started,designStep0Boundary,isDesignCountFirstReview,isDesignCountSetup,isDesignCompletionHandoff);counts[p.administrative?'administrative':p.preReview?'step0':'review']++;started=p.reviewStarted;}
|
||||
expect(counts).toEqual({step0:0,review:7,administrative:0});
|
||||
expect(counts.review).toBeGreaterThanOrEqual(4);expect(counts.review).toBeLessThanOrEqual(7);
|
||||
});
|
||||
|
||||
test('cf74 actual completed native report envelope binds the fresh owned Design report',()=>{
|
||||
const f=cf74Completion();try{expect(f.check()).toBe(true);}finally{f.cleanup();}
|
||||
});
|
||||
|
||||
const changeCf74=(change:(q:NativePlanQuestionCall['questions'][number])=>void)=>{
|
||||
const call=cf74Calls()[0]!,q=call.questions[0]!;change(q);call.answers={[q.question]:q.options[0]!.label};return call;
|
||||
};
|
||||
for(const primary of ['Save','Submit'])for(const peerOrder of ['Reset, Cancel, Export','Export, Cancel, Reset'])for(const prefix of ['Matches DESIGN.md exactly','Apply DESIGN.md tokens','Use DESIGN.md'])
|
||||
test(`cf74 complete attributed styling keeps named role ownership: ${primary}/${peerOrder}/${prefix}`,()=>{
|
||||
const call=changeCf74(q=>{q.question=q.question.replaceAll('Save',primary);q.options.forEach(o=>{o.label=o.label.replaceAll('Save',primary);o.description=o.description?.replaceAll('Save',primary);});
|
||||
q.options[0]!.description=q.options[0]!.description!.replace('Matches DESIGN.md exactly',prefix).replace('Reset, Cancel, Export',peerOrder);});
|
||||
for(const chosen of call.questions[0]!.options){call.answers={[call.questions[0]!.question]:chosen.label};expect(isDesignCountFirstReview(fp(call))).toBe(true);}
|
||||
});
|
||||
for(const [name,change] of Object.entries({
|
||||
'foreign current source':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replaceAll('DESIGN.md','OTHER.md');},
|
||||
'quoted source':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replaceAll('DESIGN.md','"DESIGN.md"');},
|
||||
'duplicate source field':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nProject/branch/task: another source.';},
|
||||
'foreign owner':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nThis finding belongs to another project.';},
|
||||
'historical premise':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('ELI10: Right now','ELI10: Historically');},
|
||||
'quoted premise':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace(/ELI10: (.+)/,'ELI10: "$1"');},
|
||||
'single-quoted premise':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace(/ELI10: (.+)/,"ELI10: '$1'");},
|
||||
'quoted entire question':(q:NativePlanQuestionCall['questions'][number])=>{q.question='> '+q.question.replaceAll('\n','\n> ');},
|
||||
'no current equal-weight defect':(q:NativePlanQuestionCall['questions'][number])=>{q.question=q.question.replace('look identical','already have distinct correct styles');},
|
||||
'withdrawn issue':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nThis issue is withdrawn.';},
|
||||
'quoted current withdrawn status':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nThis issue is "withdrawn".';},
|
||||
'single quoted withdrawn status':(q:NativePlanQuestionCall['questions'][number])=>{q.question+="\nThis issue is 'withdrawn'.";},
|
||||
'withdrawn contract':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nThe DESIGN.md contract is no longer current.';},
|
||||
'wrong issue header':(q:NativePlanQuestionCall['questions'][number])=>{q.header='Issue 2';},
|
||||
'setup header':(q:NativePlanQuestionCall['questions'][number])=>{q.header='Focus';},
|
||||
'foreign option IDs':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.label=q.options[0]!.label.replace('1A','2A');},
|
||||
'missing primary styling':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description='✅ Matches DESIGN.md exactly. ❌ Work required.';},
|
||||
'foreign primary styling':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('Save #','Publish #');},
|
||||
'foreign peer styling':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('Reset, Cancel, Export','Reset, Cancel, Download');},
|
||||
'missing peer':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('Reset, Cancel, Export','Reset, Cancel');},
|
||||
'duplicate peer':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('Reset, Cancel, Export','Reset, Reset, Export');},
|
||||
'primary also a ghost':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('Reset, Cancel, Export','Reset, Cancel, Save');},
|
||||
'quoted remedy':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description='"'+q.options[0]!.description+'"';},
|
||||
'conditional remedy':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description+=' If approved, apply these styles.';},
|
||||
'withdrawn remedy':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description+=' This option is withdrawn.';},
|
||||
'withdrawn quoted remedy status':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description+=' This option is "withdrawn".';},
|
||||
'cancelled styling':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description+=' Do not apply these styles.';},
|
||||
'missing retained violation':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description='This closes the hierarchy gap completely.';},
|
||||
'quoted retained violation':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description='"'+q.options[2]!.description+'"';},
|
||||
'conditional retained violation':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description+=' If approved, leave the gap open.';},
|
||||
'withdrawn retained violation':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description+=' This option is withdrawn.';},
|
||||
'foreign retained violation':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description+=' This deferral belongs to another project.';},
|
||||
}))test(`cf74 current style rejects ${name}`,()=>{expect(isDesignCountFirstReview(fp(changeCf74(change)))).toBe(false);});
|
||||
test('cf74 current styling still requires its own complete native answer and identities',()=>{
|
||||
for(const change of [
|
||||
(c:NativePlanQuestionCall)=>{c.answered=false;},(c:NativePlanQuestionCall)=>{c.failed=true;},
|
||||
(c:NativePlanQuestionCall)=>{c.answers={};},(c:NativePlanQuestionCall)=>{c.unansweredQuestionIndices=[0];},
|
||||
(c:NativePlanQuestionCall)=>{c.answeredAt='invalid';},(c:NativePlanQuestionCall)=>{c.sessionId='';},
|
||||
(c:NativePlanQuestionCall)=>{c.questions.push(structuredClone(c.questions[0]!));},
|
||||
(c:NativePlanQuestionCall)=>{c.questions[0]!.options.push(structuredClone(c.questions[0]!.options[0]!));},
|
||||
]){const call=cf74Calls()[0]!;change(call);expect(isDesignCountFirstReview(fp(call))).toBe(false);}
|
||||
const f=fp(cf74Calls()[0]!);expect(isDesignCountFirstReview({...f,signature:'foreign:call'})).toBe(false);
|
||||
});
|
||||
test('cf74 first eight-review failure remains eight with no threshold or TODO exclusion change',()=>{
|
||||
let started=false;const counts={setup:0,review:0,administrative:0};
|
||||
for(const call of cf74.firstFailureCalls as NativePlanQuestionCall[]){const p=planCountQuestionPhase(fp(call),started,designStep0Boundary,isDesignCountFirstReview,isDesignCountSetup,isDesignCompletionHandoff);counts[p.administrative?'administrative':p.preReview?'setup':'review']++;started=p.reviewStarted;}
|
||||
expect(counts).toEqual({setup:2,review:8,administrative:0});expect(counts.review).toBeGreaterThan(7);
|
||||
});
|
||||
for(const heading of ['## Completion report','### Completion summary','## Completion'])for(const field of ['Plan written:','Plan saved:','Plan written to'])
|
||||
test(`cf74 complete typed delivery: ${heading}/${field}`,()=>{
|
||||
const f=cf74Completion();try{f.final.text=f.final.text.replace('## Completion report',heading).replace('Plan written:',field);expect(f.check()).toBe(true);}finally{f.cleanup();}
|
||||
@@ -393,43 +135,3 @@ test('cf74 typed envelope cannot bypass fresh own Design report and native chron
|
||||
const target=path.join(f.dir,'other.md');fs.writeFileSync(target,cf74.report);fs.symlinkSync(target,f.file);expect(f.check()).toBe(false);
|
||||
}finally{f.cleanup();}
|
||||
});
|
||||
|
||||
for(const [name,change] of Object.entries({
|
||||
'mismatched source color':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('#1d4ed8','#aa0000');},
|
||||
'mismatched source foreground':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description=q.options[0]!.description!.replace('white text','black text');},
|
||||
'unrelated additional approval':(q:NativePlanQuestionCall['questions'][number])=>{q.options[0]!.description+=' Also approve deployment.';},
|
||||
'unrelated extra question action':(q:NativePlanQuestionCall['questions'][number])=>{q.question+='\nThen delete the audit log.';},
|
||||
'retained option actually fixes':(q:NativePlanQuestionCall['questions'][number])=>{q.options[2]!.description+=' This option resolves the hierarchy gap.';},
|
||||
}))test(`cf74 complete role transfer rejects ${name}`,()=>expect(isDesignCountFirstReview(fp(changeCf74(change)))).toBe(false));
|
||||
test('cf74 concrete token identity is source-owned rather than fixed to one palette',()=>{
|
||||
const call=changeCf74(q=>{q.question=q.question.replaceAll('#1d4ed8','#234567').replaceAll('white text','black text');q.options.forEach(o=>{o.description=o.description?.replaceAll('#1d4ed8','#234567').replaceAll('white text','black text');});});
|
||||
expect(isDesignCountFirstReview(fp(call))).toBe(true);
|
||||
});
|
||||
|
||||
for(const field of ['question','option'] as const)for(const action of ['Also implement a webhook handler.','Then replace the database.'])
|
||||
test(`cf74 peer extra work rejects ${field}/${action}`,()=>{
|
||||
const call=changeCf74(q=>{if(field==='question')q.question+='\n'+action;else q.options[0]!.description+=' '+action;});
|
||||
expect(isDesignCountFirstReview(fp(call))).toBe(false);
|
||||
});
|
||||
|
||||
for(const field of ['question','option','opposed'] as const)for(const [prefix,work]of [
|
||||
['Also ','build a webhook handler'],['Then ','migrate the database'],['Please ','configure a new service'],
|
||||
['Next ','install the worker'],['Now ','rewrite the API'],['First ','create an audit endpoint'],
|
||||
['and ','add a billing screen'],['but ','remove the login check'],['while ','launch a second deployment'],
|
||||
] as const)test(`cf74 imperative work class rejects ${field}/${prefix}${work}`,()=>{
|
||||
const call=changeCf74(q=>{const action=prefix+work+'.';if(field==='question')q.question+='\n'+action;else q.options[field==='option'?0:2]!.description+=' '+action;});
|
||||
expect(isDesignCountFirstReview(fp(call))).toBe(false);
|
||||
});
|
||||
for(const field of ['question','option'] as const)for(const text of [
|
||||
'The implementation may replace an existing button variant.',
|
||||
'Replacing the style makes the primary action clearer.',
|
||||
'Do not implement a webhook handler.',
|
||||
'No database replacement belongs to this review.',
|
||||
'Historical note: "Also implement a webhook handler."',
|
||||
"Historical note: 'Then replace the database.'",
|
||||
'Previous example: `Also configure a worker.`',
|
||||
'\n> Also implement a webhook handler.',
|
||||
] as const)test(`cf74 imperative guard preserves explanation/history ${field}/${text}`,()=>{
|
||||
const call=changeCf74(q=>{if(field==='question')q.question+='\n'+text;else q.options[0]!.description+=' '+text;});
|
||||
expect(isDesignCountFirstReview(fp(call))).toBe(true);
|
||||
});
|
||||
Reference in new issue
Block a user