mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 10:26:52 +02:00
test: retire the finding-count cluster and trim its helpers (C)
- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
budget, never on skill behavior; delete them, their touchfile/tier ids,
AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
(11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
closure, and delete the free replay tests whose assertions exercised only
that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
only as input for a live subject keep their assertions: the multiSelect
default moved to plan-review-decisions, runner PTY tests use inline caller
policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
(its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
and per-finding cadence coverage with their re-entry tests.
This commit is contained in:
1 parent
53e7f3212f
commit
6415690a18
317 files changed
+315
-54111
No files matched your search
@@ -1,9 +1,6 @@
|
||||
import { describe, expect, test } from 'bun:test';
|
||||
import { capturePlanCountQuestion, nativePlanCallFingerprint, planCountPrerequisitePick, planCountQuestionInput } from './helpers/claude-pty-runner';
|
||||
import { pickCeoCountQuestion } from './helpers/ceo-approach-pick';
|
||||
import type { NativePlanQuestionCall } from './helpers/plan-count-transcript';
|
||||
import paired from './fixtures/ceo-approach-r-call.json';
|
||||
import distinct from './fixtures/ceo-approach-r-distinct-call.json';
|
||||
import prerequisite from './fixtures/dx-prerequisite-r-call.json';
|
||||
|
||||
function pending(source: NativePlanQuestionCall): NativePlanQuestionCall {
|
||||
@@ -22,25 +19,6 @@ function frame(call: NativePlanQuestionCall) {
|
||||
}
|
||||
|
||||
describe('captured R planning navigation', () => {
|
||||
test('distinct CEO selects its third recommended approach without seed-word matching', () => {
|
||||
const call = pending(distinct as NativePlanQuestionCall);
|
||||
const { visible, active, routing } = frame(call);
|
||||
expect(distinct.answers[distinct.questions[0]!.question]).toBe(distinct.questions[0]!.options[0]!.label);
|
||||
const pick = pickCeoCountQuestion(routing, active) ?? 1;
|
||||
expect(pick).toBe(3);
|
||||
expect(planCountQuestionInput(visible, active, pick)).toBe('3');
|
||||
});
|
||||
|
||||
test('paired CEO follows the offered recommendation instead of accepting vague assertions', () => {
|
||||
const call = pending(paired as NativePlanQuestionCall);
|
||||
const { visible, active, routing } = frame(call);
|
||||
expect(active.nativeCall).toBe(call);
|
||||
expect(paired.answers[paired.questions[0]!.question]).toBe(paired.questions[0]!.options[0]!.label);
|
||||
const pick = pickCeoCountQuestion(routing, active) ?? 1;
|
||||
expect(pick).toBe(2);
|
||||
expect(planCountQuestionInput(visible, active, pick)).toBe('2');
|
||||
});
|
||||
|
||||
test('DX declines its optional office-hours detour using the full native option meaning', () => {
|
||||
const call = pending(prerequisite as NativePlanQuestionCall);
|
||||
const { visible, active, routing } = frame(call);
|
||||
@@ -50,19 +28,6 @@ describe('captured R planning navigation', () => {
|
||||
expect(pick).toBe(2);
|
||||
expect(planCountQuestionInput(visible, active, pick)).toBe('2');
|
||||
});
|
||||
|
||||
test('CEO routing id and selector wording vary independently of option content and order', () => {
|
||||
for (const id of ['plan-ceo-approach', 'plan-ceo-review-approach', 'plan-ceo-approach-selection', 'plan-ceo-review-approach-selection']) {
|
||||
for (const verb of ['use', 'follow']) {
|
||||
const call = pending(paired as NativePlanQuestionCall);
|
||||
call.questions[0]!.question = `Which implementation approach should this plan ${verb}? <gstack-qid:${id}>`;
|
||||
call.questions[0]!.options = [{ label: 'Existing renderer (Recommended)' }, { label: 'Custom renderer' }];
|
||||
const { active, routing } = frame(call);
|
||||
expect(pickCeoCountQuestion(routing, active)).toBe(1);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
test('short prerequisite labels require the current native question and affirmative review action', () => {
|
||||
for (const change of [
|
||||
(c: NativePlanQuestionCall) => { c.questions[0]!.options[1]!.description = ''; },
|
||||
|
||||
Reference in new issue
Block a user