test: retire the finding-count cluster and trim its helpers (C)

- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
  skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
  budget, never on skill behavior; delete them, their touchfile/tier ids,
  AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
  (11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
  closure, and delete the free replay tests whose assertions exercised only
  that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
  only as input for a live subject keep their assertions: the multiSelect
  default moved to plan-review-decisions, runner PTY tests use inline caller
  policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
  (its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
  and per-finding cadence coverage with their re-entry tests.
This commit is contained in:
garrytan committed 2026-09-29 06:08:49 +00:00
1 parent 53e7f3212f
commit 6415690a18
317 files changed
+315 -54111

No files matched your search

+1 -21
View File
@@ -49,9 +49,7 @@ describe('native prerequisite review-now offer', () => {
test('the captured prerequisite regression selects its exact counting and mode consumers', () => {
// Floor checks also seed a plan, but never pick a prerequisite answer.
const expected = [
'autoplan-chain-pty', 'plan-ceo-finding-count', 'plan-ceo-mode-routing',
'plan-ceo-split-overflow', 'plan-design-finding-count', 'plan-design-with-ui-scope', 'plan-devex-finding-count',
'plan-eng-finding-count', 'plan-eng-multi-finding-batching',
'plan-ceo-mode-routing', 'plan-ceo-split-overflow', 'plan-design-with-ui-scope', 'plan-eng-multi-finding-batching',
].sort();
for (const dependency of ['test/plan-count-prerequisite-n.test.ts', 'test/fixtures/ceo-prerequisite-n-call.json', 'test/fixtures/eng-prerequisite-77.json']) {
const consumers = Object.entries(E2E_TOUCHFILES).filter(([, paths]) => paths.includes(dependency));
@@ -66,9 +64,6 @@ describe('native prerequisite review-now offer', () => {
import engPrerequisite77 from './fixtures/eng-prerequisite-77.json';
import { planCountQuestionInput } from './helpers/claude-pty-runner';
import { nextCeoModeNavigation } from './helpers/ceo-mode-option';
import { autoplanSetupDecision } from './helpers/autoplan-setup-question';
import type { NativePlanQuestionCall } from './helpers/plan-count-transcript';
function engPrerequisitePending(): NativePlanQuestionCall {
@@ -93,21 +88,6 @@ function engPrerequisiteFrame(native: NativePlanQuestionCall, index = 0) {
}
describe('optional Office Hours decision briefs', () => {
test('actual acknowledged detour is preserved; the current caller should choose standard review', () => {
const actual = engPrerequisite77.completedCall;
expect(actual.answered).toBe(true);
expect(actual.answers[actual.questions[0]!.question]).toBe('Run /office-hours now');
const { screen, active, routing } = engPrerequisiteFrame(engPrerequisitePending());
// This is runPlanSkillCounting's exact precedence with no caller override.
const pick = planCountPrerequisitePick(routing, active) ?? 1;
expect(pick).toBe(2);
expect(planCountQuestionInput(screen, active, pick)).toBe('2');
const ceo = nextCeoModeNavigation(screen, 'HOLD SCOPE', new Set(), active.nativeCall);
expect(ceo.kind).toBe('question');
if (ceo.kind === 'question') expect(ceo.index).toBe(2);
expect(autoplanSetupDecision(screen, new Set(), active.nativeCall).kind).toBe('input');
});
test('optional action is independent of header, numbering, recommendation and order', () => {
for (const reverse of [false, true]) for (const recommended of ['run', 'skip', 'neither']) {
const native = engPrerequisitePending(), q = native.questions[0]!;