mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-02 17:40:02 +02:00
test: retire the finding-count cluster and trim its helpers (C)
- C0/C1: the five never-green evals (skill-e2e-autoplan-chain and
skill-e2e-plan-{ceo,eng,design,devex}-finding-count) failed on harness and
budget, never on skill behavior; delete them, their touchfile/tier ids,
AUTOPLAN_CHAIN_BUDGET and the dedicated eighth periodic slice (--slices 7).
- C2: delete the helper groups whose only paid consumers were those files
(11 modules), trim claude-pty-runner and eng-seeded-coverage to the paid
closure, and delete the free replay tests whose assertions exercised only
that dead code (89 files, 135 orphaned fixtures). Blocks that used dead code
only as input for a live subject keep their assertions: the multiSelect
default moved to plan-review-decisions, runner PTY tests use inline caller
policies, and the timer-safe budget checks moved to eng-finding-retry-budget.
- The eight production-touching files stay except ceo-current-decision-record
(its template read only feeds the retired counter).
- CARVE_GUARDS.autoplan is behavioral 'none'; TODOS records the lost chain
and per-finding cadence coverage with their re-entry tests.
This commit is contained in:
1 parent
53e7f3212f
commit
6415690a18
317 files changed
+315
-54111
No files matched your search
+4
-13
@@ -88,7 +88,6 @@ describe('selectTests', () => {
|
||||
expect(result.reason).toBe('diff');
|
||||
expect(result.selected.sort()).toEqual([...new Set([...consumers, ...existing])].sort());
|
||||
expect(result.selected).toContain('plan-eng-review');
|
||||
expect(result.selected).toContain('plan-eng-finding-count');
|
||||
expect(result.selected).not.toContain('plan-ceo-review-prosons-cadence');
|
||||
expect(result.selected).not.toContain('outside-plan-disabled-no-fallback');
|
||||
});
|
||||
@@ -103,12 +102,8 @@ describe('selectTests', () => {
|
||||
'Design artifact dependencies select their native consumers: %s', (file) => {
|
||||
const result = selectTests([file], E2E_TOUCHFILES);
|
||||
expect(result.reason).toBe('diff');
|
||||
expect(result.selected).toContain('plan-design-finding-count');
|
||||
expect(result.selected).toContain('plan-design-with-ui-scope');
|
||||
if (file !== 'bin/gstack-slug') expect(result.selected).toContain('autoplan-chain-pty');
|
||||
expect(E2E_TIERS['plan-design-finding-count']).toBe('periodic');
|
||||
expect(E2E_TIERS['plan-design-with-ui-scope']).toBe('gate');
|
||||
expect(E2E_TIERS['autoplan-chain-pty']).toBe('periodic');
|
||||
},
|
||||
);
|
||||
|
||||
@@ -165,8 +160,8 @@ describe('selectTests', () => {
|
||||
const actual = selectTests(['scripts/resolvers/testing.ts'], E2E_TOUCHFILES);
|
||||
expect(actual.reason).toBe('diff');
|
||||
expect(actual.selected.sort()).toEqual(expected);
|
||||
for (const id of ['plan-eng-finding-count', 'plan-eng-multi-finding-batching',
|
||||
'autoplan-chain-pty', 'plan-eng-review-format-coverage', 'ship-section-loading', 'qa-fix-loop']) {
|
||||
for (const id of ['plan-eng-multi-finding-batching',
|
||||
'plan-eng-review-format-coverage', 'ship-section-loading', 'qa-fix-loop']) {
|
||||
expect(actual.selected).toContain(id);
|
||||
expect(E2E_TIERS[id]).toBe('periodic');
|
||||
}
|
||||
@@ -351,11 +346,8 @@ describe('selectTests', () => {
|
||||
// v1.13.x real-PTY E2E batch entries that also depend on plan-ceo-review/**
|
||||
expect(result.selected).toContain('auq-format-gate');
|
||||
expect(result.selected).toContain('plan-ceo-mode-routing');
|
||||
expect(result.selected).toContain('autoplan-chain-pty');
|
||||
// The dual-voice fixture loads the CEO skill as its Phase 1 dependency.
|
||||
expect(result.selected).toContain('autoplan-dual-voice');
|
||||
// Per-finding count + review-report-at-bottom (v1.21.x)
|
||||
expect(result.selected).toContain('plan-ceo-finding-count');
|
||||
// v1.22+ AskUserQuestion-blocked regression: auto-decide-preserved
|
||||
// also depends on plan-ceo-review/** (autoplan-auto-mode test was
|
||||
// removed in v1.28 — see commit message for the rationale).
|
||||
@@ -369,8 +361,8 @@ describe('selectTests', () => {
|
||||
// v2 plan Phase B carve: the section-loading E2E depends on plan-ceo-review/**.
|
||||
expect(result.selected).toContain('plan-ceo-section-loading');
|
||||
expect(result.selected).toContain('outside-plan-disabled-no-fallback');
|
||||
expect(result.selected.length).toBe(23);
|
||||
expect(result.skipped.length).toBe(Object.keys(E2E_TOUCHFILES).length - 23);
|
||||
expect(result.selected.length).toBe(21);
|
||||
expect(result.skipped.length).toBe(Object.keys(E2E_TOUCHFILES).length - 21);
|
||||
});
|
||||
|
||||
test('global touchfile triggers ALL tests', () => {
|
||||
@@ -389,7 +381,6 @@ describe('selectTests', () => {
|
||||
])('live runtime dependency selects PTY consumers: %s', (file) => {
|
||||
const result = selectTests([file], E2E_TOUCHFILES);
|
||||
expect(result.reason).toBe('diff');
|
||||
expect(result.selected).toContain('autoplan-chain-pty');
|
||||
expect(result.selected).toContain('plan-ceo-mode-routing');
|
||||
expect(result.selected).not.toContain('retro');
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user