From 67a3c22e36d56c510ab36a1553894b0736842e9d Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 23 Mar 2026 16:11:33 -0700 Subject: [PATCH] fix: quote variables in evals PR comment step for shellcheck SC2086 shellcheck disable directives in GitHub Actions run blocks only cover the next command, not the entire script. Quote $COMMENT_ID and PR number variables directly instead. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/evals.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/evals.yml b/.github/workflows/evals.yml index 162ee8f0..81ba1f7b 100644 --- a/.github/workflows/evals.yml +++ b/.github/workflows/evals.yml @@ -207,8 +207,8 @@ jobs: --jq '.[] | select(.body | startswith("## E2E Evals")) | .id' | tail -1) if [ -n "$COMMENT_ID" ]; then - gh api repos/${{ github.repository }}/issues/comments/$COMMENT_ID \ + gh api "repos/${{ github.repository }}/issues/comments/${COMMENT_ID}" \ -X PATCH -f body="$BODY" else - gh pr comment ${{ github.event.pull_request.number }} --body "$BODY" + gh pr comment "${{ github.event.pull_request.number }}" --body "$BODY" fi