From 6813d10fd52d484aae78fb7c4334f7ea85921d6f Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Tue, 14 Apr 2026 10:52:29 -0700 Subject: [PATCH] feat: wire slop:diff into /review as advisory diagnostic Adds Step 3.5 to the review template: runs bun run slop:diff against the base branch to catch AI code quality issues (empty catches, redundant return await, overcomplicated abstractions). Advisory only, never blocking. Skips silently if slop-scan is not installed. Co-Authored-By: Claude Opus 4.6 (1M context) --- review/SKILL.md.tmpl | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/review/SKILL.md.tmpl b/review/SKILL.md.tmpl index 9ccb1ec2..a38e0f7f 100644 --- a/review/SKILL.md.tmpl +++ b/review/SKILL.md.tmpl @@ -69,6 +69,19 @@ git fetch origin --quiet Run `git diff origin/` to get the full diff. This includes both committed and uncommitted changes against the latest base branch. +## Step 3.5: Slop scan (advisory) + +Run a slop scan on changed files to catch AI code quality issues (empty catches, +redundant `return await`, overcomplicated abstractions): + +```bash +bun run slop:diff origin/ 2>/dev/null || true +``` + +If findings are reported, include them in the review output as an informational +diagnostic. Slop findings are advisory, never blocking. If slop:diff is not +available (e.g., slop-scan not installed), skip this step silently. + --- {{LEARNINGS_SEARCH}}