mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-01 10:50:39 +02:00
refactor(test): mechanical sweep — 298 paid-test timeouts onto eval-budget tiers
69 files, both shapes (trailing bun-test budgets and runner timeout/timeoutMs options), ROUND-UP ONLY so nothing that passed can start failing: 75 → JUDGE_MS, 137 → CAPTURE_MS, 74 → CAPTURE_LONG_MS, 9 → PTY_MS, 3 → PTY_LONG_MS. Raw >=60s literal count in the paid scope: 395 → 97, of which 51 are non-timeout noise (fixture dates, run IDs) and 46 are enumerated justified holds (comment-carrying calibrated budgets, poll-loop constants, utility spawn waits, and the seven physical-ceiling 1_500_000 sites). The eval-budgets policy ratchet keeps the residue from regrowing. Known collapse: where an inner runner budget and its enclosing test budget now share a tier, the old stagger is gone — an overrun surfaces as a bun test timeout instead of a graceful runner timeout (diagnosability trade, not a correctness one). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
74ae357e0f
commit
6841183c35
@@ -1,4 +1,5 @@
|
||||
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
|
||||
import { JUDGE_MS, CAPTURE_MS } from './helpers/eval-budgets';
|
||||
import { runSkillTest } from './helpers/session-runner';
|
||||
import {
|
||||
ROOT, browseBin, runId, evalsEnabled, selectedTests,
|
||||
@@ -66,7 +67,7 @@ Run /review on the current diff (git diff main...HEAD).
|
||||
Write your review findings to ${reviewDir}/review-output.md`,
|
||||
workingDirectory: reviewDir,
|
||||
maxTurns: 20,
|
||||
timeout: 180_000,
|
||||
timeout: CAPTURE_MS,
|
||||
testName: 'review-sql-injection',
|
||||
runId,
|
||||
});
|
||||
@@ -89,7 +90,7 @@ Write your review findings to ${reviewDir}/review-output.md`,
|
||||
reviewContent.includes('unsanitized');
|
||||
expect(hasSqlContent).toBe(true);
|
||||
}
|
||||
}, 210_000);
|
||||
}, CAPTURE_MS);
|
||||
});
|
||||
|
||||
// --- Review: Enum completeness E2E ---
|
||||
@@ -144,7 +145,7 @@ Write your review findings to ${enumDir}/review-output.md
|
||||
The diff adds a new "returned" status to the Order model. Your job is to check if all consumers handle it.`,
|
||||
workingDirectory: enumDir,
|
||||
maxTurns: 15,
|
||||
timeout: 90_000,
|
||||
timeout: JUDGE_MS,
|
||||
testName: 'review-enum-completeness',
|
||||
runId,
|
||||
});
|
||||
@@ -164,7 +165,7 @@ The diff adds a new "returned" status to the Order model. Your job is to check i
|
||||
expect(mentionsReturned).toBe(true);
|
||||
expect(mentionsEnum || mentionsCritical).toBe(true);
|
||||
}
|
||||
}, 120_000);
|
||||
}, JUDGE_MS);
|
||||
});
|
||||
|
||||
// --- Review: Design review lite E2E ---
|
||||
@@ -229,7 +230,7 @@ Write your review findings to ${designDir}/review-output.md
|
||||
Important: The design checklist should catch issues like blacklisted fonts, small font sizes, outline:none, !important, AI slop patterns (purple gradients, generic hero copy, 3-column feature grid), etc.`,
|
||||
workingDirectory: designDir,
|
||||
maxTurns: 35,
|
||||
timeout: 240_000,
|
||||
timeout: CAPTURE_MS,
|
||||
testName: 'review-design-lite',
|
||||
runId,
|
||||
});
|
||||
@@ -262,7 +263,7 @@ Important: The design checklist should catch issues like blacklisted fonts, smal
|
||||
console.log(`Design review detected ${detected}/7 planted issues`);
|
||||
expect(detected).toBeGreaterThanOrEqual(4);
|
||||
}
|
||||
}, 300_000);
|
||||
}, CAPTURE_MS);
|
||||
});
|
||||
|
||||
// Base branch detection tests for review/ship + the Review Dashboard Via
|
||||
|
||||
Reference in New Issue
Block a user