CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-15 09:25:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(browse): SIGKILL abandoned Chromium on close-race timeout (suite wedge)

Browse Source 
close()'s launched-mode path raced browser.close() against 5s and on
timeout ABANDONED the child: this.browser nulled, process handle lost,
Chromium alive holding keep-alive connections into test servers whose
stop() then waits forever. Reproduced twice as an intermittent (~50%)
whole-suite wedge — a 44min 0.1%-CPU hang pinned by a leaked LISTEN
socket, and a 400s hang with commands.test.ts teardown in flight.

The child handle is now captured BEFORE the race and SIGKILLed on
race-timeout (launched mode only; headed keeps context.close). Race
timers are unref'd so a successful close stops pinning the caller's
event loop for the window. The four browse test servers force-close
keep-alives (stop(true)) as belt-and-braces.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-15 09:50:19 -07:00
co-authored by Claude Fable 5
parent 576112e7cf
commit 6a2e589cbd
5 changed files with 25 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browse/src/browser-manager.ts
+21 -6
View File
@@ -727,6 +727,12 @@ export class BrowserManager {
}
async close() {
// unref'd race timer: without unref, every successful close still pins
// the caller's event loop for the full window.
const raceTimeout = (ms: number) => new Promise<false>((resolve) => {
const t = setTimeout(() => resolve(false), ms);
(t as { unref?: () => void }).unref?.();
});
if (this.browser || (this.connectionMode === 'headed' && this.context)) {
if (this.connectionMode === 'headed') {
// Headed/persistent context mode: close the context (which closes the browser)
@@ -734,15 +740,24 @@ export class BrowserManager {
if (this.browser) this.browser.removeAllListeners('disconnected');
await Promise.race([
this.context ? this.context.close() : Promise.resolve(),
new Promise(resolve => setTimeout(resolve, 5000)),
raceTimeout(5000),
]).catch(() => {});
} else {
// Launched mode: close the browser we spawned
// Launched mode: close the browser we spawned.
this.browser.removeAllListeners('disconnected');
await Promise.race([
this.browser.close(),
new Promise(resolve => setTimeout(resolve, 5000)),
]).catch(() => {});
// Grab the child handle BEFORE the race: nulling this.browser after a
// race-timeout used to ABANDON a live Chromium whose sockets kept the
// caller's event loop (and keep-alive connections into test servers)
// open forever — the intermittent whole-suite wedge. If graceful close
// doesn't finish in time, the child gets SIGKILL, not freedom.
const child = this.browser.process?.();
const closed = await Promise.race([
this.browser.close().then(() => true as const),
raceTimeout(5000),
]).catch(() => false as const);
if (closed === false && child && child.exitCode === null && !child.killed) {
try { child.kill('SIGKILL'); } catch { /* already gone */ }
}
}
this.browser = null;
}