mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 18:36:54 +02:00
test(section-loading): record the CEO capture's report and transcript
The 6fcb0981 census failed hasStaleFillRaceFinding (line 98), but the case
records nothing beyond junit, so the report the detector judged is gone.
Return the SkillTestResult from captureSectionReads and record it, with the
full saved report, through the eval collector on pass and fail.
This commit is contained in:
1 parent
7eaefdec59
commit
6a4d54fc55
2 files changed
+34
-20
No files matched your search
@@ -253,7 +253,7 @@ export async function captureSectionReads(opts: {
|
||||
nativeReviewOnly?: boolean;
|
||||
}): Promise<{ readSections: Set<string>; reportProduced: boolean; reportWritten: boolean;
|
||||
exitReason: SkillTestResult['exitReason']; toolCalls: SkillTestResult['toolCalls'];
|
||||
transcript: SkillTestResult['transcript']; output: string }> {
|
||||
transcript: SkillTestResult['transcript']; output: string; result: SkillTestResult }> {
|
||||
const outFile = path.join(opts.planDir, opts.reportFile ?? 'REPORT.md');
|
||||
const timeout = opts.timeout ?? 300_000;
|
||||
const fullPlanReview = opts.skillName === 'plan-ceo-review' || opts.skillName === 'plan-eng-review';
|
||||
@@ -358,7 +358,7 @@ ${fullPlanReview ? `- Save the evolving plan and review outputs to ${outFile} wi
|
||||
|
||||
// Keep successful terminal-output captures, but a draft left by a failed run
|
||||
// must never satisfy callers that use reportProduced as their completion gate.
|
||||
return { readSections, reportProduced, reportWritten, exitReason: result.exitReason, toolCalls: result.toolCalls, transcript: result.transcript, output };
|
||||
return { readSections, reportProduced, reportWritten, exitReason: result.exitReason, toolCalls: result.toolCalls, transcript: result.transcript, output, result };
|
||||
}
|
||||
|
||||
/** A completed CEO review needs its artifact and every summary outcome. */
|
||||
|
||||
Reference in new issue
Block a user