CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-28 15:41:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(benchmark): dedupe providers in --models

Browse Source 
`--models claude,claude,gpt` previously produced a list with a duplicate
entry, meaning the benchmark would run claude twice and bill for two
runs. Surfaced by /review on this branch.

Use a Set internally; return Array.from(seen) to preserve type + order
of first occurrence.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-04-18 06:53:52 +08:00
co-authored by Claude Opus 4.7
parent c875e0c3fc
commit 6a8b637669
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/gstack-model-benchmark
+3 -3
View File
@@ -54,14 +54,14 @@ function flag(name: string): boolean {
function parseProviders(s: string | undefined): Array<'claude' | 'gpt' | 'gemini'> { function parseProviders(s: string | undefined): Array<'claude' | 'gpt' | 'gemini'> {
if (!s) return ['claude']; if (!s) return ['claude'];
const out: Array<'claude' | 'gpt' | 'gemini'> = []; const seen = new Set<'claude' | 'gpt' | 'gemini'>();
for (const p of s.split(',').map(x => x.trim()).filter(Boolean)) { for (const p of s.split(',').map(x => x.trim()).filter(Boolean)) {
if (p === 'claude' || p === 'gpt' || p === 'gemini') out.push(p); if (p === 'claude' || p === 'gpt' || p === 'gemini') seen.add(p);
else { else {
console.error(`WARN: unknown provider '${p}' — skipping. Valid: claude, gpt, gemini.`); console.error(`WARN: unknown provider '${p}' — skipping. Valid: claude, gpt, gemini.`);
} }
} }
return out.length ? out : ['claude']; return seen.size ? Array.from(seen) : ['claude'];
} }
function resolvePrompt(positional: string | undefined): string { function resolvePrompt(positional: string | undefined): string {