CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-06 05:35:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: telemetry data integrity — source tagging, UUID fingerprint, duration guards

Browse Source 
- Add source field (live/test/dev) to telemetry pipeline: --source flag in
  gstack-telemetry-log, GSTACK_TELEMETRY_SOURCE env fallback, pass-through
  in telemetry-sync, source=eq.live filter on all dashboard queries
- Replace SHA-256 installation_id with UUID install_fingerprint for all tiers
  (not just community). Expand-contract migration: ADD new column + trigger
  to copy installation_id, preserving backward compat with old clients
- Fix duration bug: persist _TEL_START to file via $PPID (stable across bash
  blocks), cap durations at 86400s, reject negative values
- Ungate update-check pings from telemetry=off — sends only version + OS +
  random UUID. Generate .install-id in update-check for telemetry=off users
- Migration 003: source columns, install_fingerprint, duration CHECK
  constraint, indexes, recreated views with source filter, growth funnel
  (first-seen based), materialized views for daily installs + version adoption
- E2E test isolation: session-runner sets GSTACK_TELEMETRY_SOURCE=test
- 8 new telemetry tests (source field, duration caps, fingerprint persistence)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-23 15:48:25 -07:00
parent b437b531b7
commit 6bd6d5ba0f
8 changed files with 269 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/helpers/session-runner.ts
+1 -1
View File
@@ -176,7 +176,7 @@ export async function runSkillTest(options: {
cwd: workingDirectory,
stdout: 'pipe',
stderr: 'pipe',
env: { ...process.env, GSTACK_STATE_DIR: testStateDir },
env: { ...process.env, GSTACK_STATE_DIR: testStateDir, GSTACK_TELEMETRY_SOURCE: 'test' },
});
// Race against timeout
test/telemetry.test.ts
+69 -7
View File
@@ -72,33 +72,95 @@ describe('gstack-telemetry-log', () => {
expect(readJsonl()).toHaveLength(0);
});
test('includes installation_id for community tier', () => {
test('includes install_fingerprint for community tier (UUID)', () => {
setConfig('telemetry', 'community');
run(`${BIN}/gstack-telemetry-log --skill review --duration 100 --outcome success --session-id comm-123`);
const events = parseJsonl();
expect(events).toHaveLength(1);
// installation_id should be a SHA-256 hash (64 hex chars)
expect(events[0].installation_id).toMatch(/^[a-f0-9]{64}$/);
// install_fingerprint should be a UUID (lowercase)
expect(events[0].install_fingerprint).toMatch(/^[a-f0-9-]{36}$/);
});
test('installation_id is null for anonymous tier', () => {
test('includes install_fingerprint for anonymous tier (not null — UUID is not PII)', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --duration 50 --outcome success --session-id anon-123`);
const events = parseJsonl();
expect(events[0].installation_id).toBeNull();
// All tiers now get install_fingerprint (random UUID, not PII)
expect(events[0].install_fingerprint).toMatch(/^[a-f0-9-]{36}$/);
});
test('includes error_class when provided', () => {
test('source field defaults to live', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill browse --duration 10 --outcome error --error-class timeout --session-id err-123`);
run(`${BIN}/gstack-telemetry-log --skill qa --duration 50 --outcome success --session-id src-123`);
const events = parseJsonl();
expect(events[0].source).toBe('live');
});
test('--source flag overrides default', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --duration 50 --outcome success --source test --session-id src-456`);
const events = parseJsonl();
expect(events[0].source).toBe('test');
});
test('GSTACK_TELEMETRY_SOURCE env sets source', () => {
setConfig('telemetry', 'anonymous');
run(`GSTACK_TELEMETRY_SOURCE=test ${BIN}/gstack-telemetry-log --skill qa --duration 50 --outcome success --session-id src-789`);
const events = parseJsonl();
expect(events[0].source).toBe('test');
});
test('duration > 86400 is capped to null', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --duration 100000 --outcome success --session-id dur-123`);
const events = parseJsonl();
expect(events[0].duration_s).toBeNull();
});
test('negative duration is capped to null', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --duration -5 --outcome success --session-id dur-456`);
const events = parseJsonl();
expect(events[0].duration_s).toBeNull();
});
test('install_fingerprint persists across runs', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --duration 10 --outcome success --session-id fp-1`);
run(`${BIN}/gstack-telemetry-log --skill qa --duration 20 --outcome success --session-id fp-2`);
const events = parseJsonl();
expect(events).toHaveLength(2);
expect(events[0].install_fingerprint).toBe(events[1].install_fingerprint);
});
test('includes error_class, error_message, and failed_step when provided', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill browse --duration 10 --outcome error --error-class timeout --error-message "request timed out after 30s" --failed-step "goto_page" --session-id err-123`);
const events = parseJsonl();
expect(events[0].error_class).toBe('timeout');
expect(events[0].error_message).toBe('request timed out after 30s');
expect(events[0].failed_step).toBe('goto_page');
expect(events[0].outcome).toBe('error');
});
test('truncates long error messages', () => {
setConfig('telemetry', 'anonymous');
const longMsg = 'a'.repeat(300);
run(`${BIN}/gstack-telemetry-log --skill qa --outcome error --error-message "${longMsg}" --session-id trunc-123`);
const events = parseJsonl();
expect(events[0].error_message).toHaveLength(200);
});
test('handles missing duration gracefully', () => {
setConfig('telemetry', 'anonymous');
run(`${BIN}/gstack-telemetry-log --skill qa --outcome success --session-id nodur-123`);