mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-28 07:32:14 +02:00
v1.89.1.0 fix: remove continuous checkpoint commits (#2970)
* v1.89.1.0 fix: remove continuous checkpoint commits and repair validation blockers * fix: clarify shipping and engineering review recovery * fix: interpret native no-change review descriptions * test: separate descendant readiness from timeout delivery
This commit is contained in:
@@ -95,7 +95,7 @@ function keysReadInTree(root = ROOT): string[] {
|
||||
continue;
|
||||
}
|
||||
// Skip this file: its own prose cites example keys.
|
||||
if (ent.name === SELF) continue;
|
||||
if (ent.name === SELF || ent.name === 'CHANGELOG.md') continue;
|
||||
if (!/\.(md|ts|sh)$|^gstack-[a-z-]+$/.test(ent.name)) continue;
|
||||
let text: string;
|
||||
try {
|
||||
@@ -110,12 +110,29 @@ function keysReadInTree(root = ROOT): string[] {
|
||||
}
|
||||
|
||||
describe('gstack-config defaults (gate, free)', () => {
|
||||
test('retired checkpoint keys have no defaults or advertised configuration', () => {
|
||||
expect(fs.readFileSync(CONFIG_BIN, 'utf8')).not.toMatch(/checkpoint/i);
|
||||
for (const key of ['checkpoint_mode', 'checkpoint_push']) {
|
||||
expect(defaultArms()).not.toContain(key);
|
||||
expect(get(key)).toEqual({ out: '', code: 1 });
|
||||
}
|
||||
for (const command of ['list', 'defaults']) {
|
||||
const result = spawnSync('bash', [CONFIG_BIN, command], {
|
||||
encoding: 'utf8', timeout: 30_000,
|
||||
env: { PATH: process.env.PATH, HOME: STATE, GSTACK_STATE_ROOT: STATE },
|
||||
});
|
||||
expect(result.status).toBe(0);
|
||||
expect(result.stdout).not.toMatch(/checkpoint_mode|checkpoint_push/);
|
||||
}
|
||||
});
|
||||
|
||||
test('workspace history does not add call sites to the source census', () => {
|
||||
const root = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-config-census-'));
|
||||
try {
|
||||
fs.mkdirSync(path.join(root, '.context', 'old-checkout'), { recursive: true });
|
||||
fs.writeFileSync(path.join(root, 'active.md'), 'gstack-config get question_tuning\n');
|
||||
fs.writeFileSync(path.join(root, '.context', 'old-checkout', 'old.md'), 'gstack-config get retired_workspace_key\n');
|
||||
fs.writeFileSync(path.join(root, 'CHANGELOG.md'), 'Previously used gstack-config get retired_release_key\n');
|
||||
expect(keysReadInTree(root)).toEqual(['question_tuning']);
|
||||
} finally {
|
||||
fs.rmSync(root, { recursive: true, force: true });
|
||||
|
||||
Reference in New Issue
Block a user