CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-27 23:21:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

v1.89.1.0 fix: remove continuous checkpoint commits (#2970)

Browse Source 
* v1.89.1.0 fix: remove continuous checkpoint commits and repair validation blockers

* fix: clarify shipping and engineering review recovery

* fix: interpret native no-change review descriptions

* test: separate descendant readiness from timeout delivery
This commit is contained in:
Garry Tan
2026-09-24 17:27:14 -04:00
committed by GitHub
parent 06ed920a97
commit 730a1017d1
103 changed files with 1819 additions and 2279 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/gstack-skill-start.test.ts
+21 -18
View File
@@ -62,7 +62,7 @@ afterAll(() => {
* The STATUS-key contract. Post-Phase-2 these split into two consumers:
* keys the rendered prose still interprets directly (SESSION_KIND,
* CONDUCTOR_SESSION, SESSION_ID/TEL_START, EXPLAIN_LEVEL, QUESTION_TUNING,
* PROACTIVE, SKILL_PREFIX, REPO_MODE, CHECKPOINT_*, GSTACK_PLAN_MODE,
* PROACTIVE, SKILL_PREFIX, REPO_MODE, GSTACK_PLAN_MODE,
* ARTIFACTS_SYNC, ...) and keys the script's OWN emission gates consume
* (ACTIVATED, FIRST_TASK, LAKE_INTRO, TEL_PROMPTED, PROACTIVE_PROMPTED,
* HAS_ROUTING, ROUTING_DECLINED, VENDORED_GSTACK, ...). Both classes stay in
@@ -93,8 +93,6 @@ const PROSE_REFERENCED_KEYS = [
'ROUTING_DECLINED',
'VENDORED_GSTACK',
'MODEL_OVERLAY',
'CHECKPOINT_MODE',
'CHECKPOINT_PUSH',
'GSTACK_PLAN_MODE',
'ARTIFACTS_SYNC',
];
@@ -135,6 +133,26 @@ describe('gstack-skill-start contract', () => {
});
describe('gstack-skill-start behavior', () => {
for (const legacy of [false, true]) {
test(`checkpoint commits stay retired with ${legacy ? 'legacy opt-in' : 'fresh'} state`, () => {
const state = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-ss-retired-'));
const config = 'update_check: false\n' + (legacy ? 'checkpoint_mode: continuous\ncheckpoint_push: true\n' : '');
fs.writeFileSync(path.join(state, 'config.yaml'), config);
if (legacy) fs.writeFileSync(path.join(state, '.feature-prompted-continuous-checkpoint'), '');
try {
const output = runStart([], {
GSTACK_HOME: state,
GSTACK_CHECKPOINT_MODE: 'continuous',
GSTACK_CHECKPOINT_PUSH: 'true',
});
expect(output).not.toMatch(/checkpoint|auto-commit|WIP:/i);
expect(output).toContain('GSTACK_INSTRUCTION_BEGIN: feature-overlay');
expect(fs.readFileSync(path.join(state, 'config.yaml'), 'utf8')).toBe(config);
expect(fs.existsSync(path.join(state, '.feature-prompted-continuous-checkpoint'))).toBe(legacy);
} finally { fs.rmSync(state, { recursive: true, force: true }); }
});
}
test('sanitizes GSTACK_INSTRUCTION markers out of passthrough output (OV4)', () => {
// Poison the learnings passthrough: >5 entries triggers learnings-search
// passthrough; simplest deterministic injection point is FIRST_TASK via a
@@ -313,21 +331,6 @@ describe('gstack-skill-start behavior', () => {
const localStart = path.join(projectSkillRoot, 'bin', 'gstack-skill-start');
const env = { PATH: process.env.PATH!, HOME: tmpHome, GSTACK_HOME: freshGh };
try {
const checkpoint = execFileSync(localStart, ['--skill', 'testskill'], {
timeout: 30_000,
encoding: 'utf-8',
cwd: projectRoot,
env,
});
expect(checkpoint).toContain(
`touch "${path.join(freshGh, '.feature-prompted-continuous-checkpoint')}"`,
);
expect(checkpoint).not.toContain('GSTACK_INSTRUCTION_BEGIN: feature-overlay');
expect(checkpoint).not.toContain(
path.join(projectSkillRoot, '.feature-prompted-continuous-checkpoint'),
);
fs.writeFileSync(path.join(freshGh, '.feature-prompted-continuous-checkpoint'), '');
const overlay = execFileSync(localStart, ['--skill', 'testskill'], {
timeout: 30_000,
encoding: 'utf-8',