mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-10 18:50:18 +01:00
honor not-ready review verdicts with advisory findings
The classifier now honors the last recognized not-ready verdict regardless of parsed severity, returning findings and exit code 3 while retaining the highest severity in the summary. Advisory findings with a ready verdict or no verdict keep their existing behavior. Regression coverage and troubleshooting documentation describe this behavior across the execution, structured, and review gates. Fixes #3329
This commit is contained in:
1 parent
00100f1598
commit
73da98c7c1
3 files changed
+80
-5
No files matched your search
@@ -170,8 +170,10 @@ the readiness dashboard and the PR body, and never count it as a pass.
|
||||
findings.
|
||||
- **Every review gate.** These rules apply to every gate that summarises a
|
||||
review, including the `execution` gate behind `/codex` consult and challenge.
|
||||
A reply whose last `Verdict:` line says `not ready` but carries no readable
|
||||
severity prints `FINDINGS: unspecified` and exits 3 like a blocking finding.
|
||||
A reply whose last `Verdict:` line says `not ready` is `findings` and exits
|
||||
3 even when readable advisory severities (P2 or P3) were parsed; `FINDINGS:`
|
||||
names the highest one. A not-ready reply with no readable severity still
|
||||
prints `FINDINGS: unspecified` and exits 3.
|
||||
- **No findings.** A review with no tag and no label is `clean` only when its
|
||||
conclusion says so: the last sentence (or its last ", and" clause), or the
|
||||
`because` clause of its `Recommendation:` line, opens with `NO_FINDINGS`,
|
||||
|
||||
Reference in new issue
Block a user