mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-17 23:30:09 +02:00
fix(skills): use command -v instead of which for codex detection (#1197)
`which` is not on PATH in every shell — some Windows shells, BusyBox- only containers, and minimal CI images all fail when skills probe codex availability via `which codex`. `command -v` is a POSIX builtin and always available where the skill is running. Touched: - codex/SKILL.md.tmpl: CODEX_BIN=$(command -v codex || echo "") - scripts/resolvers/review.ts and scripts/resolvers/design.ts: 3 + 3 sites each rewritten to `command -v codex >/dev/null 2>&1` - Regenerated all 10 affected SKILL.md files (codex, review, ship, design-consultation, design-review, office-hours, plan-ceo-review, plan-design-review, plan-devex-review, plan-eng-review) - test/skill-validation.test.ts: updated pin + defensive regression test that fails if `which codex` returns to codex/SKILL.md - test/skill-e2e-plan.test.ts: updated summary regex Contributed by @mvanhorn via #1197. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
+1
-1
@@ -814,7 +814,7 @@ assumptions, catches things you might miss. Present its output faithfully, not s
|
||||
## Step 0.4: Check codex binary
|
||||
|
||||
```bash
|
||||
CODEX_BIN=$(which codex 2>/dev/null || echo "")
|
||||
CODEX_BIN=$(command -v codex || echo "")
|
||||
[ -z "$CODEX_BIN" ] && echo "NOT_FOUND" || echo "FOUND: $CODEX_BIN"
|
||||
```
|
||||
|
||||
|
||||
+1
-1
@@ -42,7 +42,7 @@ assumptions, catches things you might miss. Present its output faithfully, not s
|
||||
## Step 0.4: Check codex binary
|
||||
|
||||
```bash
|
||||
CODEX_BIN=$(which codex 2>/dev/null || echo "")
|
||||
CODEX_BIN=$(command -v codex || echo "")
|
||||
[ -z "$CODEX_BIN" ] && echo "NOT_FOUND" || echo "FOUND: $CODEX_BIN"
|
||||
```
|
||||
|
||||
|
||||
Reference in New Issue
Block a user