From 7672a4f07e0d9796d58dfe613edc418aad130887 Mon Sep 17 00:00:00 2001 From: garrytan Date: Mon, 2 Nov 2026 23:35:32 +0000 Subject: [PATCH] fix: pre-landing review fixes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- scripts/resolvers/qa.ts | 2 +- ship/sections/review-army.md | 2 +- test/qa-report-dir.test.ts | 2 +- test/size-ledger/ship/gst-969-qa-tree-writes.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/resolvers/qa.ts b/scripts/resolvers/qa.ts index 43dda71d8..11ab11c9c 100644 --- a/scripts/resolvers/qa.ts +++ b/scripts/resolvers/qa.ts @@ -244,7 +244,7 @@ export function generateQAReview(ctx: TemplateContext): string { Only the parent runs report-only discovery. Never overwrite another run's reports. Batch only independent Reads. -${ship ? `Without a caller REPORT_DIR, use the \`reportDir\` that \`bun ${quoteSafePath(ctx.paths.binDir)}/gstack-qa-evidence report-dir\` prints: git-excluded, so QA never changes the reviewed tree.\n` : ''} +${ship ? `Without a caller REPORT_DIR, use the \`reportDir\` that \`${quoteSafePath(ctx.paths.binDir)}/gstack-qa-evidence report-dir\` prints: git-excluded, so QA never changes the reviewed tree.\n` : ''} ${ship ? `**1. Load methods before any QA or explicit-verification probe.** ${generateQAReviewPreflight(ctx)}` : `**1. Set the charter and isolation.** diff --git a/ship/sections/review-army.md b/ship/sections/review-army.md index 1ae2738fe..83c0f10e2 100644 --- a/ship/sections/review-army.md +++ b/ship/sections/review-army.md @@ -594,7 +594,7 @@ If the Red Team fails or times out, confirm it stopped and record its review as Only the parent runs report-only discovery. Never overwrite another run's reports. Batch only independent Reads. -Without a caller REPORT_DIR, use the `reportDir` that `bun $HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded, so QA never changes the reviewed tree. +Without a caller REPORT_DIR, use the `reportDir` that `$HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded, so QA never changes the reviewed tree. **1. Load methods before any QA or explicit-verification probe.** diff --git a/test/qa-report-dir.test.ts b/test/qa-report-dir.test.ts index ee8b33e63..d5c437fb1 100644 --- a/test/qa-report-dir.test.ts +++ b/test/qa-report-dir.test.ts @@ -71,7 +71,7 @@ test('report-dir refuses outside a git work tree instead of guessing a location' test('/ship Step 9.2.1 resolves REPORT_DIR through report-dir, not the product tree', () => { const ctx: TemplateContext = { host: 'claude', skillName: 'ship', tmplPath: '', paths: HOST_PATHS.claude }; - expect(RESOLVERS.QA_REVIEW(ctx)).toContain('/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded'); + expect(RESOLVERS.QA_REVIEW(ctx)).toContain('that `$HOME/.claude/skills/gstack/bin/gstack-qa-evidence report-dir` prints: git-excluded'); const rendered = fs.readFileSync(path.resolve(import.meta.dir, '../ship/sections/review-army.md'), 'utf8'); expect(rendered).toContain('gstack-qa-evidence report-dir` prints: git-excluded'); }); diff --git a/test/size-ledger/ship/gst-969-qa-tree-writes.json b/test/size-ledger/ship/gst-969-qa-tree-writes.json index f168aa918..b6930b3bb 100644 --- a/test/size-ledger/ship/gst-969-qa-tree-writes.json +++ b/test/size-ledger/ship/gst-969-qa-tree-writes.json @@ -1,4 +1,4 @@ { - "bytes": 183, + "bytes": 179, "why": "GST-969: /ship Step 9.2.1 QA writes its reports under gstack-qa-evidence report-dir (git-excluded .gstack/tmp), not the product tree" }