From 7bbfd6ca04c921046d8f95f973e64ffa2777452d Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 16 Mar 2026 01:32:24 -0500 Subject: [PATCH] fix: contributor mode eval marked FAIL due to expected browse error The test intentionally runs a nonexistent binary to trigger contributor mode. The session runner's browse error detection catches "no such file or directory...browse" and sets browseErrors, causing recordE2E to mark passed=false. Override passed to check only exitReason since the browse error is the expected scenario. Co-Authored-By: Claude Opus 4.6 (1M context) --- test/skill-e2e.test.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/skill-e2e.test.ts b/test/skill-e2e.test.ts index 23cc81e5..8ce1f40f 100644 --- a/test/skill-e2e.test.ts +++ b/test/skill-e2e.test.ts @@ -312,7 +312,11 @@ File a contributor report about this issue. Then tell me what you filed.`, }); logCost('contributor mode', result); - recordE2E('contributor mode report', 'Skill E2E tests', result); + // Override passed: this test intentionally triggers a browse error (nonexistent binary) + // so browseErrors will be non-empty — that's expected, not a failure + recordE2E('contributor mode report', 'Skill E2E tests', result, { + passed: result.exitReason === 'success', + }); // Verify a contributor log was created with expected format const logFiles = fs.readdirSync(logsDir).filter(f => f.endsWith('.md'));