mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-06 00:44:07 +01:00
docs: agents close or label with no comment; notes to people are drafts for the maintainer (GST-1376) (#4010)
* docs: agents close or label with no comment; notes to people are drafts for the maintainer (GST-1376) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(modernize): pin the no-comment rule (GST-1376) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(modernize): Step 3 asks before any push or close, never a closing comment (GST-1376) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
ca71ca4095
commit
7c918efcda
10 files changed
+42
-19
No files matched your search
+3
-1
@@ -248,7 +248,9 @@ dependencies, CI permissions and weakened tests before anything runs it, and do
|
||||
a fork's "tests pass": run a focused review and the free tier at the port head before the
|
||||
port opens. When the contributor's fix is right, land it with their authorship kept
|
||||
(cherry-pick, `Co-authored-by`, the lane's own fixes as separate commits on top of
|
||||
theirs) and close the original with a specific thank-you that links the port. Closing a
|
||||
theirs) and close the original with no comment: the specific thank-you that links the port
|
||||
is a draft for the owner to send, and the credit stays in the port's PR body and
|
||||
`Co-authored-by`. Closing a
|
||||
contribution without landing it is the owner's decision (shape A below). The repository's
|
||||
own statement of the porting steps is [CONTRIBUTING.md](../CONTRIBUTING.md#porting-a-contributors-pr).
|
||||
|
||||
|
||||
@@ -351,7 +351,7 @@ on a few points. Ship the one that fits the repository; both are supported.
|
||||
| Small fixes | one PR each, batched by the train | batched into wave PRs, since serial slots cost about 30 minutes each |
|
||||
| After the merge | the main backstop gates any push a train did not cover, and freezes the queue on red | the controller watches main's test, e2e and release runs until the release publishes; a red main freezes the queue until root-caused |
|
||||
| Severe triage | the Captain watches issues and PRs and starts a thread per unowned severe item | a scheduled severe sweep (every 4 to 8 hours) with a fixed severity bar, dedupe against owned lanes, one hotfix thread per batch |
|
||||
| Contributor PRs | ported onto a crew branch with the author's commits kept and `Co-authored-by`; the fork PR is closed with a thank-you that links the port | landed through a wave PR with "Contributed by @handle", `Co-Authored-By` and `Supersedes` lines |
|
||||
| Contributor PRs | ported onto a crew branch with the author's commits kept and `Co-authored-by`; the fork PR is closed with no comment, and the thank-you that links the port is drafted for the owner to send | landed through a wave PR with "Contributed by @handle", `Co-Authored-By` and `Supersedes` lines |
|
||||
| Privacy | the pregate's sealed-output and secret scans before every push | plus a per-user denylist grep (names, hostnames, identifying counts from private sources) before any public artifact |
|
||||
|
||||
## Known Capy limits
|
||||
|
||||
+3
-2
@@ -831,8 +831,9 @@ Claude: Claim: #2187 caches the skill census so `bun run skill:check` stops
|
||||
already memoizes per process. The cache the PR adds would be a second one.
|
||||
|
||||
Verdict: CLOSE. The base solves the problem another way (a2f9c01). Nothing
|
||||
was pushed and the PR stays open; say "close it" and I will post the reason
|
||||
and the superseding commit, with thanks to its author.
|
||||
was pushed and the PR stays open; say "close it" and I will close it with no
|
||||
comment, and draft the reason, the superseding commit and a thank-you to
|
||||
its author for you to post.
|
||||
```
|
||||
|
||||
Three verdicts, one chosen before anything is pushed. **MODERNIZE**: the claim still
|
||||
|
||||
@@ -19,7 +19,7 @@ That is the whole promise. Other skills, optional parts such as `/cso`'s native
|
||||
|
||||
- No Windows-only or Gemini-only features, parity work, tuning or polish.
|
||||
- No new Windows or Gemini CI jobs or eval cells, apart from the path-scoped Windows checks under Windows CI below (ship-90-90 plan D). Other Windows CI tuning stops.
|
||||
- A Windows-only or Gemini-only report that doesn't break install, startup or a core workflow closes as won't fix ([triage rules](triage.md#closing-an-issue)), with a link to this page. A report that does break one of them gets a small fix.
|
||||
- A Windows-only or Gemini-only report that doesn't break install, startup or a core workflow closes as won't fix ([triage rules](triage.md#closing-an-issue)), with a link to this page in the closing comment (a maintainer's to post; an agent drafts it). A report that does break one of them gets a small fix.
|
||||
|
||||
## Windows CI
|
||||
|
||||
|
||||
@@ -7,6 +7,13 @@ feature requests into TODOS.md themes with a "not rejected" note, and reporters
|
||||
still saw a closed issue with no fix. Those were reopened on 2026-10-25 under
|
||||
the `parked` label, and this page is the rule going forward.
|
||||
|
||||
Every comment this page describes is a maintainer's to post. An agent triaging
|
||||
for the maintainer never comments to a person, not even a thank-you, a "fixed
|
||||
in" note, an ask for more information or a won't-fix note (Garry, 2026-11-04:
|
||||
"never send emails or messages to human beings on my behalf ever"). It closes or
|
||||
labels with no comment and writes each comment as a draft for the maintainer to
|
||||
send. Credit stays in PR bodies and `Co-authored-by:` lines.
|
||||
|
||||
## The three states
|
||||
|
||||
| State | Meaning | How it looks on GitHub |
|
||||
|
||||
Reference in new issue
Block a user