CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-11-08 17:58:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

docs: agents close or label with no comment; notes to people are drafts for the maintainer (GST-1376) (#4010)

Browse Source 
* docs: agents close or label with no comment; notes to people are drafts for the maintainer (GST-1376)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(modernize): pin the no-comment rule (GST-1376)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs(modernize): Step 3 asks before any push or close, never a closing comment (GST-1376)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-05 00:57:03 +00:00
1 parent ca71ca4095
commit 7c918efcda
10 files changed
+42 -19
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/modernize-skill.test.ts
+2 -1
View File
@@ -32,7 +32,7 @@ describe('/modernize skill', () => {
expect(flat).toContain('The disposition comes first. No rebase is pushed, and no PR is closed, until the verdict below is written and shown.');
expect(skill.indexOf('## Step 3: The disposition')).toBeLessThan(skill.indexOf('## Step 4 (MODERNIZE only)'));
expect(skill.indexOf('## Step 4 (MODERNIZE only)')).toBeLessThan(skill.indexOf('## Step 5 (MODERNIZE only)'));
expect(flat).toContain('STOP and ask (AskUserQuestion) before any push or any closing comment');
expect(flat).toContain('STOP and ask (AskUserQuestion) before any push or any close.');
expect(flat).toContain('If the session is unattended, the verdict and its evidence are the handoff and nothing is pushed.');
});
@@ -40,6 +40,7 @@ describe('/modernize skill', () => {
expect(flat).toContain('You never close a PR.');
expect(flat).toContain('Without explicit permission in this session, the PR stays open.');
expect(flat).toContain('The PR stays open until someone with the authority says so.');
expect(flat).toContain('You never comment on the PR. A closing note or a thank-you to its author is a draft in your report for the person to post.');
expect(skill).not.toMatch(/gh pr close/);
});