test: derive paid touchfiles from each eval's static closure (E)

touchfiles.test.ts now checks, per key, that the paid file's static
test/helpers and test/fixtures closure (plus fixture paths it names in string
literals) is covered, and names the file, path, chain and key to fix when it is
not. Free *.test.ts files are no longer touchfiles, so editing a free replay
test stops selecting paid evals: 950 entries removed, 653 real closure paths
added. The hand-copied inventories go: periodic-fixture-selection,
fake-impeccable-touchfiles and 45 per-file selection examples. Selection for
the sample edits (plan-eng-review template, claude-pty-runner,
plan-count-fixture, gstack-config) loses no case under either profile.
CONTRIBUTING documents the rule and its lower bound.
This commit is contained in:
garrytan committed 2026-09-29 07:00:28 +00:00
1 parent 689ef3094b
commit 7cbb5e04e4
53 files changed
+627 -1873

No files matched your search

+1 -9
View File
@@ -4,7 +4,7 @@ import * as fs from 'node:fs';
import * as path from 'node:path';
import * as os from 'node:os';
import { validateOfficeHoursCompletion, validateOfficeHoursReviewerHandoffs, validateOfficeHoursReviewArtifacts, validateOfficeHoursReviewPreservation, validateOfficeHoursSpecSummary, type OfficeHoursCompletionEvidence } from './helpers/office-hours-completion';
import { E2E_TOUCHFILES, E2E_TIERS } from './helpers/touchfiles-data';
import { E2E_TOUCHFILES } from './helpers/touchfiles-data';
import { selectTests } from './helpers/test-selection';
const designPath = '/tmp/office-hours-fixture/docs/designs/roster-check.md';
@@ -697,14 +697,6 @@ describe('office-hours completion eval selection', () => {
expect(selected).toContain('office-hours-section-loading');
expect(selected).not.toContain('carve-section-loading');
});
test('completion helper changes select its gate and dedicated periodic workflow', () => {
const { selected } = selectTests(['test/helpers/office-hours-completion.ts'], E2E_TOUCHFILES);
expect(selected).toEqual(['office-hours-spec-review', 'office-hours-section-loading']);
expect(selected.filter(name => E2E_TIERS[name] === 'periodic')).toEqual(['office-hours-section-loading']);
expect(E2E_TIERS['office-hours-spec-review']).toBe('gate');
expect(E2E_TOUCHFILES['office-hours-section-loading']).toContain('test/skill-e2e-office-hours-section-loading.test.ts');
});
});
describe('office-hours spec-review summary completion', () => {