fix(plan-ceo-review): name the mode preference command and the exact handoff line

auto-decide-preserved at 6fcb0981: the model never ran the preference check,
read 'check ... through the preamble' as already done, auto-selected 'per your
preference setting', and wrote 'Selected mode: HOLD SCOPE, auto-decided from
your tuned preference' instead of the AUTO_DECIDE handoff line. At 9a7a7e54 it
ran the check but wrote 'Decision: HOLD SCOPE is the review mode for ...'.
Neither matched the handoff template the observer recognizes. Name
gstack-question-preference --check at the point of use and say the handoff
begins with the exact matching line. Collapse the audit block's comment
padding to stay within the unchanged 80150-byte skeleton cap.
This commit is contained in:
garrytan committed 2026-09-30 23:23:18 +00:00
1 parent 6fcc30ddc1
commit 7eaefdec59
2 files changed
+12 -10

No files matched your search

+6 -5
View File
@@ -538,9 +538,9 @@ Sanitize every query before it leaves the machine: strip hostnames, IPs, file pa
## PRE-REVIEW SYSTEM AUDIT (before Step 0) ## PRE-REVIEW SYSTEM AUDIT (before Step 0)
Before anything else, audit the system for review context. Run: Before anything else, audit the system for review context. Run:
``` ```
git log --oneline -30 # Recent history git log --oneline -30 # Recent history
git diff <base> --stat # What's already changed git diff <base> --stat # What's already changed
git stash list # Any stashed work git stash list # Any stashed work
grep -r "TODO\|FIXME\|HACK\|XXX" -l --exclude-dir=node_modules --exclude-dir=vendor --exclude-dir=.git . | head -30 grep -r "TODO\|FIXME\|HACK\|XXX" -l --exclude-dir=node_modules --exclude-dir=vendor --exclude-dir=.git . | head -30
git log --since=30.days --name-only --format="" | sort | uniq -c | sort -rn | head -20 # Recently touched files git log --since=30.days --name-only --format="" | sort | uniq -c | sort -rn | head -20 # Recently touched files
``` ```
@@ -1024,7 +1024,8 @@ Follow the preamble's session rules; `CONDUCTOR_SESSION: true` changes transport
added capability → SELECTIVE EXPANSION; fix/refactor → HOLD SCOPE. added capability → SELECTIVE EXPANSION; fix/refactor → HOLD SCOPE.
In the Recommendation's `because` clause, connect a concrete plan fact or In the Recommendation's `because` clause, connect a concrete plan fact or
constraint to this mode's actual benefit or tradeoff, not just its count/category. constraint to this mode's actual benefit or tradeoff, not just its count/category.
3. Resolve that recommendation. When `QUESTION_TUNING: true`, first check `question_id=plan-ceo-review-mode` through the preamble. 3. Resolve that recommendation. When `QUESTION_TUNING: true`, first check `question_id=plan-ceo-review-mode` through the preamble's
`gstack-question-preference --check`.
A check that exits 0 with `AUTO_DECIDE` selects the recommendation; go to the automatic handoff in A check that exits 0 with `AUTO_DECIDE` selects the recommendation; go to the automatic handoff in
step 4. When tuning is false, omit the lookup. step 4. When tuning is false, omit the lookup.
Without that successful check, offer all four modes in one AskUserQuestion, Without that successful check, offer all four modes in one AskUserQuestion,
@@ -1032,7 +1033,7 @@ Follow the preamble's session rules; `CONDUCTOR_SESSION: true` changes transport
wins. When `QUESTION_TUNING: true`, include `<gstack-qid:plan-ceo-review-mode>`. wins. When `QUESTION_TUNING: true`, include `<gstack-qid:plan-ceo-review-mode>`.
These modes differ in kind, not coverage; do NOT score completeness. These modes differ in kind, not coverage; do NOT score completeness.
4. **Mode handoff:** After selection, send brief chat before tools or further questions: the mode's application and rationale; every governing approved row's ID, answer reference and accepted scope. Keep rows separate. 4. **Mode handoff:** After selection, send brief chat before tools or further questions: the mode's application and rationale; every governing approved row's ID, answer reference and accepted scope. Keep rows separate. Begin with the exact matching line below:
- `plan-ceo-review-mode: AUTO_DECIDE`: `Auto-decided review mode → <selected mode> (your preference). Change with /plan-tune. Approved decisions: <rows or none>. <Application and rationale>.` - `plan-ceo-review-mode: AUTO_DECIDE`: `Auto-decided review mode → <selected mode> (your preference). Change with /plan-tune. Approved decisions: <rows or none>. <Application and rationale>.`
- Other selections: `Mode: <selected mode>; approved decisions: <rows or none>. <Application and rationale>.` - Other selections: `Mode: <selected mode>; approved decisions: <rows or none>. <Application and rationale>.`
+6 -5
View File
@@ -99,9 +99,9 @@ Never skip Step 0, system audit, error/rescue map or failure modes.
## PRE-REVIEW SYSTEM AUDIT (before Step 0) ## PRE-REVIEW SYSTEM AUDIT (before Step 0)
Before anything else, audit the system for review context. Run: Before anything else, audit the system for review context. Run:
``` ```
git log --oneline -30 # Recent history git log --oneline -30 # Recent history
git diff <base> --stat # What's already changed git diff <base> --stat # What's already changed
git stash list # Any stashed work git stash list # Any stashed work
grep -r "TODO\|FIXME\|HACK\|XXX" -l --exclude-dir=node_modules --exclude-dir=vendor --exclude-dir=.git . | head -30 grep -r "TODO\|FIXME\|HACK\|XXX" -l --exclude-dir=node_modules --exclude-dir=vendor --exclude-dir=.git . | head -30
git log --since=30.days --name-only --format="" | sort | uniq -c | sort -rn | head -20 # Recently touched files git log --since=30.days --name-only --format="" | sort | uniq -c | sort -rn | head -20 # Recently touched files
``` ```
@@ -407,7 +407,8 @@ Follow the preamble's session rules; `CONDUCTOR_SESSION: true` changes transport
added capability → SELECTIVE EXPANSION; fix/refactor → HOLD SCOPE. added capability → SELECTIVE EXPANSION; fix/refactor → HOLD SCOPE.
In the Recommendation's `because` clause, connect a concrete plan fact or In the Recommendation's `because` clause, connect a concrete plan fact or
constraint to this mode's actual benefit or tradeoff, not just its count/category. constraint to this mode's actual benefit or tradeoff, not just its count/category.
3. Resolve that recommendation. When `QUESTION_TUNING: true`, first check `question_id=plan-ceo-review-mode` through the preamble. 3. Resolve that recommendation. When `QUESTION_TUNING: true`, first check `question_id=plan-ceo-review-mode` through the preamble's
`gstack-question-preference --check`.
A check that exits 0 with `AUTO_DECIDE` selects the recommendation; go to the automatic handoff in A check that exits 0 with `AUTO_DECIDE` selects the recommendation; go to the automatic handoff in
step 4. When tuning is false, omit the lookup. step 4. When tuning is false, omit the lookup.
Without that successful check, offer all four modes in one AskUserQuestion, Without that successful check, offer all four modes in one AskUserQuestion,
@@ -415,7 +416,7 @@ Follow the preamble's session rules; `CONDUCTOR_SESSION: true` changes transport
wins. When `QUESTION_TUNING: true`, include `<gstack-qid:plan-ceo-review-mode>`. wins. When `QUESTION_TUNING: true`, include `<gstack-qid:plan-ceo-review-mode>`.
These modes differ in kind, not coverage; do NOT score completeness. These modes differ in kind, not coverage; do NOT score completeness.
4. **Mode handoff:** After selection, send brief chat before tools or further questions: the mode's application and rationale; every governing approved row's ID, answer reference and accepted scope. Keep rows separate. 4. **Mode handoff:** After selection, send brief chat before tools or further questions: the mode's application and rationale; every governing approved row's ID, answer reference and accepted scope. Keep rows separate. Begin with the exact matching line below:
- `plan-ceo-review-mode: AUTO_DECIDE`: `Auto-decided review mode → <selected mode> (your preference). Change with /plan-tune. Approved decisions: <rows or none>. <Application and rationale>.` - `plan-ceo-review-mode: AUTO_DECIDE`: `Auto-decided review mode → <selected mode> (your preference). Change with /plan-tune. Approved decisions: <rows or none>. <Application and rationale>.`
- Other selections: `Mode: <selected mode>; approved decisions: <rows or none>. <Application and rationale>.` - Other selections: `Mode: <selected mode>; approved decisions: <rows or none>. <Application and rationale>.`