feat(model-overlays): add fable-5, opus-4-8, and sonnet-5 overlays + resolver mappings

model-overlays/ had no entry for the current Claude generation, so every session on a Claude 5 family or Opus 4.8 model fell through to the generic claude.md nudges. Adds the three overlays with resolver mappings and per-overlay tests; generated output for the default host is unchanged (overlays activate by detected model). Closes #2509. Contributed by @chrisquorum (PRs #2246, #2243, #2247). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-09-12 07:59:02 +02:00 · 2026-08-14 20:20:53 -07:00
parent d7ce124092
commit 81659f9456
7 changed files with 272 additions and 0 deletions
@@ -0,0 +1,55 @@
+/**
+ * Fable 5 model overlay — gate-tier assertions on the family nudges.
+ *
+ * fable-5 inherits the claude base and adds Fable-family nudges: act when you
+ * have enough context (avoid over-planning), ground progress claims in tool
+ * results, assessment-vs-action boundaries, and delegate independent work.
+ */
+import { describe, test, expect } from 'bun:test';
+import * as fs from 'fs';
+import * as path from 'path';
+import type { TemplateContext } from '../scripts/resolvers/types';
+import { HOST_PATHS } from '../scripts/resolvers/types';
+import { generateModelOverlay } from '../scripts/resolvers/model-overlay';
+
+function makeCtx(model: string): TemplateContext {
+  return {
+    skillName: 'test-skill',
+    tmplPath: 'test.tmpl',
+    host: 'claude',
+    paths: HOST_PATHS.claude,
+    preambleTier: 2,
+    model,
+  };
+}
+
+const ROOT = path.resolve(__dirname, '..');
+
+describe('Fable 5 overlay — family nudges', () => {
+  test('raw fable-5.md contains the act-when-ready nudge', () => {
+    const raw = fs.readFileSync(path.join(ROOT, 'model-overlays/fable-5.md'), 'utf-8');
+    expect(raw).toContain('Act when you have enough to act');
+  });
+
+  test('resolved overlay inherits from claude base (INHERIT:claude)', () => {
+    const out = generateModelOverlay(makeCtx('fable-5'));
+    expect(out).toContain('Todo-list discipline');
+    expect(out).toContain('subordinate');
+  });
+
+  test('resolved overlay carries the Fable nudges', () => {
+    const out = generateModelOverlay(makeCtx('fable-5'));
+    expect(out).toContain('Act when you have enough to act');
+    expect(out).toContain('Ground progress claims in evidence');
+  });
+
+  test('resolved overlay has no unresolved INHERIT directive', () => {
+    const out = generateModelOverlay(makeCtx('fable-5'));
+    expect(out).not.toContain('{{INHERIT:');
+  });
+
+  test('claude overlay (base) does not carry the Fable nudge', () => {
+    const out = generateModelOverlay(makeCtx('claude'));
+    expect(out).not.toContain('Act when you have enough to act');
+  });
+});
@@ -0,0 +1,92 @@
+/**
+ * Opus 4.8 model overlay — gate-tier assertions on the pacing directive.
+ *
+ * opus-4-8 mirrors opus-4-7's Opus-4.x family nudges: it inherits the claude
+ * base and adds effort-matching, skill-paced questions (one-per-turn when the
+ * skill carries STOP directives), and complete-scope literal execution.
+ *
+ * This test asserts:
+ * - The "Pace questions to the skill" directive is present
+ * - The old "Batch your questions" directive is absent
+ * - The AUTO_DECIDE-compatible language survives (subordination, skill wins)
+ * - The claude base is inherited (INHERIT:claude)
+ */
+import { describe, test, expect } from 'bun:test';
+import * as fs from 'fs';
+import * as path from 'path';
+import type { TemplateContext } from '../scripts/resolvers/types';
+import { HOST_PATHS } from '../scripts/resolvers/types';
+import { generateModelOverlay } from '../scripts/resolvers/model-overlay';
+
+function makeCtx(model: string): TemplateContext {
+  return {
+    skillName: 'test-skill',
+    tmplPath: 'test.tmpl',
+    host: 'claude',
+    paths: HOST_PATHS.claude,
+    preambleTier: 2,
+    model,
+  };
+}
+
+const ROOT = path.resolve(__dirname, '..');
+
+describe('Opus 4.8 overlay — pacing directive', () => {
+  test('raw opus-4-8.md contains "Pace questions to the skill"', () => {
+    const raw = fs.readFileSync(
+      path.join(ROOT, 'model-overlays/opus-4-8.md'),
+      'utf-8',
+    );
+    expect(raw).toContain('Pace questions to the skill');
+  });
+
+  test('raw opus-4-8.md does NOT contain "Batch your questions" directive', () => {
+    const raw = fs.readFileSync(
+      path.join(ROOT, 'model-overlays/opus-4-8.md'),
+      'utf-8',
+    );
+    expect(raw).not.toContain('**Batch your questions.**');
+  });
+
+  test('resolved overlay output contains "Pace questions to the skill"', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    expect(out).toContain('Pace questions to the skill');
+  });
+
+  test('resolved overlay inherits from claude base (INHERIT:claude)', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    // The claude base contributes the subordination wrapper + Todo discipline
+    expect(out).toContain('Todo-list discipline');
+    expect(out).toContain('subordinate');
+  });
+
+  test('resolved overlay says skill STOP directives trigger one-per-turn pacing', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    expect(out).toMatch(/STOP\. AskUserQuestion/);
+    expect(out).toMatch(/pace one question per turn|one question per turn/i);
+  });
+
+  test('resolved overlay requires AskUserQuestion as tool_use', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    expect(out).toContain('tool_use');
+  });
+
+  test('resolved overlay flags "obvious fix" findings still need user approval', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    expect(out).toMatch(/obvious fix/i);
+    expect(out).toMatch(/user approval/i);
+  });
+
+  test('resolved overlay keeps Effort-match / Literal interpretation nudges', () => {
+    const out = generateModelOverlay(makeCtx('opus-4-8'));
+    expect(out).toContain('Effort-match the step');
+    expect(out).toContain('Literal interpretation awareness');
+  });
+
+  test('claude overlay (no INHERIT chain) does not carry the pacing directive', () => {
+    // Claude is the default overlay; opus-4-8 inherits FROM claude.
+    // The pacing directive belongs to the opus-4-x overlays only.
+    const out = generateModelOverlay(makeCtx('claude'));
+    expect(out).not.toContain('Pace questions to the skill');
+  });
+});
@@ -0,0 +1,56 @@
+/**
+ * Sonnet 5 model overlay — gate-tier assertions on the family nudges.
+ *
+ * sonnet-5 inherits the claude base and adds Sonnet-5 family nudges: literal
+ * instruction following (state scope explicitly), scope work to the request
+ * (raise effort rather than prompting around shallow reasoning), and
+ * verbosity that tracks task complexity.
+ */
+import { describe, test, expect } from 'bun:test';
+import * as fs from 'fs';
+import * as path from 'path';
+import type { TemplateContext } from '../scripts/resolvers/types';
+import { HOST_PATHS } from '../scripts/resolvers/types';
+import { generateModelOverlay } from '../scripts/resolvers/model-overlay';
+
+function makeCtx(model: string): TemplateContext {
+  return {
+    skillName: 'test-skill',
+    tmplPath: 'test.tmpl',
+    host: 'claude',
+    paths: HOST_PATHS.claude,
+    preambleTier: 2,
+    model,
+  };
+}
+
+const ROOT = path.resolve(__dirname, '..');
+
+describe('Sonnet 5 overlay — family nudges', () => {
+  test('raw sonnet-5.md contains the literal-instructions nudge', () => {
+    const raw = fs.readFileSync(path.join(ROOT, 'model-overlays/sonnet-5.md'), 'utf-8');
+    expect(raw).toContain('Instructions are read literally');
+  });
+
+  test('resolved overlay inherits from claude base (INHERIT:claude)', () => {
+    const out = generateModelOverlay(makeCtx('sonnet-5'));
+    expect(out).toContain('Todo-list discipline');
+    expect(out).toContain('subordinate');
+  });
+
+  test('resolved overlay carries the Sonnet 5 nudges', () => {
+    const out = generateModelOverlay(makeCtx('sonnet-5'));
+    expect(out).toContain('Instructions are read literally');
+    expect(out).toContain('Scope work to the request');
+  });
+
+  test('resolved overlay has no unresolved INHERIT directive', () => {
+    const out = generateModelOverlay(makeCtx('sonnet-5'));
+    expect(out).not.toContain('{{INHERIT:');
+  });
+
+  test('claude overlay (base) does not carry the Sonnet 5 nudge', () => {
+    const out = generateModelOverlay(makeCtx('claude'));
+    expect(out).not.toContain('Instructions are read literally');
+  });
+});