Exclude a data file from /ship's review when the base policy names it by file name (GST-2674) (#4356)

* Exclude a data file from /ship's review when the base policy names it by file name (GST-2674)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Split a run-on sentence in the review-exclude changelog entry

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-14 06:31:25 +00:00
1 parent 4bee369d4a
commit 89be362eb2
4 files changed
+50 -11

No files matched your search

+1 -1
View File
@@ -1475,7 +1475,7 @@ Everything else stays in every reader's diff with one reason code:
| `executable` | its old or new mode is executable |
| `link` | its old or new mode is a symlink or a submodule commit |
| `agent-prose` | it is a skill, section, resolver, template or rule file |
| `config` | it is a data-shaped config file (`package.json`, `tsconfig*.json`, `config/`, dotfiles, `scripts/harness-pins/`) |
| `config` | it is a data-shaped config file (`package.json`, `tsconfig*.json`, `manifest.json`, `config/`, dotfiles, `scripts/harness-pins/`) and no pattern names it by file name: a pattern whose last segment is the file's exact name with no glob character (`docs/benchmarks/*/results*/**/manifest.json`) makes a matched data file content, so it is excluded and names nothing; a broader pattern (`results/**`, `**/*.json`) keeps it |
| `gate-tagged` | the gate scan tagged one of its hunks |
| `code` | it is code or a test, not content; a binary file outside the content extensions above, or one with executable magic, counts as code |
| `secret-line` | an added line names a credential (the targeted pass's secret rule, or a key name given a value such as `OPENAI_API_KEY=`) and carries a value: the credential scan finds a secret on the line, or a run of 20 or more base64 or token characters mixing upper case, lower case and digits follows a name within 200 characters. A line that only names a variable or a credential store (`${OPENAI_API_KEY}`, `$GH_TOKEN`, `process.env.X`, `os.environ["X"]`, a keychain command) keeps nothing (GST-1967: harness-evals #333's captured prompts kept 2,610 files that way). For a file git calls binary only because of its attributes, the added lines come from `git diff --text`, which `.gitattributes` cannot change (readers' own diffs still follow the attributes and show the kept file as binary). When this is the only reason, pass readers get an excerpt, not the whole file ([secret-line excerpts](#secret-line-excerpts)) |