From 8a150fcb580043db7465c1c86cd018e654b4116f Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Tue, 1 Sep 2026 16:08:15 +0000 Subject: [PATCH] test(config): signal-killed spawns map to -1, not exit 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both cfg() helpers defaulted a null spawn status to 0 — a child killed by signal would read as success and mask real failures. Co-Authored-By: Claude Fable 5 --- test/gstack-config-cross-project.test.ts | 3 ++- test/gstack-config-redact-keys.test.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/gstack-config-cross-project.test.ts b/test/gstack-config-cross-project.test.ts index a52b4dc1c..93c3f2c8a 100644 --- a/test/gstack-config-cross-project.test.ts +++ b/test/gstack-config-cross-project.test.ts @@ -23,7 +23,8 @@ function cfg(args: string[]): { code: number; out: string; err: string } { encoding: "utf8", env: { ...process.env, GSTACK_STATE_ROOT: stateRoot }, }); - return { code: r.status ?? 0, out: r.stdout ?? "", err: r.stderr ?? "" }; + // null status = killed by signal, never success — map to -1, not 0. + return { code: r.status ?? -1, out: r.stdout ?? "", err: r.stderr ?? "" }; } beforeEach(() => { diff --git a/test/gstack-config-redact-keys.test.ts b/test/gstack-config-redact-keys.test.ts index 9a73571a5..03e108510 100644 --- a/test/gstack-config-redact-keys.test.ts +++ b/test/gstack-config-redact-keys.test.ts @@ -18,7 +18,8 @@ function cfg(args: string[]): { code: number; out: string; err: string } { env: { ...process.env, GSTACK_HOME: home }, timeout: 30_000, }); - return { code: r.status ?? 0, out: r.stdout ?? "", err: r.stderr ?? "" }; + // null status = killed by signal, never success — map to -1, not 0. + return { code: r.status ?? -1, out: r.stdout ?? "", err: r.stderr ?? "" }; } beforeEach(() => {