mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-07 09:23:50 +01:00
fix: review header excludes advisory findings from N; shard settlement treats the force point as a phase boundary, not a failure
This commit is contained in:
1 parent
28af1364cb
commit
9057bf3266
7 files changed
+21
-10
No files matched your search
@@ -197,7 +197,8 @@ Core findings keep the core Confidence Calibration gates.
|
||||
#### 5. Score and present specialists
|
||||
|
||||
Only specialist findings enter this header and \`quality_score\`; core findings do not.
|
||||
Use the merged NON-advisory specialist findings for both counts and score:
|
||||
Use the merged NON-advisory specialist findings for both counts and score;
|
||||
the header's N is X + Y, so advisory findings never add to it:
|
||||
\`quality_score = max(0, 10 - (critical_count * 2 + informational_count * 0.5))\`
|
||||
Cap at 10 and retain for ${persistRef}. These are not final unresolved-defect totals.
|
||||
Print only this block: the stage 6 activity object and \`test_stub\` bodies are log and Fix-First data.
|
||||
|
||||
@@ -1432,7 +1432,7 @@ function trackShardBrowser(stateDir: string, env: NodeJS.ProcessEnv) {
|
||||
let alive = true;
|
||||
|
||||
const check = (capture: Capture) => {
|
||||
if (closed || capture.abort.signal.aborted || active !== capture) throw new CaptureStopped();
|
||||
if (closed || capture.abort.signal.aborted || active !== capture || (!forced && performance.now() >= forceAt)) throw new CaptureStopped();
|
||||
if (performance.now() >= Math.min(capture.deadline, deadline)) throw new BrowserCleanupError('browser ownership deadline exceeded');
|
||||
};
|
||||
const probe = async (capture: Capture, command: string, args: string[], timeout: number) => {
|
||||
@@ -1462,7 +1462,7 @@ function trackShardBrowser(stateDir: string, env: NodeJS.ProcessEnv) {
|
||||
killProcessGroup(child, 'SIGKILL');
|
||||
reaper = setTimeout(() => finish(null), 100);
|
||||
};
|
||||
const timer = setTimeout(stop, Math.max(1, remaining));
|
||||
const timer = setTimeout(() => { if (!closed) errors.add('browser identity probe did not complete'); stop(); }, Math.max(1, Math.min(remaining, forced ? Infinity : forceAt - performance.now())));
|
||||
capture.abort.signal.addEventListener('abort', stop, { once: true });
|
||||
child.once('error', () => { failed = true; finish(null); });
|
||||
child.once('close', finish);
|
||||
@@ -1693,7 +1693,7 @@ function trackShardBrowser(stateDir: string, env: NodeJS.ProcessEnv) {
|
||||
};
|
||||
const enqueue = () => {
|
||||
if (closed || pending || process.platform === 'win32') return;
|
||||
const operation: Capture = { abort: new AbortController(), deadline: Math.min(performance.now() + 10000, deadline, forced ? Infinity : forceAt), probes: new Set() };
|
||||
const operation: Capture = { abort: new AbortController(), deadline: Math.min(performance.now() + 10000, deadline), probes: new Set() };
|
||||
active = operation;
|
||||
pending = (async () => {
|
||||
try {
|
||||
|
||||
Reference in new issue
Block a user