mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-02 15:04:37 +01:00
v1.91.328.0 ship-queue: screen only when the selector restores every case; unscreened PRs fill train seats (GSTA-165 1a) (#3619)
* Narrow screens leave hub files to the train gate; map size-ledger baselines and the careful mask awk Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (pull_request runs stay broad, deleted hubs, READY and summary previews) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: CHANGELOG for narrow screens (Unreleased) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: TESTING_INTERNALS describes narrow and broad PR screen policy Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore: record test-pr-profile.ts as non-behavioral at HARNESS_VERSION 6 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-queue: screen only when the selector restores every case; unscreened PRs fill train seats (GSTA-165 1a) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test: pin the diffs that still screen (unselectable, skill template + bun.lock) Two assertions in test/ship-queue-train-logic.test.ts: a diff the paid selector cannot select recommends --screen with the full gate selection, and a diff that mixes a skill template with bun.lock recommends --screen. GSTA-165 1a, from /ship Steps 7-8. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: CHANGELOG tests and deferrals; P1 TODOs for GSTA-165 follow-ups CHANGELOG [Unreleased]: name the two added tests and list the deferred CREW.md rule 22 text and train-record attribution field. TODOS.md: both deferrals as P1 under Ship. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
959c8a6a4f
commit
9184ffd16c
12 files changed
+121
-53
No files matched your search
+8
-5
@@ -414,9 +414,12 @@ gstack-ship-queue ready --pr 42 --screen [--broad] # dispatches one paid screen
|
||||
```
|
||||
|
||||
Without a choice it prints the `SCREEN:` selection (with
|
||||
`screen_selection: gstack-paid`, the skill's own cases and `recommend
|
||||
--screen` or `--no-screen`: `--screen` when the screen selects a skill's own
|
||||
cases) and refuses with `READY_SCREEN_CHOICE_REQUIRED`. The price line says
|
||||
`screen_selection: gstack-paid`, the skill's own cases, the selector's mode and
|
||||
`recommend --screen` or `--no-screen`: `--screen` only when the selector's
|
||||
mode is `full-fallback`, an unknown dependency or a shared runtime input that
|
||||
restores every case, or when it cannot select at all; every other PR rides
|
||||
unscreened, and the train gate's full census runs its cases on the tree that
|
||||
merges) and refuses with `READY_SCREEN_CHOICE_REQUIRED`. The price line says
|
||||
the dollar figure is pending the cost replay; until it lands, `SCREEN:` shows
|
||||
case counts and the recommendation only. A lane that already ran focused
|
||||
local cases says so in the READY block and may pass `--no-screen`. `--screen`
|
||||
@@ -466,8 +469,8 @@ gstack-ship-queue train build --prs 41@<sha>,42@<sha>,43@<sha>
|
||||
```
|
||||
|
||||
It prints `ORDER:` (the slot order to announce: screened PRs first in READY
|
||||
order, then unscreened; when `max_size` or more unscreened PRs wait they form
|
||||
their own train and `HELD:` lists them; `--order <pr>,<pr>,...` naming every
|
||||
order, then unscreened PRs fill the remaining seats, and `HELD:` lists the PRs
|
||||
over `max_size`; `--order <pr>,<pr>,...` naming every
|
||||
pinned PR once replaces that rule, for a PR that must merge before another,
|
||||
and the train's later `NEXT:` rebuilds keep it), one `PREFIX: T<i> <commit>
|
||||
tree=<tree>` per prefix and one `SLOT:` per PR. `--dry-run` adds the
|
||||
|
||||
Reference in new issue
Block a user