mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-01 02:40:47 +02:00
Merge remote-tracking branch 'origin/main' into perth-v2
# Conflicts: # CLAUDE.md # package.json
This commit is contained in:
@@ -150,7 +150,7 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
|
||||
},
|
||||
behavioral: 'external',
|
||||
externalTest: 'test/skill-e2e-ship-section-loading.test.ts',
|
||||
maxSkeletonBytes: 71_300, // token-reduction Phases 1-2 + #2700 document-release anchors; measured 70,568 post-merge regen
|
||||
maxSkeletonBytes: 73_601, // Aside third-party-actions contract + review-fix sentences; measured 72,872
|
||||
minUnionBytes: 181_000, // token-reduction Phases 1-2 (v1.69.x branch); measured union 201,464
|
||||
mustContain: ['VERSION', 'CHANGELOG', 'review', 'merge', 'PR'],
|
||||
// v1.58.5.0: pre-push-guard install (#2077) stacks on the shared first-run-guidance preamble.
|
||||
@@ -295,7 +295,7 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
|
||||
// the #538 opt-out + D1 evidence directive — ratio 1.104 measured.
|
||||
// #2499 project-scope MCP jq in the brain-sync block grew every tier-2+
|
||||
// skeleton ~1.5KB (entry resolution emitted once per SKILL.md).
|
||||
maxSkeletonBytes: 68_200, // token-reduction Phase 4 wave 4 (v1.69.x branch): 2A/2B carved out; measured 66,852
|
||||
maxSkeletonBytes: 69_978, // Aside third-party-actions contract + review-fix sentences; measured 69,285
|
||||
minUnionBytes: 115_800, // Phase 4 wave 4; measured union 118,175
|
||||
mustContain: ['design doc', 'problem statement'],
|
||||
maxSizeRatio: 1.12,
|
||||
@@ -477,7 +477,7 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
|
||||
gateAfterStop: undefined, // operational skill
|
||||
},
|
||||
behavioral: 'prompt',
|
||||
maxSkeletonBytes: 57_500, // Phase 4 wave 1; estimated ~56.2KB rendered — re-measured at regen
|
||||
maxSkeletonBytes: 58_733, // Aside third-party-actions contract + review-fix sentences; measured 58,151
|
||||
minUnionBytes: 91_000, // Phase 4 wave 1; estimated union ~94.9KB
|
||||
mustContain: ['readiness', 'merge', 'canary', 'revert', 'staging'],
|
||||
},
|
||||
@@ -541,7 +541,7 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
|
||||
gateAfterStop: undefined,
|
||||
},
|
||||
behavioral: 'prompt',
|
||||
maxSkeletonBytes: 51_200, // Phase 4 wave 2: Phases 4.5-5 carved at the post-confirmation boundary; measured 50,681
|
||||
maxSkeletonBytes: 53_645, // Aside third-party-actions contract + review-fix sentences; measured 53,114
|
||||
minUnionBytes: 64_500, // measured union 67,430
|
||||
mustContain: ['HARD GATE', 'dedupe', 'quality gate', 'acceptance criteria', 'archive'],
|
||||
},
|
||||
|
||||
@@ -0,0 +1,58 @@
|
||||
/**
|
||||
* Functional filesystem-capability probe for tests that simulate failure by
|
||||
* revoking permissions (chmod 0500 a dir, then assert writes fail).
|
||||
*
|
||||
* The existing `process.getuid?.() === 0` guards catch only literal root —
|
||||
* but containers with CAP_DAC_OVERRIDE, user-namespace sandboxes, and some
|
||||
* overlay/fuse mounts ignore mode bits for non-root users too (observed:
|
||||
* Vercel sandbox, uid 1000, writes succeed in a 0500 dir). There the
|
||||
* "unwritable" simulation silently holds nothing and the test asserts a
|
||||
* failure that never happens. This probe tests the actual behavior once per
|
||||
* process instead of guessing from the uid.
|
||||
*/
|
||||
import * as fs from 'fs';
|
||||
import * as path from 'path';
|
||||
import * as os from 'os';
|
||||
|
||||
let cachedWrite: boolean | null = null;
|
||||
let cachedRead: boolean | null = null;
|
||||
|
||||
/** True when chmod 0000 on a file actually blocks this process's reads. */
|
||||
export function canRevokeReads(): boolean {
|
||||
if (cachedRead !== null) return cachedRead;
|
||||
if (process.platform === 'win32' || process.getuid?.() === 0) return (cachedRead = false);
|
||||
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'fs-caps-'));
|
||||
const file = path.join(dir, 'probe');
|
||||
fs.writeFileSync(file, 'x');
|
||||
fs.chmodSync(file, 0o000);
|
||||
try {
|
||||
fs.readFileSync(file);
|
||||
cachedRead = false; // read succeeded → mode bits are not enforced here
|
||||
} catch {
|
||||
cachedRead = true;
|
||||
} finally {
|
||||
fs.chmodSync(file, 0o600);
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
}
|
||||
return cachedRead;
|
||||
}
|
||||
|
||||
/** True when chmod 0500 on a directory actually blocks this process's writes. */
|
||||
export function canRevokeWrites(): boolean {
|
||||
if (cachedWrite !== null) return cachedWrite;
|
||||
if (process.platform === 'win32' || process.getuid?.() === 0) return (cachedWrite = false);
|
||||
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'fs-caps-'));
|
||||
const locked = path.join(dir, 'locked');
|
||||
fs.mkdirSync(locked);
|
||||
fs.chmodSync(locked, 0o500);
|
||||
try {
|
||||
fs.writeFileSync(path.join(locked, 'probe'), 'x');
|
||||
cachedWrite = false; // write succeeded → mode bits are not enforced here
|
||||
} catch {
|
||||
cachedWrite = true;
|
||||
} finally {
|
||||
fs.chmodSync(locked, 0o700);
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
}
|
||||
return cachedWrite;
|
||||
}
|
||||
@@ -133,6 +133,11 @@ export const E2E_TOUCHFILES: Record<string, string[]> = {
|
||||
'plan-design-with-ui-scope': ['plan-design-review/**', 'test/fixtures/plans/ui-heavy-feature.md', 'test/helpers/claude-pty-runner.ts', 'test/skill-e2e-plan-design-with-ui.test.ts'],
|
||||
'budget-regression-pty': ['test/helpers/eval-store.ts', 'test/skill-budget-regression.test.ts'],
|
||||
'ship-idempotency-pty': ['ship/**', 'bin/gstack-next-version', 'bin/gstack-version-bump', 'scripts/resolvers/sections.ts', 'lib/worktree.ts', 'test/helpers/claude-pty-runner.ts', 'test/skill-e2e-ship-idempotency.test.ts'],
|
||||
'tpa-present': ['scripts/resolvers/third-party-actions.ts', 'ship/SKILL.md.tmpl', 'ship/sections/apple-release.md.tmpl', 'scripts/gen-skill-docs.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-third-party-actions.test.ts'],
|
||||
'tpa-absent-linux': ['scripts/resolvers/third-party-actions.ts', 'ship/SKILL.md.tmpl', 'ship/sections/apple-release.md.tmpl', 'scripts/gen-skill-docs.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-third-party-actions.test.ts'],
|
||||
'tpa-broken': ['scripts/resolvers/third-party-actions.ts', 'ship/SKILL.md.tmpl', 'ship/sections/apple-release.md.tmpl', 'scripts/gen-skill-docs.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-third-party-actions.test.ts'],
|
||||
'tpa-absent-darwin': ['scripts/resolvers/third-party-actions.ts', 'ship/SKILL.md.tmpl', 'ship/sections/apple-release.md.tmpl', 'scripts/gen-skill-docs.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-third-party-actions.test.ts'],
|
||||
'tpa-apple-ban': ['scripts/resolvers/third-party-actions.ts', 'ship/SKILL.md.tmpl', 'ship/sections/apple-release.md.tmpl', 'scripts/gen-skill-docs.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-third-party-actions.test.ts'],
|
||||
'ship-section-loading': ['ship/**', 'scripts/resolvers/sections.ts', 'scripts/gen-skill-docs.ts', 'test/helpers/auq-sdk-capture.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-ship-section-loading.test.ts'],
|
||||
'plan-ceo-section-loading': ['plan-ceo-review/**', 'scripts/resolvers/sections.ts', 'scripts/gen-skill-docs.ts', 'test/helpers/auq-sdk-capture.ts', 'test/helpers/session-runner.ts', 'test/skill-e2e-plan-ceo-review-section-loading.test.ts'],
|
||||
// Data-driven behavioral guard for the 'plan'/'prompt' carves (eng, design,
|
||||
@@ -552,6 +557,12 @@ export const E2E_TIERS: Record<string, 'gate' | 'periodic'> = {
|
||||
'plan-design-with-ui-scope': 'gate', // ~$0.80/run
|
||||
'budget-regression-pty': 'gate', // free, library-only assertion
|
||||
'ship-idempotency-pty': 'periodic', // ~$3/run, real /ship in plan mode
|
||||
'tpa-present': 'gate', // consent/credential safety guardrail; deterministic shims + grep asserts
|
||||
'tpa-absent-linux': 'gate', // consent/credential safety guardrail; deterministic shims + grep asserts
|
||||
'tpa-broken': 'gate', // consent/credential safety guardrail; deterministic shims + grep asserts
|
||||
'tpa-absent-darwin': 'gate', // consent/credential safety guardrail; deterministic shims + grep asserts
|
||||
'tpa-apple-ban': 'gate', // consent/credential safety guardrail; deterministic shims + grep asserts
|
||||
|
||||
'ship-section-loading': 'periodic', // ~$3/run, real /ship; asserts section reads
|
||||
'plan-ceo-section-loading': 'periodic', // ~$3-5/run, real /plan-ceo-review; asserts section read
|
||||
'carve-section-loading': 'periodic', // ~$1-2/skill, data-driven; GSTACK_CARVE_SKILL scopes to one
|
||||
|
||||
Reference in New Issue
Block a user