From 939790f1f0ecfc12f5e39954ff5e1ffedad7450c Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 31 Oct 2026 04:16:45 +0000 Subject: [PATCH] docs(review): one sentence after the floor in ship-policy; review-floor comment names only the reviewers that carry it Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- docs/ship-policy.md | 5 +++-- scripts/resolvers/review-floor.ts | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/ship-policy.md b/docs/ship-policy.md index 9ef4fe759..efeb3b7ee 100644 --- a/docs/ship-policy.md +++ b/docs/ship-policy.md @@ -986,8 +986,9 @@ construction: context; `outside`: anything else), a `kind`, `blocking` and a `scope`. `blocking` is a CRITICAL defect. CRITICAL is the blocking floor: a finding that would fail a test, break production, lose data or secrets, or open a security hole - (injection, auth bypass, secret exposure). Everything else is INFORMATIONAL. Everything else (an advisory, an informational - item, a test gap, a wording note) is below the floor. Pass 1 fixes findings in + (injection, auth bypass, secret exposure). Everything else is INFORMATIONAL. + An advisory, an informational item, a test gap or a wording note is below the + floor. Pass 1 fixes findings in the diff (`scope: fix`). A blocking finding in code the PR did not change is `scope: defer`: `gstack-review-scope defer` files it as a GitHub issue (reusing an open issue that carries the same `` diff --git a/scripts/resolvers/review-floor.ts b/scripts/resolvers/review-floor.ts index 9336c385b..3cc54373c 100644 --- a/scripts/resolvers/review-floor.ts +++ b/scripts/resolvers/review-floor.ts @@ -1,6 +1,6 @@ /** * The blocking floor every gstack reviewer prompt carries (docs/review-policy.md#the-blocking-floor). - * One sentence, so the core checklist, each specialist, the Red Team and the fix-check rate - * severity the same way. test/review-severity-floor.test.ts keeps the markdown copies in step. + * One sentence, so the core checklist, each specialist and the fix-check rate severity the + * same way. test/review-severity-floor.test.ts keeps the markdown copies in step. */ export const BLOCKING_FLOOR = 'CRITICAL is the blocking floor: a finding that would fail a test, break production, lose data or secrets, or open a security hole (injection, auth bypass, secret exposure). Everything else is INFORMATIONAL.';