mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-22 16:11:34 +01:00
Second-model review keeps the reviewer's result and reports budget stops (GST-3181) (#4515)
When Codex reviews a change, gstack now keeps the review file the reviewer wrote instead of replacing it with Codex's one-line closing message, and a provider that refuses with HTTP 402 is reported as a used-up budget instead of "exit 1" or a login failure. Why: gstack-evals lost 22 review attempts to the overwrite and 5 of 45 sessions to a 402 from a metering proxy whose cause gstack threw away. Nothing to do: a 401 or 403 is still a login problem. Open notes, one of them a known gap, are listed below. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: p1/specialist-batched#1 reader=testing Review-Finding: p1/red-team#1 reader=red-team Review-Finding: p1/red-team#2 reader=red-team
This commit is contained in:
1 parent
f13dbb0d4a
commit
957fab79c5
14 files changed
+311
-10
No files matched your search
@@ -545,6 +545,24 @@ for the account or API key on the provider's dashboard.
|
||||
|
||||
**Expected result.** `CODEX_MODE: ready`, and the review completes.
|
||||
|
||||
<a id="outside-review-budget-exhausted"></a>
|
||||
### `unavailable: the provider refused the review with HTTP 402 (payment required)`
|
||||
|
||||
**Meaning.** The second-model review (Codex, or Claude Code from a Codex
|
||||
session) reached its provider, and the provider refused the call with HTTP 402
|
||||
Payment Required. The money behind the key is used up: a metering proxy or
|
||||
gateway in front of the provider hit its allowance, or the account ran out of
|
||||
credits or quota. The login worked, so this is not an authentication failure,
|
||||
even when the provider's message mentions the API key. gstack reports outside
|
||||
coverage as unavailable, never as a pass.
|
||||
|
||||
**Fix.** Check the allowance on the proxy or gateway that sits in front of the
|
||||
provider (its dashboard or its admin), or the account's quota and credits on
|
||||
the provider's billing page. Raise it or wait for it to reset, then re-run the
|
||||
review. Signing in again (`codex login`, `claude auth login`) does not help.
|
||||
|
||||
**Expected result.** The review completes with `OUTSIDE_STATUS: completed`.
|
||||
|
||||
<a id="codex-mode-unverified"></a>
|
||||
### `CODEX_MODE: unverified` / `MODEL_PROBE_INCONCLUSIVE`
|
||||
|
||||
|
||||
Reference in new issue
Block a user