CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-08 06:26:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: let /review satisfy ship readiness gate (#280)

Browse Source 
- Add Step 5.8 to /review: persist review outcome to review log
- Update shared REVIEW_DASHBOARD resolver: accept both `review` and
  `plan-eng-review` as valid Eng Review sources
- Update ship abort text to mention both review options
- Add 4 validation tests for persistence, propagation, and abort text

Based on PR #338 by @malikrohail. DRY improvement per eng review:
updated shared resolver instead of creating duplicate.

Refs #280.
This commit is contained in:
Garry Tan
2026-03-23 07:16:09 -07:00
parent 3d1e8e0eac
commit 9809d50ac2
11 changed files with 100 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
review/SKILL.md
+21
View File
@@ -898,6 +898,27 @@ High-confidence findings (agreed on by multiple sources) should be prioritized f
---
## Step 5.8: Persist Eng Review result
After all review passes complete, persist the final `/review` outcome so `/ship` can
recognize that Eng Review was run on this branch.
Run:
```bash
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"review","timestamp":"TIMESTAMP","status":"STATUS","issues_found":N,"critical":N,"informational":N,"commit":"COMMIT"}'
```
Substitute:
- `TIMESTAMP` = ISO 8601 datetime
- `STATUS` = `"clean"` if there are no remaining unresolved findings after Fix-First handling and adversarial review, otherwise `"issues_found"`
- `issues_found` = total remaining unresolved findings
- `critical` = remaining unresolved critical findings
- `informational` = remaining unresolved informational findings
- `COMMIT` = output of `git rev-parse --short HEAD`
If the review exits early before a real review completes (for example, no diff against the base branch), do **not** write this entry.
## Important Rules
- **Read the FULL diff before commenting.** Do not flag issues already addressed in the diff.
review/SKILL.md.tmpl
+21
View File
@@ -250,6 +250,27 @@ If no documentation files exist, skip this step silently.
{{ADVERSARIAL_STEP}}
## Step 5.8: Persist Eng Review result
After all review passes complete, persist the final `/review` outcome so `/ship` can
recognize that Eng Review was run on this branch.
Run:
```bash
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"review","timestamp":"TIMESTAMP","status":"STATUS","issues_found":N,"critical":N,"informational":N,"commit":"COMMIT"}'
```
Substitute:
- `TIMESTAMP` = ISO 8601 datetime
- `STATUS` = `"clean"` if there are no remaining unresolved findings after Fix-First handling and adversarial review, otherwise `"issues_found"`
- `issues_found` = total remaining unresolved findings
- `critical` = remaining unresolved critical findings
- `informational` = remaining unresolved informational findings
- `COMMIT` = output of `git rev-parse --short HEAD`
If the review exits early before a real review completes (for example, no diff against the base branch), do **not** write this entry.
## Important Rules
- **Read the FULL diff before commenting.** Do not flag issues already addressed in the diff.