From 997a4c9c30bd056334bd653c1bca770cdc7b8ae7 Mon Sep 17 00:00:00 2001 From: garrytan Date: Mon, 26 Oct 2026 01:13:07 +0000 Subject: [PATCH] docs(triage): parked label comes off at close; CHANGELOG entry follows the user-facing style /ship adversarial review pass 2 on #3427: docs/triage.md said the label "goes with" a fixed close but nothing about duplicate or won't-fix closes, and a lane "may" remove it, which left an open lane-owned issue either parked or not. The CHANGELOG entry named TODOS.md in the user-facing summary and listed the GitHub-side label under Added; docs/CHANGELOG_STYLE.md keeps contributor details in a "For contributors" section. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- CHANGELOG.md | 9 ++++----- docs/triage.md | 10 ++++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index afd3fb7f7..7c895241d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,15 +2,14 @@ ## [Unreleased] -**An issue we intend to fix later now stays open under the `parked` label instead of being closed into a TODOS theme.** The Oct 11 triage closed 75 feature requests with a "not rejected, tracked in TODOS.md" note, and GitHub showed them as closed with no fix. Those 75 are reopened under `parked`, each with one comment saying where it is tracked and what fixes it, and the rule is written down: closing means fixed, duplicate or won't fix, each with its reason. +**An issue we intend to fix later now stays open under the `parked` label instead of being closed.** The Oct 11 triage closed 75 feature requests with a "not rejected" note, and GitHub showed them as closed with no fix. Those 75 are open again under the new `parked` label on garrytan/gstack ("Not fixed yet, not rejected: stays open; a comment says where it is tracked and what fixes it"), each with one comment saying where the work is tracked and what fixes it. The rule is written down: an issue closes only as fixed, duplicate or won't fix, each with its reason; a report that main already fixed closes as fixed, not won't fix; and a duplicate uses GitHub's own duplicate close reason. ### Added -- **`docs/triage.md`**: the three issue states (open, parked, closed), how to park an issue (the label plus one comment naming where it is tracked and what fixes it), the three close reasons with their GitHub close reason and label, and where the Wave 9 themes live. -- The `parked` label on garrytan/gstack: "Not fixed yet, not rejected: stays open; a comment says where it is tracked and what fixes it". +- **`docs/triage.md`**: the three issue states (open, parked, closed), how to park an issue (the label plus one comment naming where it is tracked and what fixes it), when the label comes off, the three close reasons with their GitHub close reason and label, and where the parked themes live. -### Changed +### For contributors - **`CONTRIBUTING.md`**: an "Issue triage" section ahead of the PR wave process, pointing at docs/triage.md. -- **`TODOS.md`**: the Wave 9 feature-themes note says issues stay open under `parked` with a link to their theme, instead of closing with one. +- **`TODOS.md`**: the Wave 9 feature-themes note says issues stay open under `parked` and points at their theme there (73 listed, 75 with #3061 and #3122), instead of closing with a link. ## [1.91.221.0] - 2026-10-25 diff --git a/docs/triage.md b/docs/triage.md index 9e94a87aa..c32ade091 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -29,10 +29,12 @@ folding it into a tracking issue, or deciding it waits for other work are all 3. Add the issue number to the TODOS.md entry so the theme credits the reporter when it is picked up. -When the work ships, close the issue as fixed with the version or PR, and the -label goes with it. When a lane picks a parked issue up, it may remove the -label while it works on it; an issue the lane later drops goes back to parked -with an updated comment. +When the work ships, close the issue as fixed with the version or PR. Whatever +the close reason, remove the `parked` label when the issue closes, so a +`label:parked` search lists only open parked issues. When a lane picks a parked +issue up, it removes the label while it works on it (the issue is open again, +with the lane on it); an issue the lane later drops goes back to parked with an +updated comment. ## Closing an issue