mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-12 19:44:48 +01:00
fix(render): offer the Aside remedy only on macOS (#3735); fix docs/skills.md vision-model line (#3375) (#4131)
* fix(render): offer the Aside remedy only on macOS (#3735) NO_BROWSER_HELP told Linux and Windows hosts to open the Aside app, which ships only for macOS. noBrowserHelp(platform) now adds the Aside remedy on darwin only and keeps the ./setup and GSTACK_BROWSE_BIN remedies everywhere. Also corrects docs/skills.md's /design-html refinement loop, which still said "Uses GPT-4o vision", to match the design-html template (#3375). Rewritten on main from outside PR #4122. Co-authored-by: szsunyuan <3579304+szsunyuan@users.noreply.github.com> Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * chore(changelog): name the #3735 fragment after the branch Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: szsunyuan <3579304+szsunyuan@users.noreply.github.com> Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
6 files changed
+29
-6
No files matched your search
+6
-1
@@ -678,7 +678,12 @@ export async function renderWithBrowse(spec: RenderSpec, bin: string | null = re
|
||||
// ─── Engine choice ───────────────────────────────────────────────────────────
|
||||
|
||||
export const NO_BROWSER = 'no browser available';
|
||||
export const NO_BROWSER_HELP = "open the Aside app (macOS 15+, aside.com), or run ./setup in the gstack repo to build gstack's own headless browser (or point GSTACK_BROWSE_BIN at a browse binary)";
|
||||
/** Recovery advice for a missing browser. Aside ships only for macOS, so other platforms get only the bundled-browser remedies. */
|
||||
export function noBrowserHelp(platform: NodeJS.Platform = process.platform): string {
|
||||
const aside = platform === 'darwin' ? 'open the Aside app (macOS 15+, aside.com), or ' : '';
|
||||
return `${aside}run ./setup in the gstack repo to build gstack's own headless browser (or point GSTACK_BROWSE_BIN at a browse binary)`;
|
||||
}
|
||||
export const NO_BROWSER_HELP = noBrowserHelp();
|
||||
|
||||
export type EngineChoice =
|
||||
| { engine: 'aside'; version: string }
|
||||
|
||||
Reference in new issue
Block a user